summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* annotation: avoid resizing editing commentHEADmasterPranam Lashkari16 hours1-1/+2
| | | | | | | | | | problem: when you try to reply to long comment, it would be resized and subsequntly reply box will take space and other comments will not make enough space for it Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I4d81904721e5bb196947598d0dca211ee9d480a6
* annotation: fixed comments could not expandPranam Lashkari16 hours1-5/+2
| | | | | | | | | | | | | | | | | | problem: when comment was on the edge of the document/screen(vertically) resize was called which ultimately collapsed the comments in small screen which could not be expanded unless scrolled further from edge. It was more problematic for the threads, if entire thread could not fit in the screen it was always failing to expand regression from bac4161 it nullifies the effect from 81b00e7 now if comment is added at the end of the document and it goes beyond doc boundry doc will not scroll automatically to make entire comment visible Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I198b4887ae19ca0c17ba1453960cd36a66beb04d
* annotation: fixed thread scrolling to root comment on actionPranam Lashkari16 hours1-8/+11
| | | | | | | | | | problem: when long thread did not fit on screen and actions were performed on last comments of thread which put root comment out of view, it will cause scroll back to root comment (i.e: reply) Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I23d699425dc2dff1cfeddf6ab9be7131f80c3a31
* annotation: avoid explicit unselect before selectPranam Lashkari16 hours1-7/+1
| | | | | | | select function now can take care of reselection and layout update Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I2a061643ec190d5b2d005b940923a28131ed6cb0
* annotation: make comment section scrollable with mousePranam Lashkari16 hours1-0/+14
| | | | | Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: Ib6a2fee7ace81ffbc82ec4545e6f613f79c6734f
* do invalidation tests without spellcheckingCaolán McNamara16 hours3-12/+12
| | | | | | | | which may kick in at an arbitrary point. We shouldn't invalidate if there is no change, but that's a TODO. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I910c96f2c2a0efab393ccea52c9f25d5804cd967
* cool#8648 clipboard: fix idle testsMiklos Vajna22 hours1-1/+4
| | | | | | | | | | | | This is not part of CI at the moment, so I didn't notice it till Szymon pointed it out. make -C cypress_test check-idle spec=calc/idle_spec.js passes with this, which is the only suite in 'make check-idle'. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ieeb15653abcc016bc7de87115df136dfe3f27d0d
* Use app.file.textCursor.rectangle instead of map._docLayer._visibleCursor.Gökay Şatır22 hours7-70/+74
| | | | | Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: I9108d5b3281cf6d2c904d227880e451b608d8d37
* Use "app.file.textCursor.visible" instead of "map._isCursorVisible".Gökay Şatır22 hours6-13/+11
| | | | | Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: Iedb841ec64b4fa72511603ac7e43c997676da837
* Rename app.file.cursor to app.file.textCursor.Gökay Şatır22 hours4-9/+9
| | | | | Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: Ic81a775efb6592e81f52e8b2a6789ac5a90c761c
* cool#8806 clipboard: improve detection of HTML that's just an imageMiklos Vajna27 hours2-7/+51
| | | | | | | | | | | | | | | | | | | | | Copy an image in Firefox, paste in Chrome with the Paste button or with Ctrl-V. Nothing happens in Calc, Writer gives you a popup to copy the image, which is already the case. What happens is that Clipboard.js already had some code to guess when the HTML only contains an image, but while Chrome puts '<img ...' to the clipboard, Firefox puts '<meta ...><img ...', so we don't recognize the content as image. Fix the problem by adding a new isHtmlImage() function to Clipboard.js that handles both markups and use it from both places that deal with paste (Paste button, keyboard). Note that this manual parsing is needed, because the input is user provided, so DOMParser or innerHTML would not be safe. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: Ia1340cd3777c5597e3fd257e905e9cc637802bcc
* killpoco: remove lots of redundant JSON includes.Michael Meeks28 hours21-40/+22
| | | | | Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Change-Id: I976c5b8d6763cbbf0ee5cadfa2f7335ec719fe85
* Cypress: Remove beforeAll and rewrite document loading helpersNeil Guertin29 hours26-460/+353
| | | | | | | | | | New helpers setupDocument, loadDocument, reloadDocument Clean up beforeEach functions Replace most calls to beforeAll with setupAndLoadDocument Replace calls to reload with reloadDocument Signed-off-by: Neil Guertin <neil.guertin@collabora.com> Change-Id: I12307f93c8a418e6f55bb36b8afe340d7841b726
* Replace beforeAll with setupAndLoadDocumentNeil Guertin29 hours126-418/+187
| | | | | | | | | Replace beforeAll in most tests with new helper function Tests that need to close or reopen test files cannot use the new function and will be updated later Signed-off-by: Neil Guertin <neil.guertin@collabora.com> Change-Id: I372280e55993123fc26f83cb2e6e6e78665a6846
* Cypress: Remove afterEach/afterAllNeil Guertin29 hours138-780/+137
| | | | | | | | | | | | | | Cypress recommends NOT cleaning up after tests https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks Open documents should not affect other tests Files will be closed automatically by the server anyways Tests with more strict requirements can explicitly close documents before, during, or after those tests This is necessary to support beforeAll cleanup Half of tests were verifying the wrong filename was closed anyways Signed-off-by: Neil Guertin <neil.guertin@collabora.com> Change-Id: Iab458963a3fbfe87f732dc97140704c2d0ef53d4
* iOS: stop keyboard pushing content offscreenSkyler39 hours1-0/+11
| | | | | | | | | | | | | | | | | | Previously using the onscreen keyboard would shrink the visual viewport while leaving the elements at the same size, meaning some of the content had to be offscreen. As we scrolled the page to have the cursor in view, this would move the notebook bar offscreen. To avoid the possibility of the cursor leaving the screen or the bottom toolbar being offscren, we can use the VisualViewport API to force the logical viewport to have the same size as the visual one This won't have an effect in iframes as the logical and visual viewport in iframes are always the same, and we already scale to 100% height by default anyway Signed-off-by: Skyler <skyler.grey@collabora.com> Change-Id: I07726bee8b61334f6a32e873ab2d5428fa60dca3
* writer: fix annotation size regressionAttila Szűcs40 hours1-49/+55
| | | | | | | | | | Hidden contentNodes (in annotation) may become visible during resize. Looks like setting style.max-height also change style.display. Now i set it only if style.display is not none. Signed-off-by: Attila Szűcs <attila.szucs@collabora.com> Change-Id: I30f2eb75cb3ccb5b43044cef856314b0e35b9300
* writer: resize comments based on spaceAttila Szűcs40 hours2-0/+83
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make comments window bigger, if needed, and possible. Selected commits grow up to MAX size, even if there is no space for it. There is 2 constant limitation: MAX - --annotation-max-size this is the maximum size commentText window can grow. If the comment have more text, than it will have scrollbar. MIN - --annotation-min-size if there is not enought space, but comment have more text, this is the minimum size of commentText window. note: commentText window can be smaller then MIN, if it has less text. During doLayout: first, in resetCommentsSize comments size resets to default. (max-height = MIN size.) after comments positioned with loopUp / loopDown, resizeComments check all comments (maybe it could be optimized) If a comment have more text as its actual size, then it check the space between this, and next comment.. and resize this comment. If there is not enought space after the comment, then it check for more space between this, and previous comment, and resize + move up the comment as much as needed. Signed-off-by: Attila Szűcs <attila.szucs@collabora.com> Change-Id: Ie7b0971febd8c965b01ebe23125eac4eded1a742 Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
* browser: preview: change place hoder to svgHenry Castro43 hours3-1/+13
| | | | | | | spinner pre-loading previews Change-Id: Ib6316d58da60fb537e238f93981f0cc8294f6885 Signed-off-by: Henry Castro <hcastro@collabora.com>
* browser: preview: simplify "layoutPreview"Henry Castro43 hours1-14/+14
| | | | | Change-Id: Ia7b478cd14901e877dece81b57f418e8bdf1668b Signed-off-by: Henry Castro <hcastro@collabora.com>
* browser: preview: remove more unused codeHenry Castro43 hours1-5/+0
| | | | | Change-Id: I6431ee0093c006d142c2c0d3561a36ec31ba94f0 Signed-off-by: Henry Castro <hcastro@collabora.com>
* Prevent opening multiple tooltip on drawing area widgetsGülşah Köse44 hours1-1/+5
| | | | | | | | | | | | | | | | We see multiple tooltip problem on drawing area widgets. Example case: Add basic shape into a writer document Right click on shape and open Position and Size dialog Select the Rotation tab Hold the rotation angle widget and drag around itself When you inspect the "Rotation Angle" tooltip, count may be 600 We expect only 1. So we prevent to show another tooltip if we have already one. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I2f548f8c7afce8095e83a6faa3722e164f990210
* Add HTMLObjectSection for using for icons.Gökay Şatır45 hours6-45/+136
| | | | | | | Replace dropdownmarker with an instance of HTMLObjectSection, which doesn't use lat/lng. Signed-off-by: Gökay Şatır <gokaysatir@collabora.com> Change-Id: I152ed3ea4120c0682d057b2beedd4e5d8910da17
* logging: remove now unused StreamLogger.Michael Meeks2 days1-89/+0
| | | | | Change-Id: Ic8a28dcc97aa0b17d2cb8efa99c42f7791486a15 Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
* Logging: wrap poco and simplify logging.Michael Meeks2 days14-201/+253
| | | | | | | | | | | | | | | Centralize more logging functionality in Log.cpp, simplify and wrap underlying logging APIs better. Code is much more generic, and hides implementation details much more thoroughly, while keeping the same API / wrappers. To do this we have to sub-class Poco::Logger to get access to its generic 'log' method instead of a mess of in-line wrappers, this lets us avoid lots of code. Change-Id: I541d3aef49f99ce582655c5102a0041bf84cd56a Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
* wsd: simplify LOG_MESSAGE to the logging frameworkHenry Castro2 days1-96/+23
| | | | | Change-Id: I997855e586783451a556cefe2860f9384585045a Signed-off-by: Henry Castro <hcastro@collabora.com>
* wsd: remove "PRIO" parameter to the logging frameworkHenry Castro2 days1-19/+31
| | | | | | | remove POCO dependency enumerator value. Change-Id: I2abccd591374db96be81932d25b59fb0b10bac69 Signed-off-by: Henry Castro <hcastro@collabora.com>
* wsd: add 'name' parameter to the logging frameworkHenry Castro2 days1-5/+5
| | | | | Change-Id: Ic8cc82e06200d2c2c8f47e27fd5e3225ca7f6202 Signed-off-by: Henry Castro <hcastro@collabora.com>
* remove-w2ui: remove cssSzymon Kłos2 days2-3260/+0
| | | | | | | it is not used anymore: see commits with remove-w2ui prefix Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Ifc0034dcb28455204e490d0d21e97af22d3c8ae8
* remove-w2ui: replace w2ui-scroll-wrapperSzymon Kłos2 days21-59/+95
| | | | | | | | | And add self made ui-scroll-reight/left items with primary color tiangle. We should replace it at some point with something more pretty. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I67530c6352b8356214399f324b55bbf9bc24f876
* bgsave: set state to unmodified on successful background save.Michael Meeks2 days2-2/+29
| | | | | | | | | There is a race here, clearly if you type while a background save is ongoing - but this is far better than leaving the document apparently unmodified. Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Change-Id: Ie5e3e692294e48ad887481af2e0906092830f265
* bgsave: improve auto-save tests.Michael Meeks2 days1-84/+70
| | | | | Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Change-Id: Ie08a68f79734e84218c9553ad3738f7b658cdc08
* Improve DocumentBroker state dumping.Michael Meeks2 days1-0/+4
| | | | | Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Change-Id: I091c67d8b72bcaa3d82cd4de7be9d5ceb8d9720d
* cool#8648 clipboard: stop fetching the clipboard on text selection create in ↵Miklos Vajna3 days2-5/+4
| | | | | | | | | | tests This was just a workaround to keep tests working till they are fixed to not assume we do an implicit 'copy' as soon as we have a text selection. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I37d16ee2841c41593a5af2fb6ceba025fe1c79e0
* cid#360695 Dereference after null checkCaolán McNamara3 days1-1/+1
| | | | | | | << precedence is higher than ? Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ie7a77ba949195b91df3b87059c0c458c57b2be94
* cid#318937 Array compared against 0Caolán McNamara3 days1-1/+1
| | | | | | | | this returns the same type as its 3rd arg, so using "false" returns a const char* and not a bool Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Ibd46ecea82ef4587e1a2083430981976457ab874
* Allow to embed the presentation in windowSzymon Kłos3 days1-0/+9
| | | | | | | | | | | | | | | Similar like in: commit d9d13d7092d2d597eb34d657945f2678756fb800 wasm: support serving wasm files add headers required when we use WASM so we are able to embed presentation in window. Without that we get: not-set Cross-Origin-Embedder-Policy Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I03ca3717488a92fe405693764f3f18a964b23bf7
* Browser: Duplicate Repair option in Impress tabbed barAron Budea3 days1-33/+2
| | | | | | | | | ...and remove duplicate code. Regression from c9ef8c3015d505208ddba6be7f2b665c6c32ef9e Signed-off-by: Aron Budea <aron.budea@collabora.com> Change-Id: Ib992d2c169d3e40f9cab670935696ab2899c639c
* docker: CODE 24.04Andras Timar3 days1-3/+3
| | | | | Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I7f1d5bec60a342d1b3d0dee1534506a13f12a67b
* mobile: Use SavedUIState=trueSkyler Grey3 days1-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | SavedUIState is a ui_defaults option to ignore any user preferences for state when loading, it was added in https://github.com/CollaboraOnline/online/pull/7575 We need to set SavedUIState explicitly on mobile, which the following pulls do for iOS and Android respectively: - https://github.com/CollaboraOnline/online/pull/7908 - https://github.com/CollaboraOnline/online/pull/7912 Unfortunately, setting it to false can cause some nasty bugs, such as inability to change theme to light. It also intentionally ignores user preferences when you reopen a document, but this isn't particularly desirable on mobile. I believe it to be an oversight that the option was set to `false` rather than `true`, as `true` was the behavior before the ui_default option was added and neither change gives a reason for it to be false rather than true. Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Change-Id: I30ce445db1b7e69a3b44eec3fb4689c463233b1f
* cid#360697 Ignoring number of bytes readCaolán McNamara3 days1-1/+1
| | | | | Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I24c1bf9f103f3bf1325246a0223919ff1dbf62b4
* includes should be in AC_LANG_PROGRAM preambleCaolán McNamara3 days1-1/+1
| | | | | | | no the body Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I9377142c676efc3f0d658efa01e06a91f3f0924d
* Remove extra grid cell space from header in autofilter child popupDarshan-upadhyay11103 days1-0/+2
| | | | | | | - we need to also consider `th` tag to make it display none - it's a empty text span so do not that extra space. Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: Ib83d42f64a0115fdc4d17a8f7e952419a84cc9d5
* cool#8648 clipboard: fix mobile/writer/table_properties_spec.jsMiklos Vajna3 days1-0/+16
| | | | | | | | To work even if we don't automatically fetch HTML when a text selection is created. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: I359fa602523052940879ce749624ee63086554c1
* cool#8648 clipboard: fix mobile/writer/track_changes_spec.jsMiklos Vajna3 days1-0/+2
| | | | | | | | To work even if we don't automatically fetch HTML when a text selection is created. Signed-off-by: Miklos Vajna <vmiklos@collabora.com> Change-Id: If9371a3d235a0ee6c006be72dabe40242fa46b2b
* Removed NBSP while coping info to clipboardParth Raiyani4 days1-0/+1
| | | | | Signed-off-by: Parth Raiyani <pmr642001@gmail.com> Change-Id: I2566a4902ed36e53ad2acfbe1c32efccb04bddda
* annotation: refectored reply node count codePranam Lashkari4 days6-32/+30
| | | | | | | | now reply count node multipurpose, it also indicates if a comment which was being edited is collapsed Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I18a676885deea0afa30eb20505a76239e11c5493
* cypress: added test for collapsed autosaved comment indicationPranam Lashkari4 days4-8/+62
| | | | | Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I4e6929a074e750041a1814629317baf0433eaab0
* annotation: indicate if comments are in edited state while collapsedPranam Lashkari4 days2-24/+44
| | | | | | | | | | | problem: when in small window, comment was autosaved, it wasn't collapsed but would hang on the edge of the screen half visible. We can't collapse the comment directly as user will not be able to find again which comment was being edited. Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I9393e7f2b53d8ea37273cc2290cc74636c514cb5
* Remove unused functions and notes, improve a comment.Gökay Şatır4 days1-22/+1
| | | | | Signed-off-by: Gökay Şatır <gokaysatir@gmail.com> Change-Id: Ic62f276983614bfbc56b50e3b0f37b1ea82c4d1a
generated by cgit (git 2.34.1) at 2024-04-26 10:59:58 +0000