diff options
author | Skyler Grey <skyler.grey@collabora.com> | 2024-04-22 15:50:28 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@gmail.com> | 2024-04-23 08:20:35 +0100 |
commit | f21031c9986973d942512283f19e2fd039540eef (patch) | |
tree | b54ff37e4fb606d94510c52bd43d2745a8c73f85 | |
parent | cid#360697 Ignoring number of bytes read (diff) | |
download | online-f21031c9986973d942512283f19e2fd039540eef.tar.gz online-f21031c9986973d942512283f19e2fd039540eef.zip |
mobile: Use SavedUIState=true
SavedUIState is a ui_defaults option to ignore any user preferences for
state when loading, it was added in
https://github.com/CollaboraOnline/online/pull/7575
We need to set SavedUIState explicitly on mobile, which the following
pulls do for iOS and Android respectively:
- https://github.com/CollaboraOnline/online/pull/7908
- https://github.com/CollaboraOnline/online/pull/7912
Unfortunately, setting it to false can cause some nasty bugs, such as
inability to change theme to light. It also intentionally ignores user
preferences when you reopen a document, but this isn't particularly
desirable on mobile.
I believe it to be an oversight that the option was set to `false`
rather than `true`, as `true` was the behavior before the ui_default
option was added and neither change gives a reason for it to be false
rather than true.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I30ce445db1b7e69a3b44eec3fb4689c463233b1f
-rw-r--r-- | browser/html/cool.html.m4 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/browser/html/cool.html.m4 b/browser/html/cool.html.m4 index 37efe96e11..944d7450c2 100644 --- a/browser/html/cool.html.m4 +++ b/browser/html/cool.html.m4 @@ -314,7 +314,7 @@ m4_ifelse(MOBILEAPP,[true], window.checkFileInfoOverride = {}; window.deeplEnabled = false; window.zoteroEnabled = false; - window.savedUIState = false; + window.savedUIState = true; window.wasmEnabled = false; window.indirectionUrl='';], [window.host = '%HOST%'; |