diff options
| author | Pranam Lashkari <lpranam@collabora.com> | 2019-12-23 19:15:38 +0530 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2020-01-22 23:23:51 +0100 |
| commit | a019c93d90e08aceb8b645e6cf963e6256fb38c6 (patch) | |
| tree | e7ad2b35b2c5d7320fd5cfc34c3d51c114e2353f /common/Authorization.cpp | |
| parent | cypress: Use a bigger timeout for document load. (diff) | |
| download | online-a019c93d90e08aceb8b645e6cf963e6256fb38c6.tar.gz online-a019c93d90e08aceb8b645e6cf963e6256fb38c6.zip | |
Resolved: Server crash when link opened in new tab
When trying to open a link normally from help->Online help
nothing happens but the popup is closed.
When trying to open a like forcefully in new tab
from help->online help it crashes the server.
Change-Id: I7e0944ebe521002625a84e155e379ed7e25d2309
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/85466
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Diffstat (limited to 'common/Authorization.cpp')
| -rw-r--r-- | common/Authorization.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/common/Authorization.cpp b/common/Authorization.cpp index dce34abb09..138f98889b 100644 --- a/common/Authorization.cpp +++ b/common/Authorization.cpp @@ -11,6 +11,8 @@ #include "Authorization.hpp" #include "Protocol.hpp" +#include "Log.hpp" +#include <Exceptions.hpp> #include <cstdlib> #include <cassert> @@ -77,7 +79,9 @@ void Authorization::authorizeRequest(Poco::Net::HTTPRequest& request) const break; } default: - assert(false); + // assert(false); + throw BadRequestException("Invalid HTTP request type"); + break; } } |