summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2020-03-20 13:19:57 +0100
committerStephan Bergmann <sbergman@redhat.com>2020-03-20 17:18:43 +0100
commit1be7a056ff843e8e9cb80890ecf7d3aa852557e9 (patch)
treeab2a79edf8d4a9b70e17baceccddedfaf6848573
parentsw pad-to-4 numbering: add doc model, UNO API and layout (diff)
downloadcore-1be7a056ff843e8e9cb80890ecf7d3aa852557e9.tar.gz
core-1be7a056ff843e8e9cb80890ecf7d3aa852557e9.zip
Dispose dialog created during test
I experienced crashes during shutdown of CppunitTest_toolkit at least with --enable-lto, [...] > OK (2) > warn:vcl:109889:109889:vcl/source/app/svmain.cxx:460: DeInitVCL: some top Windows are still alive > text = "" type = "N7toolkit16ScrollableDialogE", ptr = 0x216b740 > > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:1065: Desktop disposed before terminating it > warn:fwk.desktop:109889:109889:framework/source/services/desktop.cxx:179: Desktop not terminated before being destructed > warn:unotools.config:109889:109889:unotools/source/config/configmgr.cxx:140: ConfigManager not empty > cppunittester: /home/sbergman/lo2/core/include/vcl/vclptr.hxx:106: VclPtr<reference_type>::~VclPtr() [with reference_type = vcl::Window]: Assertion `m_rInnerRef.get() == nullptr || vclmain::isAlive()' failed. Change-Id: I419b7ef8e23c94a906e3de6b3a55b63e13650abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90790 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
-rw-r--r--toolkit/qa/cppunit/Dialog.cxx1
1 files changed, 1 insertions, 0 deletions
diff --git a/toolkit/qa/cppunit/Dialog.cxx b/toolkit/qa/cppunit/Dialog.cxx
index c58b9b4768ca..5f02c58bee61 100644
--- a/toolkit/qa/cppunit/Dialog.cxx
+++ b/toolkit/qa/cppunit/Dialog.cxx
@@ -65,6 +65,7 @@ CPPUNIT_TEST_FIXTURE(DialogTest, testDialogSizeable)
CPPUNIT_ASSERT(pWindow->GetStyle() & WB_SIZEABLE);
xDialog->endExecute();
+ css::uno::Reference<css::lang::XComponent>(xDialog, css::uno::UNO_QUERY_THROW)->dispose();
}
}