| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding attribute by jQuery and testing in cypress was
not working: visible value was correct after change but
in DOM we had original value which was tested by Cypress.
Use val() to setup value and have.value for cypress to test.
Unify inputs so we don't use attributes but always props.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1b3acccbd6d4ba493f867044b9b3c1f17b16873e
|
|
|
|
|
|
|
| |
- it is needed for mobile wizard spin fields
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7464d7017e54425d3ffd022a45c39af51e05e21f
|
|
|
|
|
|
|
|
|
|
| |
fixed:
- image overlapping with high res image
- shows empty bullet when highlight text is empty
- no space between bullet points and text
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0e3bcd11d9132913d69f8a7c74d21cc0b4ab3305
|
|
|
|
|
|
|
|
|
|
| |
Signed-off-by: ChrisGlad <chris.gladman2004@gmail.com>
This code fixes the problem that elements in the Notebookbar will
not be correctly displayed as "selected" after changing the UI
mode.
Change-Id: I4f889f8593029c375a06e17dbf1062bb9b9f5efc
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the row height spinner is the 1st element in the row,
there is no need for margin.
Note: in the future wuld be good to have the spinner coming from the
builder with additional class or style when they are the first
element being positioned
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I2396ab662fcb4a12762b4a6e2b38582f1df7c59b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary rules targetting minimalrowheight and
minimalcolumnwidth. These rules were
1. Not being apply always (sometimes jsbuilder was
setting them with different id, e.g.: with suffix 1)
2. Even when apply this rules were forcing these two btns
to go up, looking like they are mere icon for the spinner.
This is wrong. They are buttons that trigger the set to the
minimal sizes of that particular row or columns
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I53e81c69cdcc3aafd2ca5ab0f8e196d912b86608
|
|
|
|
|
|
|
|
| |
Before this change the spinner were getting unnecessary additional
padding.
Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I43b8bffc8bacc13dfc633cee4cd8f7823834d402
|
|
|
|
|
|
|
|
| |
Fix misalignment for When no integrator is available or
when there is no particular integration bits around avatar list.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia80d27e79b91dd1e4e7ff3ee8129f8e6d6168285
|
|
|
|
|
|
|
|
|
|
| |
Instead of trying to re-position #userListPopover for every case
(compact view, tabbed view and rtl), use flex to align the elements
- This also fixes the positioning discrepancy of both the popover
but also the arrow (triangle)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I32ed3e05efc51001db106f5baaf18012e87965fe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Follow the same order, for generic menu entries:
- Toggle UI Mode; Show Ruler; Show Status Bar; Sidebar
- Make sure Reset Zoom and all UI toggles are present in all apps
(doc type) when using tablet
Note:
This commit does not change the following because I do agree with
remarks stated in 70f4f8b92e44d361c78dd323e147d23abba8b308
- Zoom in and Zoom out entries are not needed in tablet
- Zoom also misbehaves, so better to have it out when on a tablet
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I06f1c025dba27ae65229c38406d646da75a59aa6
|
|
|
|
|
|
|
|
| |
No need to have one item (Resolved Annotations toggle) surrounded by
separators.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie5e560122054fc5904e3b24f984aa682c758d373
|
|
|
|
|
|
|
|
|
|
|
| |
Building upon 70f4f8b92e44d361c78dd323e147d23abba8b308
, it makes sense but let's add back in the Reset zoom
and let's make sure all the other UI toggles are available
when using tablet ( otherwise user is not able to
toggle UI mode, ruler or status bar).
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I972a3f6f17306484a266dc3cfa2103540ca4761d
|
|
|
|
|
|
|
|
|
|
| |
Fix #4808 by add SlideMasterPage to impress view tab
and add a context related MasterPage tab.
Update the icons to use the master*.svg colibre icons from core
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ibbd24d1c20a48e26591d217311c5989794aa841e
|
|
|
|
|
|
|
|
|
| |
unclutter formula bar surrouding elements by removing the visual
break and instead add padding. This is a partly cherry-pick
from 8f0f1c700
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4a9990a5709918d7cacfac2ef41b91281f9af54a
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
redline comments dont have position properties set
and some calculation needed in order to have it
and scrolling to comment relies on position property.
We have now instead getter for it and if it is a redline
comment it is calculated otherwise the default one is returned
because it is already set.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I6a3cefdd1c881783832de3de8fc1df7c849aad09
|
|
|
|
|
|
|
|
|
|
|
| |
Requested by several users and partners - defaults to off/un-changed.
When set it allows optional disabling of welcome/feedback when used
in a homely environment.
Also bump default max doc/conneciton limits in configure to 10k.
Change-Id: I3c917901e02445d45f6f86b554d47a60aa4e575d
Signed-off-by: Henry Castro <hcastro@collabora.com>
|
|
|
|
|
| |
Change-Id: I22a90c0dd8e80870699aef12b800c85508b17920
Signed-off-by: Henry Castro <hcastro@collabora.com>
|
|
|
|
|
|
|
|
| |
Adjust the drop-down dialog to the #map element
to show the correct position sent by the server.
Change-Id: I74a6d7402438241aae77a18699c3297d64b34098
Signed-off-by: Henry Castro <hcastro@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug
- pushbuttons with images get misaligned. Namely the inner image that
it's position well. Visible in some places within the sidebar
impress, calc:
https://archive.org/download/bug-pushbutton-with-img-alignments/bug-pushbutton-with-img-alignments.png
Fix
- Pushbuttons with images are now classified with .has-img and inherit
the respective global flexbox CSS classes.
- Add global flex box CSS classes so we can avoid code duplication
- Also make sure other pushbuttons with image don't butchered with this
change (e.g. calc > pivot table dialog)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie37680eb02c15417c505402074bbe01d302910cb
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 08b1d4b1e78fc2560d554b5935452ebb2d025214.
Better to avoid backporting WIP dark mode at least until
issue number #5054 is fixed
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id4fe8582fdebe9ad078ef5eaa7ba6be655cfb941
|
|
|
|
|
|
|
|
|
| |
- allow to use auto scrolling feature by event propagation
- it required to create new modified event which will
contain coordinates of the autofill marker
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic7fe236833f5e1747d0d72e9560d3c9ecdccde51
|
|
|
|
|
|
|
|
|
|
| |
- adds two new options
1. localize the dialog
2. change upsell image shown in dialog using proxy handler
- provides all the settings using dynamic configuration
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7e21c1b31c806c88bf54f891de40f02fa342168f
|
|
|
|
|
| |
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I12a236ad6ee112e620c100b8bbf0663cd2e3c4b6
|
|
|
|
|
| |
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I66e2fd6d4331361e36bc31135a45e62149f2c0f9
|
|
|
|
|
|
|
|
| |
Use the same padding as the user names and thus fixing the
alignment (vertical: checkbox vs avatars)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1acb8cf5e3e5dc8aad083151c9c54b38aa552d6c
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until now user was reporting not fully understanding all the
features that user userListPopover offers. Namely, not knowing
that not only is possible to follow the editor (checkbox) but
that it is also possible to follow a specific user from the list
Make it easier to understand what's the current following status
by adding "Following" under the selected user name in the list
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0beba5df06f2cc7a9a349ef8f93db6b403befb9b
|
|
|
|
|
|
|
|
|
|
|
| |
Get rid of the popover once the user completes the action
Probably better to avoid having hanging popover (that have no
close btn) and instead close them, specially because this
one can always be re-opened at anytime from omnipresent
toolbar and without risk of triggering any additional change
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id7946512e6c54622e3ed20b28d56178c05b18b5c
|
|
|
|
|
|
|
|
| |
Make sure the avatar list popover automatically gets out of the
way once the user selects an entry (follow user)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie83a587e4f9900ffb0d70cadbfb13cfe81d8b849
|
|
|
|
|
| |
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a5b215316a988ad0649982415c2d8ce6fab1212
|
|
|
|
|
|
|
|
| |
Before the triangle was getting a different bg when compared
to #userListPopover
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If110d9e1178bedb7e858804e169689ee97a5a385
|
|
|
|
|
|
|
|
| |
When we use API call InsertButton and we add custom buttons
we want to keep them when we switch between compact/tabbed view.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If03520f52422ac41aa40432f068e5bc011ed2596
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In cases when the button text is too long
or when using CO in, for example, DE language and when
the length of the parent dialog was not enough the btns
would not stack up, instead that would overlap. This would
make reading those btns impossible.
![vex-btns-overlap](https://archive.org/download/csv-overlap-btn-labels/CSV-overlap-btn-labels.png)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I801ea330db21add35d0a81466a1fba9501a61899
|
|
|
|
|
|
|
|
|
|
| |
This helps us to be in sync with core especially with
problematic dropdowns like:
Sidebar in shape context -> Line Panel -> Line Width
This will close and not reopen the popup when we click outside.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4daf90f2611f6caa922022e1cc6e248f6a62d02f
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep in sync colors in sidebar and notebookbar when
we change one of them.
Followup for
commit 13ef21aa1ecff764ed7c5b24bee83e25297ca21e
notebookbar: unify color control with core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia8af727c6ba6b5b32a644ff070954c9ada584a24
|
|
|
|
|
|
|
|
|
| |
in desktop case color widget should show the latest selected
color not current one. split the button into arrow with dropdown
and "last color" button (icon)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07fcc94d69e14b030cf9f1bfe3ae50f0df333ec7
|
|
|
|
|
|
|
|
|
| |
When spreadsheet was opened after few seconds we received CellCursor
message.
If comment was opened end edited at that time - it dissapeared
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I15804bfa0bf9ccac03c2858184db327a978061b3
|
|
|
|
|
|
|
|
|
| |
not work in NB
fix: after switching to Notebookbar view and back again to Classic View; the Save icon reappears.
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8fda18a9148c679209f0de99b80526393a965720
|
|
|
|
|
| |
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6b2fc565f33169eca575f59a8a4b2ce398588113
|
|
|
|
|
|
|
|
|
| |
Just after we opened spreadsheet and opened font list - it was
closed after some seconds due to focus change caused by
.uno:CellCursor update.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifabde00163567ab7d4f3f8359d58b4251fff5ec3
|
|
|
|
|
|
|
|
| |
Don't generate spam in the console log with warnings about not
activated notebookbar in apps where we don't use any welded widgets.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48c2d843752058923242d6678f08ec0791d08e4c
|
|
|
|
|
|
|
|
| |
We automatically send notebookbar activation command in some cases.
Allow this command when dialog is opened and don't blink.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iac068cfca49ce6dbfe241bde752a475560d3445e
|
|
|
|
|
|
|
|
|
|
| |
Don't add multiple overlays with the same id.
Remove overlay always when it exists and we close.
Close dropdown entires by dropdown click - specific to 21.11
where popups in the core are handled differently.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia1652434f38571defb817bfb29491ed0bd246e73
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For toolitems with dropdowns we should toggle the button.
Use correct parent so we don't use button from other component.
Later we send toggle event to properly close the popup on the server.
example: Calc sidebar, Underline popup
Before this patch when we clicked in outside the popup it dissapeared
but app was completly blocked.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I124a41361df305931c66047a8799ce03393b67de
|
|
|
|
|
|
|
|
|
|
| |
when other view moved cursor outside out view - all of
them were hidden because we used selector for all the
elements matching cursor class - instead of current
instance
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If97606f33e44ce59f747ad0b015048deacbe8657
|
|
|
|
|
|
|
| |
add combobox to list of non-containers and cleanup
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I657038c960d7c606a0e437b0c24e74e83f2c2b00
|
|
|
|
|
| |
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I36191d622c70d296f50db8ba4913a2e47dd36f94
|
|
|
|
|
|
|
|
|
| |
Compact View is separate in the menubar from Sidebar and Statusbar
So it shouldn't be between them in the View Tab.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ib46e9c4a4df24432eae5a7fef335e7cde68b1766
Signed-off-by: andreas kainz <kainz.a@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the insert tab there is the command uno:BasicShapes
by select BasicShapes the user can insert shapes
at least Basic Shapes, Symbol Shapes, Block Arrows,
Stars and Banners, Callouts, Flowchart, ...
So uno:BasicShapes will let you insert all available type of shapes
therefore the text label should be Shapes instead of Basic Shapes.
fix #4672
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I692b7a5b03b905599648c7af4a016684b12b335a
|
|
|
|
|
|
|
|
|
| |
This reverts commit dd83984896d62f8c0441b2058cffa5e9d6e7ce0c.
The logo style already exists and to avoid override rule.
Change-Id: Idf59f1acbc427ea8a33147398057de1883731830
Signed-off-by: Henry Castro <hcastro@collabora.com>
|
|
|
|
|
|
|
| |
So we can type after we closed popup in the sidebar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib4164cfa0b7b25b0a3aeeccdd9d0ac8c9bf7f280
|