| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This would have only a small impact on memory use, and a large
impact on interactivity, performance and bandwidth use. So lets
not do that.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I07b2538cd4f5cd2c91926cfabeaa159dd992b068
|
|
|
|
|
| |
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I5716d9d6556f45185b7b78fa05277403855d0353
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in some browser scrollIntoView causes problem without parameters
in this particular case problem was entire view being pushed upwords out of view
reproducing steps:
Open a spreadsheet in two views,
With 1st view, navigate to bottom right corner via Ctrl+⬇ and Ctrl+➡,
With 1st view, type something in that cell, and then the cell above (stay editing the cell, don't press Enter),
With 2nd view, start typing in A1.
2nd view's editing view is pushed upwards
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4bc551de321483608eb210718c1d81a622de5a6d
|
|
|
|
|
| |
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I76cf16e12968e26a73dbddd39fc919b400cecff2
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6d2f038390da081ef98b5aaac7bedc10c77a964e
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I83cb6aa999e75338d70c8d11e13266269c460903
|
|
|
|
|
|
|
|
| |
Signed-off-by: Klaus Erber <k.erber@erber-freelance.de>
Signed-off-by: Martin Müller <martin.mueller@dataport.de>
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I4dc4a456e3f61555468b98f1d0dfd54c1dd28770
|
|
|
|
|
|
|
|
|
|
| |
This fixes the problem when we requested a preview but
core didn't answer. This can happen when we have
nviewid mismatch and error is generated in logs:
ERR Session is not found. Maybe exited after rendering request.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I951a05432c899a8e7d210dec7d57177d6c7aae7c
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In calc and impress we send different data depending on the view
in status: message which is triggered by LOK_CALLBACK_DOCUMENT_SIZE_CHANGED.
Every view can be on a different part / sheet / slide where document
size can be also independent.
This helps to reduce status: messages sent to other view when
switching sheets in other view.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5b287f377a551affcfb4d12b6114dffa0fd51992
|
|
|
|
|
|
|
|
|
| |
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
|
|
|
|
|
|
|
| |
regresssion from 3c55baf4e2e36c6df43707a7e469dae3fec2c3b0
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I21831ba076140d49a54a56e9c52f7edfca923ef5
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While scrolling using scrollbar we tried to prefetch
lots of tiles adjacent to the view.
Introduce timer which will protect us from prefetching
tiles we will not need when scrolling is fast.
We will avoid doing it synchronously on every little step.
_update is called a lot in onMouseMove handler:
_update (CanvasTileLayer.js:6220)
...
panBy (Map.PanAnimation.js:51)
scroll (Scroll.js:11)
ScrollSection.scrollVerticalWithOffset (ScrollSection.ts:657)
ScrollSection.onMouseMove (ScrollSection.ts:776)
CanvasSectionContainer.propagateOnMouseMove (CanvasSectionContainer.ts:1097)
CanvasSectionContainer.onMouseMove (CanvasSectionContainer.ts:1403)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If785fd0c0cc9076043e348b86a09577ad9fa667d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When all users idle their activities
for at least 10 seconds, we take the
opportunity to trim the memory footprint.
We are careful not to issue a subsequent
trimming too soon. A minimum of 30 seconds
needs to pass to trim again. This should
give a decent balance between performance
and reduced memory footprint.
Change-Id: I1c8b2c4a265c9aa0ac5033762695706ad970f11e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this.accessibilityInputElement.focus();
line in onDocumentKeyUp in browser/src/dom/NotebookbarAccessibility.js
caused view to jump, in result half of the screen was white when
document was very long and had comment inside
To fix this insert accessibility input at the beginning of the DOM
so browser will not try to scroll anything when it is focused.
this is regression introduced in:
commit 3e40f3fbe4a853f36fa540120a21acafeb234b08
Add functionality for notebookbar accessibility keys.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I68a1371928a5a3c02be32a3a9eab2ba909bb8ba0
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Large Clipboard and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
- Transfer all that (just once) to showinfomodal instead for the
cases where we have buttons
- This in turn sets the things to the parent (dialog itself)
and not the subcontianer
- Set tabIndex with negative value so, it only allows focus via
code
- This fixes the weird outline (focus) that sometimes would appear
on sub containers of that dialog instances
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia51b23e9636ffa381aa1041f13487f4d9b632655
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ia6810cebfe99c120f8dfff956b67edc1add35178
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I4dd6434cb6a1a9d121bccce7f4d80b040cf747c0
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Ic7308336c7ea635236514d0eeda89e876b1503ab
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: Id98830212e16e3ffc1a07b902d7d371f592623f3
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I8b6401624d23660f3b7fc6f244ce633bd0529c6a
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I07127c2032cc5c684f037dbc058a9581be762488
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6f9a098fbbb11522029709c73bf912b884ee3f26
|
|
|
|
|
|
|
| |
ha-allocation)
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I6af734feb5cfc3dd8688a45a94e2fca012fcd312
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I9771caf619e7fd59c98a8029e08cb3a5c88db4b5
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I1895aff3a622d126e69b3a16ebfa130e1ce96996
|
|
|
|
|
| |
Signed-off-by: genofire <geno+dev@fireorbit.de>
Change-Id: I99c9c8b3aecc006b399defce5a605221358e04aa
|
|
|
|
|
| |
Change-Id: d9569af164b649863ec05d7b61a362c1ee876f4d
Signed-off-by: genofire <geno+dev@fireorbit.de>
|
|
|
|
|
|
|
|
|
| |
when any dialog is shown we block executing uno commands
don't count snackbar as a dialog and allow full interaction
of the user when snackbar is shown
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idb1ec1aff9532ba2f1789157982cb25843df0c31
|
|
|
|
|
| |
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Idc0800eaa4ab751601bd34bba6c2e9cfef38de4d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With c04c065edcfe9e00e4f7e50834e6317caaceb9ea we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
- Make sure that when we are in presence of calc we set the
canvas color (clearColor) with the value coming from
documentBackgroundColor
- To make it clear: create a new CSS variable to be used as
background-document
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
|
|
|
|
|
|
|
|
| |
Should help for single user with large screens.
Also dump delta cache sizes on USR1.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Id16a287be6b05cee5681abe1d9d2dc0ec61cda2a
|
|
|
|
|
|
|
|
| |
Otherwise when we get under pressure re: canvas' we loose useful
statistics around the number of deltas applied.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I44a089e4af2819007b8f400b506292f8d469ff82
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we need to re-constitute a canvas from the cached compressed
tile.rawDeltas, we could re-enter via var ctx = this._ensureContext(tile);
as we had to populate the canvas with the previous content before
applying our new delta.
Its important to ensure that we don't then try to apply the same
delta (or set of deltas) twice - ie. move the context/re-constitution
before we append the new deltas to the tile.rawDeltas.
Previously showing the same delta applied twice:
Applying a raw keyframe of length 7320
Applied keyframe 0 of total size 264270 at stream offset 0 size 262144
Applied chunk 1 of total size 2126 at stream offset 262144 size 53
Applied chunk 2 of total size 2073 at stream offset 262197 size 2073
Applied chunk 0 of total size 2073 at stream offset 0 size 2073
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ib23bb81e6d3534f140ff3472afed1010c6f98cc2
|
|
|
|
|
|
|
|
| |
We have no obviously good mechanism for re-fetching them, and
this seems a bit extreme - even if they are otherwise old.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ibaa3d5185493de45efb2887d94b0bf1ee7cac245
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the obscure case: we could have garbage collected the keyframe
content in JS but coolwsd still thinks we have it and now we just
have a delta with nothing to apply it to.
+ show a count in tile debug-mode of this case.
+ re-request a full tile ie. with oldwid=0 if we hit this case.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ide95c54086fcc48d0deed1a090b3b9dd4aa49cd5
|
|
|
|
|
|
|
|
| |
+ don't keep a canvas around if we free its rawDeltas.
+ don't keep imgDataCache around if we freed the canvas.
Change-Id: If3e5be642c9e7560bb889881fa62f25031104658
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
|
|
|
|
|
| |
gdb seems to really struggle with versioned symbols & types in glibc.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ic59020c2e5c88fbeb7799d3f5c06752097a5ad40
|
|
|
|
|
|
|
|
| |
This should catch the case where one view should get an empty
update delta, and the other should get a new keyframe tile.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I3ad8f564cc45d80186430b463214ffcf092346f3
|
|
|
|
|
|
|
|
|
|
|
| |
problem:
regression from 919db16
when address input has focus and keyboard is open,
tapping on sheet would not close keyboard and bring focus back to map
only way to close keyboard and focus map was to accept the input
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I2c6f23be9efcbbe8e4d47d11505074a75abc000f
|
|
|
|
|
| |
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I7f254328ba1be8074d8f1feabd7b89304166281d
|
|
|
|
|
| |
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Idcb708d2686c6a1f40a1a832bf8c0940f9890c1c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also: address parts of #6897, primarily:
* remove the problematic aspect of bumping the last wid in our
TileData, when this could trigger a re-send of a previously
sent delta, causing tile corruption.
* instead append an empty wid entry.
* as an optimization - if the last entry is empty update
the wid - since re-sending an empty delta is of no
concern.
* simplify a number of code-paths that special-case zero length
deltas. All deltas now commence with 'D'.
* still track updates in the JS - by detecting empty deltas.
* shares more code and simplifies various paths.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I02af6d4b152524c201b6985b7a3497da7f08a517
|
|
|
|
|
| |
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8ae12c8c8390997bbde7af1e203e9075dfa4ea25
|
|
|
|
|
|
|
|
|
|
| |
However, don't force rendering a keyframe, only sending it - other
clients may be happy with deltas. This is to better handle:
window.app.console.debug('Unusual: Delta sent - but we have no keyframe for ' + key);
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4efff0f6b1d2817e6b8bd567eb3b098383a1ef42
|
|
|
|
|
|
|
| |
It's fine to be a keyframe and have appended deltas too.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I205e44e0b019b3eec0ce266e9a544b060d0bce4d
|
|
|
|
|
|
| |
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I8c10857b0ca7e166b5f9364db9ea2a01e5acfffa
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
|
|
|
|
|
| |
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Iee02515870d48adc2dcdd2f44ff76fb4c2cf05e7
|
|
|
|
|
| |
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I50654f4fc82330e50069761a87e50ada23740ec7
|
|
|
|
|
| |
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I966f44bb79ba0252ca662146f1680984a140bc1c
|