summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Avoid a TypeError.libreoffice-6-3Jan Holesovsky2020-03-031-1/+1
| | | | | | | | | | | | | | | | I've been getting this on Android, but suspect it can be a general problem: loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165 Uncaught TypeError: Right-hand side of 'instanceof' is not an object at global.FakeWebSocket.global.socket.onmessage (loleaflet.html?file_path=/storage/emulated/0/Documents/untitled.odt&closebutton=1&permission=edit:165) at <anonymous>:1:25 Change-Id: Ifa6a6b15843e0c8235b920cea07324db59282074 (cherry picked from commit 22720ee7d12b2d4567567f59a367251ba5f1f721) Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89885 Reviewed-by: Alexandru Vlăduţu <alexandru.vladutu@1and1.ro> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Bump package version to 6.3.0.0.beta1libreoffice-6.3.0.0.beta1Andras Timar2019-06-231-1/+1
| | | | Change-Id: Idec2fdf09a59fb972e116bf6b3b13325246ab935
* docker: fix SSL cert generation with OpenSSL 1.1.1Andras Timar2019-06-201-3/+4
| | | | | | | | Change-Id: I1534cd3d3da19ac17e65571e6e2f7e7b0a8e61ca Reviewed-on: https://gerrit.libreoffice.org/73953 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/74434
* Updated translations from PootleAndras Timar2019-06-206-184/+184
| | | | | | | Change-Id: I1777498a1ef6b0724523fac2b500b64faafb38b6 Reviewed-on: https://gerrit.libreoffice.org/74436 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
* force overwrite of ios-*.po when downloading from PootleAndras Timar2019-06-201-1/+1
| | | | | | | Change-Id: Ib0184ebe1b7485af819979acf4df268a564772b8 Reviewed-on: https://gerrit.libreoffice.org/74435 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
* Document Grab_Focus.Michael Meeks2019-06-201-0/+10
| | | | | | | Change-Id: Ic3deb0aeac9782250f50cb975cfb67712f032c2d Reviewed-on: https://gerrit.libreoffice.org/74433 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
* gitreview: Update branchSamuel Mehrbrodt2019-06-111-1/+1
| | | | | | | Change-Id: I693409007460fa275431758c3341a170bdb5ccca Reviewed-on: https://gerrit.libreoffice.org/73533 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Be more aggressive about updating last active time.Michael Meeks2019-06-073-2/+10
| | | | Change-Id: I5d269dfe0114fadf41359baa90ceeac4726171e5
* When dismissing a dialog use afterClose to re-focus map.Michael Meeks2019-06-071-1/+1
| | | | It seems beforeClose is used by vex itself to emit the callback.
* Log fatal errors also to stderrSamuel Mehrbrodt2019-06-051-0/+2
| | | | | | | | | | | Change-Id: I5e6429ab007d13a2506c375923049b91c80ffba0 Reviewed-on: https://gerrit.libreoffice.org/72722 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit b40cf51181ecf6d65f25238b84da0f98176fc249) Reviewed-on: https://gerrit.libreoffice.org/73526 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* Use LO branding colors for loading progress barSamuel Mehrbrodt2019-06-051-6/+6
| | | | | | | | | | | | | From https://wiki.documentfoundation.org/Marketing/Branding Change-Id: I7d3d5932ef67ae5c1a522d03e1d1a0a8960b0816 Reviewed-on: https://gerrit.libreoffice.org/73107 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 43f09f284ca9be50913a3799c0c98137a1fdf42c) Reviewed-on: https://gerrit.libreoffice.org/73528 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* Answer 404 when the file to download does not exist.Jan Holesovsky2019-06-051-3/+8
| | | | | | | | | | | | | | | This gives a better idea what has happened to those using the Download_As postMessage. Without this, the attempted download just gets stuck. Change-Id: Ic23bbca3761d795251664cf09956468fab13ed80 Reviewed-on: https://gerrit.libreoffice.org/73450 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 230aa62d17e4237e344fcf7d95491dbbd97ec660) Reviewed-on: https://gerrit.libreoffice.org/73530 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* loleaflet: updated translations from Pootle + Slovenianlibreoffice-6-3-branch-pointAndras Timar2019-06-02273-44122/+51185
| | | | Change-Id: If34b3ca5d71171d2831a6b70e82e6c6d92f24b4f
* tdf#122572: Use the _UNO() function instead of duplicating what it doesTor Lillqvist2019-05-311-8/+4
| | | | Change-Id: I54f7f49c2b4b82c3b8450b4475c2ea1267125df5
* tdf#122572: Use a context toolbar in the iOS app that looks more nativeTor Lillqvist2019-05-312-8/+69
| | | | | | | | Not icons, but white text on black background, etc. This is how the native context toolbar (whatever it actually is called in iOS) looks in Notes and Pages and in text input fields in general. Change-Id: Ibfa149fa8a951046de25c71022ea5c5684cfcc02
* tdf#122542: In the mobile apps, keep aspect ratio when dragging corner handlesTor Lillqvist2019-05-311-1/+2
| | | | | | I didn't have the clout to chage the behaviour for normal online. Change-Id: Icf790ceba4b6e23ade2fe1e106a740aeeb38c082
* Add an Emacs mode line to set the appropriate js-indent-levelTor Lillqvist2019-05-311-0/+1
| | | | Change-Id: Ie9e554faf269b41f277236e9b74a964456a5f7f8
* Add Visio Document, extensions vdx, vsd, vsdm, and vsdxTor Lillqvist2019-05-311-0/+34
| | | | | | | Together with two one-line changes to core, Visio files now open (read-only) in the app. Change-Id: I7dde2f7a8d1960c8fb9154c23e489ccc00a17b2d
* android: Make the LOK document accessible from the JNI.Jan Holesovsky2019-05-313-2/+25
| | | | | | | | | For some operations like printing to PDF, we need to have access to the LOK API to perform eg. saveAs(). iOS is using an extern for that, but given that it is needed for Android too, let's introduce a proper getter for that. Change-Id: Ie2340a4ee0bdf9dc46e799e2567a828172d9a67d
* test: use reserve() before calling emplace_back() in a loopMiklos Vajna2019-05-311-0/+1
| | | | Change-Id: Ieb754e9433cad9fc47c3449c1957702e493c7533
* Add interoperable Grab_Focus PostMessage.Michael Meeks2019-05-302-0/+11
| | | | Change-Id: I42cd24bfd502f46bb3f41cd6cf2f551263d57687
* tdf#125389: Guard against exception if e.touches is zero lengthTor Lillqvist2019-05-301-1/+10
| | | | | | | | | For a touchend event, the touches property will be a zero-length array. At least in WebKit on iOS or Safari. Work around that. The proper fix would probably be to not even call the getMousePosition() function for touchend events? Change-Id: I1c4cdb26b293e551c3c6f51208f73ee5a8044ecb
* detecting password protected files on convertToEduard Ardeleanu2019-05-301-3/+21
| | | | | | | | | Fail-fast when a file cannot be converted, using convertTo REST API, if the file is password protected and the password wasn't received. Change-Id: I32d807bcecbbe72a38a70fec74caf13638803e1d Reviewed-on: https://gerrit.libreoffice.org/72891 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
* tdf#124930: Look for settings also in the managed configuration thingTor Lillqvist2019-05-302-1/+23
| | | | | | | | | | | | | | Could not test whether it works, but it is not complicated, so hopefully yes. Followed the examples from https://developer.apple.com/videos/play/wwdc2013/301/ and https://developer.apple.com/library/archive/samplecode/sc2279/Introduction/Intro.html . The Mobile.plist file is a sample only. Note that here in the master branch there is no on-disk tile cache, so no setting for emptying that or not. Change-Id: I0b8cf8d35930cdf60808d14361378f050cf41037
* Add core source files from vcl/iosTor Lillqvist2019-05-301-0/+28
| | | | Change-Id: I1ca8d3fbf7a63b1965abd6799642854e03c4952d
* wsd: avoid unnecessary copy initialization in DocumentBrokerMiklos Vajna2019-05-301-1/+1
| | | | | | | 'filename' was copy-constructed from a const reference, no need to make a copy. Change-Id: I2ad86a1a524359c3bd50975484d7742558e88dfd
* Improve debugging by showing un-masked websocket content.Michael Meeks2019-05-291-1/+2
| | | | Change-Id: I0df0b3cc7b13c36ed8afaaec4ed2fe525458a21c
* Revert "Allow 'make run' after 'make build-nocheck'"Miklos Vajna2019-05-291-1/+1
| | | | | | | This reverts commit 1e84ea37c73283a9c2e2e8fa26fc73aa070f338b. This is no longer needed, at least not for the sanitizers. Change-Id: I70774525ce322870d0c6d625f33e6fd2476d9b5e
* Deprecate Views_Added and Views_Removed; implement Views_List instead.Jan Holesovsky2019-05-284-19/+48
| | | | | | | | | | | | | | This helps avoiding the situation when the state in the Online and in the integration get out of sync. The integration should always get the most current state via Views_List, and if they want to implement eg. notification what view has joined or has left, they should just compare the old and the new state. Change-Id: I841f77419bf86a57f77e16f8c0bd08063f31f68a Reviewed-on: https://gerrit.libreoffice.org/73103 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
* TestStubs: add more stubs for sanitizersMiklos Vajna2019-05-282-0/+19
| | | | | | | | This is needed to compile the tests without undefined references when using sanitizers. Previously it was possible to run loolwsd, but building the tests failed. Change-Id: I6babd1c43816cb2387c82316cc1bf9ff14d7a068
* tdf#124752: Do post the UNO clipboard commands in a mobile appTor Lillqvist2019-05-281-10/+15
| | | | | | | | | | | | | | | | | | | | | No reason to show the warn-copy-paste message in a mobile app. The native code of the app has access to the system clipboard just fine. This does not at such make the Edit>Copy etc menu entries work in the iOS app (the LibreOffice core code does not yet have system clipboard functionality for iOS, I am working on that), but this is one necessary step. This is a bit complicated, I don't like how the 'mobileappuno' properties have to be "manually" propagated from one data structure to another in the _createMenu function, but OTOH it's the same for the 'id' properties. Change-Id: I0ebe964e6eb6e4a902118714c1779451004c751f Reviewed-on: https://gerrit.libreoffice.org/72888 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
* re-order to fix threading; probable mis-merge.Michael Meeks2019-05-271-1/+3
| | | | Change-Id: Id59042248db7572add2d06f62cd8f1d4969ed889
* Enable the Share and Print buttons even in the View mode.Jan Holesovsky2019-05-271-0/+1
| | | | | | | | | | The user should be able to access these even in the initial View mode on Android. Change-Id: Id0631b7560c1ed0fda5f228f0c621cfa989b4cf7 Reviewed-on: https://gerrit.libreoffice.org/73038 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
* Send postMessage after renaming the documentmerttumer2019-05-271-4/+4
| | | | Signed-off-by: merttumer <mert.tumer@collabora.com>
* Send postMessage after renaming the documentmerttumer2019-05-271-0/+12
| | | | Signed-off-by: merttumer <mert.tumer@collabora.com>
* typo: retreieved -> retrievedAndras Timar2019-05-271-1/+1
| | | | Change-Id: Ib991569167711ebfe057daf1e2ca89ce809d35c4
* add back l10n support to this dialogAndras Timar2019-05-274-55/+55
| | | | Change-Id: I4e212cefb92cadc9a514e66f252ce19f05a8c114
* loleaflet: add postmessage checkAlexandru Vlăduţu2019-05-271-1/+1
| | | | | | | | | | Checks if messages are coming from the parent only (the frame which opened the editor) to avoid unwanted commands from 3rd parties. Change-Id: Ieffe36169dcefbe130869596672c1628c76b6799 Reviewed-on: https://gerrit.libreoffice.org/72340 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Revert "Get rid of use of GNU libtool" and its follow-upTor Lillqvist2019-05-279-109/+90
| | | | | | | | | | The change causes problems for people on various sad distros. Oh well, whatever. This reverts commit bd00d9fd0576b8f249d2145d8570bc395d137dc1. This reverts commit 054a9cdb045a84c0d779ad47cbec0b11f28a4f06. Change-Id: Ie439e4c655d02b6f34bdd1a9c1c5b6db6048b653
* net: avoid UB in WebSocketHandler::readPayload()Miklos Vajna2019-05-271-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Seen when closing a Writer document. /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:798:9: runtime error: reference binding to null pointer of type 'char' #0 0x6ff633 in std::vector<char, std::allocator<char> >::operator[](unsigned long) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:798:2 #1 0x770d0c in WebSocketHandler::readPayload(unsigned char*, unsigned long, unsigned char*, std::vector<char, std::allocator<char> >&) /home/vmiklos/lode/dev/online/./net/WebSocketHandler.hpp:611:29 #2 0x759324 in WebSocketHandler::handleTCPStream(std::shared_ptr<StreamSocket> const&) /home/vmiklos/lode/dev/online/./net/WebSocketHandler.hpp:251:13 #3 0x6f820d in WebSocketHandler::handleIncomingMessage(SocketDisposition&) /home/vmiklos/lode/dev/online/./net/WebSocketHandler.hpp:419:20 #4 0xb2da64 in ClientSession::handleIncomingMessage(SocketDisposition&) /home/vmiklos/lode/dev/online/wsd/ClientSession.cpp:74:14 #5 0xa70a61 in StreamSocket::handlePoll(SocketDisposition&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >, int) /home/vmiklos/lode/dev/online/./net/Socket.hpp:1037:29 #6 0x6ec83d in SocketPoll::poll(int) /home/vmiklos/lode/dev/online/./net/Socket.hpp:570:34 #7 0x830019 in DocumentBroker::pollThread() /home/vmiklos/lode/dev/online/wsd/DocumentBroker.cpp:286:16 #8 0x8fdb38 in DocumentBroker::DocumentBrokerPoll::pollingThread() /home/vmiklos/lode/dev/online/wsd/DocumentBroker.cpp:165:20 #9 0xe00e75 in SocketPoll::pollingThreadEntry() /home/vmiklos/lode/dev/online/net/Socket.cpp:184:9 #10 0xe49cfd in void std::__invoke_impl<void, void (SocketPoll::*)(), SocketPoll*>(std::__invoke_memfun_deref, void (SocketPoll::*&&)(), SocketPoll*&&) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 #11 0xe4980a in std::__invoke_result<void (SocketPoll::*)(), SocketPoll*>::type std::__invoke<void (SocketPoll::*)(), SocketPoll*>(void (SocketPoll::*&&)(), SocketPoll*&&) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 #12 0xe496bd in decltype(std::__invoke(_S_declval<0ul>(), _S_declval<1ul>())) std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:234:13 #13 0xe494c7 in std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> >::operator()() /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:243:11 #14 0xe4888a in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> > >::_M_run() /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:186:13 #15 0x7f2c5805fe2e in execute_native_thread_routine /home/vmiklos/lode/packages/gccbuild/x86_64-pc-linux-gnu/libstdc++-v3/src/c++11/../../../../../gcc-7.3.0/libstdc++-v3/src/c++11/thread.cc:83 #16 0x7f2c57a3c558 in start_thread (/lib64/libpthread.so.0+0x7558) #17 0x7f2c5715082e in clone (/lib64/libc.so.6+0xf882e) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:798:9 in Change-Id: Ifaf6b193e9bba480587c2e184df55aa0728bb370
* Add textbox creation to the Impress toolbar.Jan Holesovsky2019-05-244-3/+5
| | | | | | | Uses the newly added parameter to insert it directly, instead of using the mouse to define the bounds first. Change-Id: I3c10f379151b6789908585af02a8a18f3103e001
* Fix build issue with --enable-ssl after my previous commitTor Lillqvist2019-05-242-3/+8
| | | | | | | | Don't include the net/Ssl.cpp in the same WsdSources.cpp as the others, as our CRYPTO_dynlock_value definition is different from Poco's. Change-Id: I0fffcec09bcda387e8d7c3ba973a1681b11309fd
* Get rid of use of GNU libtoolTor Lillqvist2019-05-249-87/+101
| | | | | | | | | | | | | | | | | | | | | It is is complicated enough to build the iOS app. Requiring GNU libtool brings with it the risk of polluting the command environment as there already is a completely different command in macOS with the same name, /usr/bin/libtool. And as GNU libtool was used only to build the unit tests for the "normal" server-based Online that are built and run only on Linux anyway, we don't really need any of the "portability" that GNU libtool brings. Without GNU libtool, we compile all the $(wsd_sources) (see test/Makefile.am) that the unit-* tests use into a single object file, WsdSources.o. (Because they need to be compiled as PIC we can't use the already compiled object files for the Online server programs.) This required some additional minor changes to a few source files. Change-Id: I20a2c523170376fa4c1a0d9d8d6b693a9779376f Reviewed-on: https://gerrit.libreoffice.org/72840 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* test: fix build in UnitWOPILoadEncodedMiklos Vajna2019-05-241-2/+2
| | | | | | This was forward-ported without adapting to use the getters. Change-Id: I3b236b50a2021d95c02b3cc7983fa0b7b3d47dfa
* wsd: avoid UB in DocumentBroker::cancelTileRequests()Miklos Vajna2019-05-242-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With this, it's possible to open a document and type keys with sanitizers enabled. /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:323:9: runtime error: reference binding to null pointer of type 'TileCache' #0 0x911996 in std::unique_ptr<TileCache, std::default_delete<TileCache> >::operator*() const /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:323:2 #1 0x8ecb2a in DocumentBroker::tileCache() /home/vmiklos/lode/dev/online/./wsd/DocumentBroker.hpp:265:37 #2 0x8c6a63 in DocumentBroker::cancelTileRequests(std::shared_ptr<ClientSession> const&) /home/vmiklos/lode/dev/online/wsd/DocumentBroker.cpp:1586:37 #3 0xb32b0e in ClientSession::_handleInput(char const*, int) /home/vmiklos/lode/dev/online/wsd/ClientSession.cpp:194:20 #4 0xd45d3c in Session::handleMessage(bool, WSOpCode, std::vector<char, std::allocator<char> >&) /home/vmiklos/lode/dev/online/common/Session.cpp:219:13 #5 0x768080 in WebSocketHandler::handleTCPStream(std::shared_ptr<StreamSocket> const&) /home/vmiklos/lode/dev/online/./net/WebSocketHandler.hpp:368:13 #6 0x6f800d in WebSocketHandler::handleIncomingMessage(SocketDisposition&) /home/vmiklos/lode/dev/online/./net/WebSocketHandler.hpp:419:20 #7 0xb2c644 in ClientSession::handleIncomingMessage(SocketDisposition&) /home/vmiklos/lode/dev/online/wsd/ClientSession.cpp:74:14 #8 0xa6f641 in StreamSocket::handlePoll(SocketDisposition&, std::chrono::time_point<std::chrono::_V2::steady_clock, std::chrono::duration<long, std::ratio<1l, 1000000000l> > >, int) /home/vmiklos/lode/dev/online/./net/Socket.hpp:1037:29 #9 0x6ec63d in SocketPoll::poll(int) /home/vmiklos/lode/dev/online/./net/Socket.hpp:570:34 #10 0x83af99 in DocumentBroker::pollThread() /home/vmiklos/lode/dev/online/wsd/DocumentBroker.cpp:387:16 #11 0x8fc778 in DocumentBroker::DocumentBrokerPoll::pollingThread() /home/vmiklos/lode/dev/online/wsd/DocumentBroker.cpp:165:20 #12 0xdff935 in SocketPoll::pollingThreadEntry() /home/vmiklos/lode/dev/online/net/Socket.cpp:184:9 #13 0xe487bd in void std::__invoke_impl<void, void (SocketPoll::*)(), SocketPoll*>(std::__invoke_memfun_deref, void (SocketPoll::*&&)(), SocketPoll*&&) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14 #14 0xe482ca in std::__invoke_result<void (SocketPoll::*)(), SocketPoll*>::type std::__invoke<void (SocketPoll::*)(), SocketPoll*>(void (SocketPoll::*&&)(), SocketPoll*&&) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14 #15 0xe4817d in decltype(std::__invoke(_S_declval<0ul>(), _S_declval<1ul>())) std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:234:13 #16 0xe47f87 in std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> >::operator()() /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:243:11 #17 0xe4734a in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (SocketPoll::*)(), SocketPoll*> > >::_M_run() /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/thread:186:13 #18 0x7f5c2ce55e2e in execute_native_thread_routine /home/vmiklos/lode/packages/gccbuild/x86_64-pc-linux-gnu/libstdc++-v3/src/c++11/../../../../../gcc-7.3.0/libstdc++-v3/src/c++11/thread.cc:83 #19 0x7f5c2c832558 in start_thread (/lib64/libpthread.so.0+0x7558) #20 0x7f5c2bf4682e in clone (/lib64/libc.so.6+0xf882e) SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/vmiklos/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:323:9 in Change-Id: Ief574a11c838c77f7f159b1133beeef0deada201
* wsd: fix the exception "Bad URI syntax"Henry Castro2019-05-244-8/+91
| | | | | | | | | | | | | if the file name has '%' character it throws exception "Bad URI syntax", so use the encoded file name string Change-Id: I6a8d841761b46ac49a6c79956ba215e1affa53e5 Reviewed-on: https://gerrit.libreoffice.org/72385 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit b934c70f4f1f9f3ee4f873570633a3b1ec931652) Reviewed-on: https://gerrit.libreoffice.org/72890
* Make renamefile more careful.Michael Meeks2019-05-231-4/+7
| | | | Change-Id: If39353fc01ea48d8e0077b228a6281839dde5c87
* wsd: avoid UB in FileServerRequestHandler::readDirToHash()Miklos Vajna2019-05-231-0/+3
| | | | | | | | | | | | | | | | wsd/FileServer.cpp:464:35: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/dirent.h:162:45: note: nonnull attribute specified here #0 0xbf566b in FileServerRequestHandler::readDirToHash(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/vmiklos/lode/dev/online/wsd/FileServer.cpp:464:27 #1 0xbf8417 in FileServerRequestHandler::initialize() /home/vmiklos/lode/dev/online/wsd/FileServer.cpp:531:13 #2 0x98617a in LOOLWSD::initialize(Poco::Util::Application&) /home/vmiklos/lode/dev/online/wsd/LOOLWSD.cpp:1155:5 #3 0x7f17fc9c8263 in Poco::Util::Application::run() (/usr/lib64/libPocoUtil.so.60+0x3e263) #4 0x9c29f3 in main /home/vmiklos/lode/dev/online/wsd/LOOLWSD.cpp:3466:1 #5 0x7f17fa739f49 in __libc_start_main (/lib64/libc.so.6+0x20f49) #6 0x5c1e19 in _start /home/abuild/rpmbuild/BUILD/glibc-2.26/csu/../sysdeps/x86_64/start.S:120 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wsd/FileServer.cpp:464:35 in Change-Id: Iadb90c4e98981283718be3e3e9f55cb0b7a3e917
* Allow 'make run' after 'make build-nocheck'Miklos Vajna2019-05-231-1/+1
| | | | | | | This is useful for the sanitizers build, which can build the code, but not yet the tests. Change-Id: I02a0493dd18cf68f68572cd08af22d0f7805d97a
* Some menubar folding/unfolding cleanupsSamuel Mehrbrodt2019-05-232-12/+6
| | | | | | | Change-Id: I4e5abe59076a5dbd41b1c8d002c0f3c4e53569de Reviewed-on: https://gerrit.libreoffice.org/72858 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2024-05-20 16:36:34 +0000