| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic2573450406e7d8238411b5627615f5735137da7
|
|
|
|
| |
Change-Id: Ic6a2bb55d620c8b0790aa0da73485db3c6d271dd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplified download process (ab162b6f9580315700a01c3bc10becd510a2ead4)
introduced a bug. Trying to download file with eg. space in the name
become impossible. This patch decodes the string to fix the issue.
Change-Id: I8e5d98010cf098b889eddcce4ba1ce65367b15d5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102874
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 87aad0a8bbf86502658ffcf3d0ee053af922d474)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102763
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use hash to identify download and pass that to the client.
This allows us to reduce parameters for download requests.
DocBroker maps download ids to URL in the file system.
Change-Id: I254d4f0ccaf3cff9f038a817c8162510ae228bc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101992
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102227
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
| |
Change-Id: Ia6babe4ec988705090b9d0c95cc93b6a037de0b9
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I2aed56cf362c0e68918955340d35013179a54ad1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101909
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101919
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
| |
Change-Id: I1b811bd2fbabaa7c23861b215dc254832d200324
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100064
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I96265c5d0e7b18d9ae19efa0ce7477aead75dbf7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93422
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Gabriel Masei <gabriel.masei@1and1.ro>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/93439
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Catch that, similar to when handling an invalid argument.
(cherry picked from commit 946fa38a22e2e90965392446a559c78c87d92219)
Change-Id: I7405355f0b962673069dbd33dbab8c9e3042c4bf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91973
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==15956==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000007cd2f7 bp 0x7ffe96c7cd70 sp 0x7ffe96c7c4e8 T0)
...
#7 0x11a9d31 in ClientSession::filterMessage(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const wsd/ClientSession.cpp:977:27
#8 0x11925d6 in ClientSession::_handleInput(char const*, int) wsd/ClientSession.cpp:741:14
#9 0x19395d0 in Session::handleMessage(bool, WSOpCode, std::vector<char, std::allocator<char> >&) common/Session.cpp:230:13
This seems to be a recurring pattern, I'll consider reworking
LOOLProtocol::tokenize() in a follow-up commit to have a return value
that is safer than std::vector<std::string>.
(cherry picked from commit d129979822212f739279de89c9f6ad5d48f338f4)
Change-Id: I0e71214a55af2e71e4787cb0dba0ddf7825bf9d9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91972
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on a fresh openSUSE Leap 15.1 I got errors without this:
wsd/AdminModel.hpp:346:10: error: ‘list’ in namespace ‘std’ does not name a template type
std::list<unsigned> _memStats;
^~~~
etc.
Change-Id: I19c42bd48bbcc0787a3398d1882c974ebf5bdf81
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89298
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/92045
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
|
|
|
|
| |
Change-Id: I668fc51ee3ab170cd20bde78ea56f63cd426a37c
|
|
|
|
|
|
|
| |
Change-Id: Iaa668b27f571614b04c6908f1f57faf29e1414fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90379
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I816ba7209ebfe8d051cbd6cef054245b9ab08950
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90334
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90367
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==11898==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x0000007c4f87 bp 0x7fffe45dfe90 sp 0x7fffe45df608 T0)
==11898==The signal is caused by a READ memory access.
==11898==Hint: address points to the zero page.
#0 0x7c4f86 in AddressIsPoisoned lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_mapping.h:397
#1 0x7c4f86 in __asan::QuickCheckForUnpoisonedRegion(unsigned long, unsigned long) lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.h:31
#2 0x816436 in MemcmpInterceptorCommon(void*, int (*)(void const*, void const*, unsigned long), void const*, void const*, unsigned long) lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:834
#3 0x816d38 in memcmp lode/packages/llvm-472c6ef8b0f53061b049039f9775ab127beafbe4.src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:866
#4 0x7f1964437595 in std::char_traits<char>::compare(char const*, char const*, unsigned long) lode/packages/gccbuild/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/char_traits.h:310
#5 0x7f1964437595 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::compare(unsigned long, unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const lode/packages/gccbuild/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:1391
#6 0x18e206d in LOOLProtocol::getTokenString(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) common/Protocol.cpp:141:19
#7 0x117cc0a in ClientSession::filterMessage(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const wsd/ClientSession.cpp:940:13
#8 0x116b832 in ClientSession::_handleInput(char const*, int) wsd/ClientSession.cpp:741:14
#9 0x18f70d0 in Session::handleMessage(bool, WSOpCode, std::vector<char, std::allocator<char> >&) common/Session.cpp:230:13
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89229
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit aefc65465b255e09ee2f66cbebaf1b2e54ded40c)
Change-Id: I0c7da6c02ac62bf0bc99557517fc7c517917046c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89546
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==13901==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x000000904678 bp 0x7ffdb9e21580 sp 0x7ffdb9e21340 T0)
==13901==The signal is caused by a READ memory access.
==13901==Hint: address points to the zero page.
#0 0x904677 in LOOLProtocol::tokenize[abi:cxx11](char const*, unsigned long, char) common/Protocol.hpp:113:40
#1 0x898c52 in LOOLProtocol::tokenize(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, char) common/Protocol.hpp:141:16
#2 0x18dc2d9 in LOOLProtocol::ParseVersion(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) common/Protocol.cpp:35:51
#3 0x1148824 in ClientSession::_handleInput(char const*, int) wsd/ClientSession.cpp:358:64
#4 0x18efcb8 in Session::handleMessage(bool, WSOpCode, std::vector<char, std::allocator<char> >&) common/Session.cpp:232:13
Next commit will add the actual simple fuzzer that found this.
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89225
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 8d2a8da960828d16502927f80ad76fabf502df6d)
Conflicts:
common/Protocol.cpp
Change-Id: I8623b4451a57390f6f84c11084c5a1120a11fcc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89545
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: I6eaa3f0c1529b968b8eaa7ea67356dd5bf54d3f1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88418
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 36eed0c6f07cef512ec83fb8c22d2c6200e7ce5c)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89909
|
|
|
|
|
|
|
| |
Change-Id: I7fc728e9da03ad2b1f6811d7a03307f2d3876b31
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89790
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I297eb7b2eac78de76601b13f2bcb075119b0f7db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89120
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
|
|
|
|
|
| |
Change-Id: Ia3491777211adf8f9bd257bf28a3498fe928e021
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89114
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
|
|
|
|
|
| |
Change-Id: Idf46c11bc4fccb14e4a3955e9ac88901ed94586b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89113
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
|
|
|
|
|
|
|
| |
simplify using Date.toLocaleDateString
Change-Id: Ib264cd90edd7ddacb3b944ee7f252648a629ab3f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89112
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
use Date.toLocaleDateString that returns a string with a language sensitive
representation of the date portion of this date
Change-Id: Id2e207e5b4d0dbc8d82498567c97105052d70b90
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89111
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I6470deb2cfa93d59ebb612d223bb2829a6cea75e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88956
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
| |
Change-Id: I475899486cfab83c1da20b57531c2e013e7aff0d
|
|
|
|
| |
Change-Id: I140a88374adf15730fc1b9dd176ec88e99b74612
|
|
|
|
|
|
|
| |
Change-Id: I24ab50b80e51c293a4ad71c6e5ea80bfda902883
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88860
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ieec6eaac475b4e318578cfc0d93c36e2395e6f19
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87097
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit 09bb16ad78f71e285b6059774ce089b9ef1d006b)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87110
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that both the DocBrokers map and the instance returned by
Admin::instance() are static, so there it's not safe to assume that by
the time the DocumentBroker dtor runs, the static Admin instance is
still alive. Still, the DocumentBroker dtor calls Admin::instance().
Fix this by clearing the DocBrokers map in LOOLWSD::cleanup(), which is
used exactly to destroy statics in a controlled order.
Sanitizers output was:
wsd/DocumentBroker.cpp:497:23: runtime error: member call on address 0x0000024a5ba0 which does not point to an object of type 'Admin'
0x0000024a5ba0: note: object is of type 'SocketPoll'
00 00 00 00 50 21 45 01 00 00 00 00 b8 5b 4a 02 00 00 00 00 05 00 00 00 00 00 00 00 61 64 6d 69
^~~~~~~~~~~~~~~~~~~~~~~
vptr for 'SocketPoll'
#0 0xa10af3 in DocumentBroker::~DocumentBroker() wsd/DocumentBroker.cpp:497:23
...
#17 0x7fa27622ddc9 in exit (/lib64/libc.so.6+0x38dc9)
#18 0x7fa276215f90 in __libc_start_main (/lib64/libc.so.6+0x20f90)
#19 0x670189 in _start /home/abuild/rpmbuild/BUILD/glibc-2.26/csu/../sysdeps/x86_64/start.S:120
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wsd/DocumentBroker.cpp:497:23 in
(Seen during make check CPPUNIT_TEST_NAME="unit-each-view".)
Conflicts:
wsd/LOOLWSD.cpp
Change-Id: I02ad44deb9de06d9973216428c640248ea2512ce
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87178
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some integrations send a BCP 47 language tag in lang parameter (by the way
this is what makes sense, the lower case codes are non-standard). This commit
fixes the bug, when for example lang=pt-BR fell back to pt with the JavaScript
UI.
Change-Id: I770f499feb605696fa589bfc326194218c3c9fb1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87224
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
| |
Change-Id: I21933dd3540f51ca044d140dae6bc862e5199612
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, it causes error log:
ERR Cannot save docKey [/filename], the .uno:Save has failed in LOK.
Change-Id: Ic99807848def72f76471c4f999ebeed9a7c0a2c8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87085
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a fully reliable uniqueness check, rather than a hash, and get
simpler ids as a bonus. Fetch view data from the session itself
rather than passing it in too.
Change-Id: Ibcd625156b5a98eb280e35d6537b5c8c026d0197
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86150
Reviewed-by: Mert Tümer <mert.tumer@collabora.com>
Tested-by: Mert Tümer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87064
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cookies may be passed from the client to the storage,
in which case each user may have its own unique set
of cookies. These cookies are now preserved in the
ClientSession, which is per connection, and are then
passed to the storage to use when communicating with
the WOPI-like backend.
Change-Id: Ic2e13fa541a5ee01b7383939bbbf7d46ea75684b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87033
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
|
|
|
|
|
|
|
| |
Change-Id: Ib9058956143aae8151c5e76fddff5dea313ff5e7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86323
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
(cherry picked from commit ad0256259bd8634cbd06b3ff5e881961f384023e)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86360
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Happens with some close frames eg.
[ docbroker_001 ] TRC #21: Incoming WebSocket data of 6 bytes: 88 80 4a 2c 44 f9 | ..J,D.|
fin = true
OpCode is Close (= 0x8)
hasMask = true
payloadLen = 0
headerLen = 2 -> 6 after hasMask is taken into account.
Change-Id: I0e212e4589c3cc63db16f7065dc90cd0bd539ada
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/86280
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
| |
We were inadvertently mutating and growing our copy of the bounds
to fetch here, causing a chunk of un-necessary rendering load,
particularly for spreadsheets.
Change-Id: Ia01565c043d1cb0172cabbec16d941dd8b66dd05
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/84775
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
| |
Change-Id: I9d3b3819b3d9a960aa31f729686315e9e5d6d8e1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/84776
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
| |
Change-Id: I9fb3323b8d071fdc50399a67eb6b0aaeed9342b0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/84817
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
| |
Change-Id: I6c0a781910e28cb1fe9c1e2581752527db15c0b2
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PID became visible after this commit:
87b95bb546a9f3739cd688b5c068b00095f7737b
Change-Id: I55da1cbafaf4422576214d1b8ee1710605765e31
Reviewed-on: https://gerrit.libreoffice.org/83609
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit d00d996607a7bc7f2a733c9934cc6c6a08c39a4a)
Reviewed-on: https://gerrit.libreoffice.org/84080
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
|
|
|
|
| |
Change-Id: Id309a67abc9f2fc869d2b8accd2d34ede46bef66
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1879a45a057b04a8f2d23b505b5c931f9c9e4151.
Unfortunately it broke full screen slideshow and document download functionality,
and the fix would have been hard.
Change-Id: Iba9d9d8486cc03b7151e392b8be9d5e86c04db46
|
|
|
|
| |
Change-Id: Ifda0a4390b3dcb8e5307235ea6857e680327c664
|
|
|
|
|
|
|
|
| |
Quick band-aid fix to get the build going. The SUSE part has to be reviewed
at some point. openSUSE LEap 42.3 has python-polib, openSUSE Leap 15.x have
python2-polib.
Change-Id: I0317963b0c922245ce9488392cfff293119dcf67
|
|
|
|
|
|
| |
After e70bdc3c9c44c0bb19aa241c7e81e339a84bb50b.
Change-Id: I44965ac9a4e110bee42502d5a0ee651e2fce90ea
|
|
|
|
| |
Change-Id: Ibe8ed6f649a2703ac6a1c1653ac5bd45a47e7d82
|
|
|
|
|
|
|
|
|
|
|
| |
Change-Id: I9b399a4e1daf52f536d4becae2cc6dc692e16f7a
Reviewed-on: https://gerrit.libreoffice.org/81436
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 2c598ba4ef8015e9fd2a5a6ffe9fa064dbbead4e)
Reviewed-on: https://gerrit.libreoffice.org/83934
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the iOS app is able to open a document called A#B?C\D&E❤️F🇨🇭G%AAHÖ.doc.
That is, with ‘#’, ‘?’, and ‘&’ that can mess things up when parsing URIs,
non-ASCII and even non-BMP characters, and an actual percent
character in the file name. Is that a complete enough test case? Will see.
Change-Id: I7fc53eaf8188f633d442d14a7f42814553169c71
Reviewed-on: https://gerrit.libreoffice.org/83395
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit b60ccd60c59efb5a03ea698c0205a8543846d9e2)
Reviewed-on: https://gerrit.libreoffice.org/83749
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
|
|
|
|
|
| |
Change-Id: Idc30c17e135166d2ce07e64456abc9484fb69d76
Reviewed-on: https://gerrit.libreoffice.org/83935
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|