diff options
| author | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2021-07-30 12:47:18 -0400 |
|---|---|---|
| committer | Ashod Nakashian <Ashod@users.noreply.github.com> | 2021-09-26 17:02:01 -0400 |
| commit | d395f521dfb055e8223f2b7bfb5e66aef5535ead (patch) | |
| tree | 96e7870e4d374903700427a292e115ab53eb1497 /wsd | |
| parent | leaflet: more accurate wording in comment (diff) | |
| download | online-d395f521dfb055e8223f2b7bfb5e66aef5535ead.tar.gz online-d395f521dfb055e8223f2b7bfb5e66aef5535ead.zip | |
wsd: log stopping-although-modified as warning
This log entry can be misleading on its own.
When shutting down, the modified flag is not reset,
and that in itself is not a cause for concern.
So this log entry is seen much more often than we
expect. If we truely fail to save/upload, there
will be other errors that will be the tell-tale
signs of a serious issue. So it's reasonable to
downgrade this error to a warning (and watch for
other errors).
Change-Id: Ic879c3fbac887ed5b64bdd1a31aa38bcfd863850
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 7db86b3eb2cdc2a44023e7b7491e1ee202146ef5)
Diffstat (limited to 'wsd')
| -rw-r--r-- | wsd/DocumentBroker.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp index 125da27ff6..db26a9190d 100644 --- a/wsd/DocumentBroker.cpp +++ b/wsd/DocumentBroker.cpp @@ -508,7 +508,7 @@ void DocumentBroker::pollThread() { std::stringstream state; dumpState(state); - LOG_ERR("DocumentBroker stopping although modified " << state.str()); + LOG_WRN("DocumentBroker stopping although flagged as modified " << state.str()); } // Flush socket data first. @@ -3242,7 +3242,7 @@ void DocumentBroker::dumpState(std::ostream& os) << Util::getSteadyClockAsString(_saveManager.lastSaveRequestTime()); os << "\n last save response: " << Util::getSteadyClockAsString(_saveManager.lastSaveResponseTime()); - os << "\n last storage save was successful: " << isLastStorageUploadSuccessful(); + os << "\n last storage upload was successful: " << isLastStorageUploadSuccessful(); os << "\n last modified: " << Util::getHttpTime(_storageManager.getLastModifiedTime()); os << "\n file last modified: " << Util::getHttpTime(_saveManager.getLastModifiedTime()); os << "\n isSaving now: " << std::boolalpha << _saveManager.isSaving(); |