cid#323357 silence String not null terminated

it's a good catch, but inotify man page says it can't happen

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I350f8fad2aa8308563ccb4f9f3ec9b7850a72fa7

1 files changed, 6 insertions, 2 deletions

diff --git a/wsd/COOLWSD.cpp b/wsd/COOLWSD.cpp
index 3f128928d9..680509a827 100644
--- a/wsd/COOLWSD.cpp
+++ b/wsd/COOLWSD.cpp
@@ -1078,14 +1078,16 @@ void InotifySocket::handlePoll(SocketDisposition & /* disposition */, std::chron
         return;
 
     char buf[4096];
+
+    static_assert(sizeof(buf) >= sizeof(struct inotify_event) + NAME_MAX + 1, "see man 7 inotify");
+
     const struct inotify_event* event;
-    ssize_t len;
 
     LOG_TRC("InotifyPoll - Checking for config changes...");
 
     while (true)
     {
-        len = read(getFD(), buf, sizeof(buf));
+        ssize_t len = read(getFD(), buf, sizeof(buf));
 
         if (len == -1 && errno != EAGAIN)
         {
@@ -1101,6 +1103,8 @@ void InotifySocket::handlePoll(SocketDisposition & /* disposition */, std::chron
         if (len <= 0)
             break;
 
+        assert(buf[len - 1] == 0 && "see man 7 inotify");
+
         for (char* ptr = buf; ptr < buf + len; ptr += sizeof(struct inotify_event) + event->len)
         {
             event = (const struct inotify_event*)ptr;