diff options
| author | Szymon Kłos <szymon.klos@collabora.com> | 2022-08-24 17:02:25 +0200 |
|---|---|---|
| committer | Szymon Kłos <eszkadev@gmail.com> | 2022-09-01 09:57:33 +0200 |
| commit | 073f35b9797648e45e2b70f05b11406ecf14fd04 (patch) | |
| tree | 9624bece5ffbd47e9bc400f015d22c5ca1e57acf /browser | |
| parent | jsdialog: find real input on setText action (diff) | |
| download | online-073f35b9797648e45e2b70f05b11406ecf14fd04.tar.gz online-073f35b9797648e45e2b70f05b11406ecf14fd04.zip | |
jsdialog: correctly setup & test value for spinfields
backport/5107/distro/collabora/co-21-11
Adding attribute by jQuery and testing in cypress was
not working: visible value was correct after change but
in DOM we had original value which was tested by Cypress.
Use val() to setup value and have.value for cypress to test.
Unify inputs so we don't use attributes but always props.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1b3acccbd6d4ba493f867044b9b3c1f17b16873e
Diffstat (limited to 'browser')
| -rw-r--r-- | browser/src/control/Control.JSDialogBuilder.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/browser/src/control/Control.JSDialogBuilder.js b/browser/src/control/Control.JSDialogBuilder.js index b4f7dd0901..7669382656 100644 --- a/browser/src/control/Control.JSDialogBuilder.js +++ b/browser/src/control/Control.JSDialogBuilder.js @@ -1313,7 +1313,7 @@ L.Control.JSDialogBuilder = L.Control.extend({ else if (data.children && data.children.length) value = data.children[0].text; - $(controls.spinfield).attr('value', builder._cleanValueFromUnits(value)); + $(controls.spinfield).val(builder._cleanValueFromUnits(value)); }; controls.spinfield.addEventListener('change', function() { @@ -1347,7 +1347,7 @@ L.Control.JSDialogBuilder = L.Control.extend({ builder.listenNumericChanges(data, builder, controls, customCallback); value = parseFloat(data.value); - $(controls.spinfield).attr('value', value); + $(controls.spinfield).val(value); return false; }, @@ -1359,7 +1359,7 @@ L.Control.JSDialogBuilder = L.Control.extend({ builder.listenNumericChanges(data, builder, controls, customCallback); value = parseFloat(data.value); - $(controls.spinfield).attr('value', value); + $(controls.spinfield).val(value); return false; }, |