summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenry Castro <hcastro@collabora.com>2023-04-13 14:14:54 -0400
committerAshod Nakashian <Ashod@users.noreply.github.com>2023-06-09 09:15:37 -0400
commitd14aaeeaa37b16a6e472e8411f0a3defda278c20 (patch)
tree38f6efe3c7af2d7546d408e88ad4f1643b49e136
parentbrowser: admin: fix vex dialog on socket close (diff)
downloadonline-d14aaeeaa37b16a6e472e8411f0a3defda278c20.tar.gz
online-d14aaeeaa37b16a6e472e8411f0a3defda278c20.zip
wsd: fix secure cookie Set-Cookie
The browser will block the cookie if it is sent over an insecure connection "This attempt to set a cookie via a set-cookie header was blocked because it had the "Secure" attribute but was not received over a secure connection." Change-Id: I36faac0d9d3a73eed463c2580e5405d61a3a18f5 Signed-off-by: Henry Castro <hcastro@collabora.com>
-rw-r--r--wsd/FileServer.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index a07a25784b..fe2efb3364 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -259,8 +259,7 @@ bool FileServerRequestHandler::isAdminLoggedIn(const HTTPRequest& request,
Poco::Net::HTTPCookie cookie("jwt", jwtToken);
// bundlify appears to add an extra /dist -> dist/dist/admin
cookie.setPath(COOLWSD::ServiceRoot + "/browser/dist/");
- cookie.setSecure(COOLWSD::isSSLEnabled() ||
- COOLWSD::isSSLTermination());
+ cookie.setSecure(COOLWSD::isSSLEnabled());
response.addCookie(cookie);
return true;