summaryrefslogtreecommitdiffstats
path: root/chart2/source/controller/dialogs
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:ostr in chart2Noel Grandin2024-05-0750-508/+513
| | | | | | | Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
* tdf#146619 Drop unused 'using namespace' in: chart2/Gabor Kelemen2024-04-094-4/+0
| | | | | | | Change-Id: I632d0dda0e62e5b1bf0956e731ab5ed6417db1ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165688 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
* tdf#39052 - Chart: make characters formatable in editable chart textshapesBalazs Varga2024-04-021-1/+1
| | | | | | | | | | | | | | | | | | | | | Editable textshapes include main chart title, sub chart title, axis titles. In chart2 the chart2::XFormattedString and chart2::XFormattedString2 store the formatted characters from textshapes, so we need to set all the character properties from the EditTextObject and need to add them to to the XFormattedString array with all the related texts which are formatted individually. For formatting of the characters the .uno:FontDialog command can be used, which can be called from the chart menubar, toolbar and with right click on the text when we are in edit mode in the textshape. (Note: in the next patch the OOXML export will be fixed.) Change-Id: I5750a5fe694b384dc6b28e2ef03ac1f2b03957db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165501 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
* tdf#146619 Remove unused #includes from C/C++ filesRafał Dobrakowski2024-03-2717-23/+1
| | | | | | | | | 'chart2' module was cleaned. Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
* ITEM: Remove InvalidateAllItems()Armin Le Grand (allotropia)2024-03-214-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I checked if this is used, but it can be replaced using Clear() -> all. This prevents that the whole array of Items in an ItemSet gets set to INVALID_POOL_ITEM. I also checked if INVALID_POOL_ITEM/IsInvalidItem is needed at all representing SfxItemState::DONTCARE but it is and still will need to be set for individual Items. At last checked if SfxItemState::UNKNOWN and ::DISABLED really need to be separate states, but indeed there are some rare cases that need that. To make things more consistent I also renamed SfxItemState::DONTCARE to SfxItemState::INVALID to better match Set/IsInvalid calls at ItemSet. The build showed a missing UT and led to a problem due to the hand-made ItemSet-like SearchAttrItemList. The state 'invalid' seems to be used as 'unused' marker. It should be changed to use SfxPoolItemHolder and not need that. For now, set by using an own loop to set to that state. Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
* Resolves: tdf#159879 Crash when closing "3D View" dialogCaolán McNamara2024-03-031-0/+2
| | | | | | | Change-Id: I9c116007afe9cea97b597933ad8483dce25c3707 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* tdf#50934: Add a version comment, and more structure for of-pieKurt Nordback2024-02-061-1/+1
| | | | | | | Change-Id: I9d7c25e47a3f4a78360f9b2deffe8650e378866d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#50934: Initial plumbing and infrastructureKurt Nordback2024-02-021-0/+6
| | | | | | | Change-Id: I355bdc8e6d67e7cdd47e4d6eccecedc4b53ac11b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Drop std::as_const from css::uno::Sequence iterationsMike Kaganski2024-01-271-1/+1
| | | | | | | | | | | | Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[] in internal code, 2021-11-05). Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* no need to allocate this on the heapNoel Grandin2023-12-161-2/+2
| | | | | | | Change-Id: I89d4e680e6c8aabcc543605a0e496b3086dd2d3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160838 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#158684: CHART XY Scatter Chart: line type "stepped" ignores parametersJulien Nabet2023-12-141-1/+1
| | | | | | | | | | | Regression from 65752e649872edfd98915035b61aca510ae8f271 Date: Fri Mar 24 10:52:13 2023 +0100 jsdialog: enable and make async chart line prop dialog Change-Id: I1532c45ae72d2c45ace72bcc099fcc8baa265b99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160715 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2Stephan Bergmann2023-10-192-5/+5
| | | | | | | Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* jsdialog: fix layout of chart type dialogSzymon Kłos2023-09-111-1/+1
| | | | | | | | | | | | | directly set content area container to avoid buttons on top of the dialog in lok case Change-Id: I8353102f679a8f19c3041c7b4ec0b1200ed7d515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156254 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156813 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* replace set(nullptr) with clear()Noel Grandin2023-09-021-1/+1
| | | | | | | | | | It's a little easier to read, but mostly it makes an upcoming loplugin easier to implement Change-Id: I4ae7db8eda77795dab3255d1afd8ba4f20a8de76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failedCaolán McNamara2023-08-011-1/+1
| | | | | | | | | | on loading sw//qa/extras/layout/data/tdf125334.odt and double clicking chart Change-Id: I65b10c0223e9c217d77dc7daa73580fadffc32c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* simplify calculations in SeriesHeader::SetPosNoel Grandin2023-07-141-10/+5
| | | | | | | Change-Id: I0a3afe10dec530a6d7ddc32cf7d96ec5095604c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#155526 Restore status bar for moving averageLaurent Balland2023-06-291-20/+28
| | | | | | | | | | Previous commit dc03f59374d4fc74dd44ddedc903bb9c00a74bb7 broke text in status bar when a moving average trend line is selected Change-Id: I259fb9aee1eccf9fac93038c6dd2755490769f88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153677 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* new loplugin:constexprliteralNoel Grandin2023-06-261-2/+2
| | | | | | | | | | | | OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#155526 Add Period to trend line equationLaurent Balland2023-06-182-15/+2
| | | | | | | | | | Insert Period value earlier to have it ready for representation Allow Moving average equation in dialog UI Change-Id: I1d20572c39462e60b60ab7eec1f174a3cf934d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* tdf#155376 partially convert SvCTLOptions to officecfgNoel Grandin2023-06-071-1/+1
| | | | | | | | | | | | | | | | | | | When accessibility is enabled, Calc will add tens of thousands of listeners. We then spend a significant chunk of time creating SvCTLOptions objects (attached to ImpEditEngine) and adding and removing those objects from the related listener lists. But the required information is already globally cached by the officecfg module, so we can avoid that overhead and just fetch it directly from officecfg. Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* svx: change NamedColor be a struct instead of std::pairTomaž Vajngerl2023-05-251-1/+1
| | | | | | | Change-Id: Ice1625e8cae8da859ea8a940b3f8e40f6f9d7037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152235 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* tdf#155231 CRASH: with embedded OLE chartNoel Grandin2023-05-112-7/+12
| | | | | | | | | | | | | | regressions from commits like commit 70595c0291e4cc137158c77f6136025b10ce6728 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Mar 16 09:20:17 2023 +0200 move setDimension/getDimension inside chart2::Diagram Change-Id: I535d8e74d621821bde7d31894fe7f0350e91c941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151664 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#155231: fix CRASH: with embedded OLE chartJulien Nabet2023-05-101-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | First bt: 6 0x00007f19f96b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x55f40881f1f0) at include/rtl/ref.hxx:216 7 0x00007f19f97b0a03 in chart::DialogModel::isCategoryDiagram() const (this=0x55f407cfffb0) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:656 8 0x00007f19f983ab1a in chart::DataSourceTabPage::updateControlState() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:439 9 0x00007f19f983a954 in chart::DataSourceTabPage::SeriesSelectionChangedHdl(weld::TreeView&) (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:469 10 0x00007f19f98380e2 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:313 see full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=187190 Second part bt: 6 0x00007fc66e0b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x7ffce5f5c9b0) at include/rtl/ref.hxx:216 7 0x00007fc66e1b00d8 in chart::DialogModel::getCategories() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:601 8 0x00007fc66e1b0474 in chart::DialogModel::getCategoriesRange() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:637 9 0x00007fc66e238141 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x5590c00c4030) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:316 Regression from: commit 5a4b75dcb5abc2e925870614a28e1c2876df8ed9 (patch) tree 5fe1f89c70f9c6d90d3eea8f9eb9a68e91f2dec0 parent dab0d4e1f36faace21145a51733bd3a946992624 (diff) use more concrete types in chart2, Diagram Change-Id: I4332a237248c5acacab7180733d502f049aead96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151642 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#114441 Convert use of sal_uLong to sal_uInt32mostafa-elsharnoby2023-05-081-1/+1
| | | | | | | | | | Replaced sal_uLong with sal_uInt32 because implementation of the GetValue() returns sal_uInt32. Change-Id: I6e4d9b3f4854da0c60d7ba32b688106639362adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146821 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
* Run clang-tidy with misc-unused-using-decls on modules [a-c]*Gabor Kelemen2023-04-204-6/+0
| | | | | | | | | | | | | | | To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: I95871cc0ae6f22a9684bae9d14ef0475aea17abb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150608 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* jsdialog: enable and make async chart line prop dialogSzymon Kłos2023-04-041-34/+56
| | | | | | | | | Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
* Avoid conversions between OUString and OString in VCLMike Kaganski2023-04-028-10/+10
| | | | | | | | | | | | | Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* use more concrete types in chart2Noel Grandin2023-03-301-1/+1
| | | | | | | Change-Id: Iaefad282d40c83f58758b41db9b14f6e95552354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2Noel Grandin2023-03-291-4/+4
| | | | | | | Change-Id: I1ba60b690a0402d1a98f792c86ddd033e0c39ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149726 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* expand out ChartModelHelper::findDiagramNoel Grandin2023-03-2911-24/+24
| | | | | | | | | since it just calls findFirstChartDiagram Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in chart2Noel Grandin2023-03-291-2/+2
| | | | | | | Change-Id: I818253350bd954d3a2a0f302493c896eb2e26994 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move switchRightAngledAxes from ThreeDHelper to DiagramNoel Grandin2023-03-281-1/+2
| | | | | | | | | so we can use the get/setFastPropertyValue methods Change-Id: Id17fa2466f75a3b4530306143ce50f66fc5593b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149651 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move get/setScheme from ThreeDHelper to DiagramNoel Grandin2023-03-284-11/+11
| | | | | | | | | so we can use the get/setFastPropertyValue methods Change-Id: I2b57212a1d3933cd2825e647f692e2ae3cb8b484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move get/setRotation from ThreeDHelper to DiagramNoel Grandin2023-03-281-2/+2
| | | | | | | | | so we can use the get/setFastPropertyValue methods Change-Id: I147ed5c092b44283bfbbf4ea5a3145736417b92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete type in chart2Noel Grandin2023-03-222-5/+5
| | | | | | | Change-Id: If67a4f0fe75554e14c3030c68374607b76d5b840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete type in chart2Noel Grandin2023-03-222-5/+3
| | | | | | | Change-Id: I33deb726da5a59093b1104696da7c80ce830b7e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149335 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete type in chart2Noel Grandin2023-03-222-2/+2
| | | | | | | Change-Id: I0ed45cf9acd1c9bf702bbe335f8a07b6947fb946 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getLabel inside chart2::DataSeriesNoel Grandin2023-03-214-13/+10
| | | | | | | Change-Id: I38baff5980d8cae5f63ee9163d667385837d249b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getTemplate inside chart2::DiagramNoel Grandin2023-03-214-10/+8
| | | | | | | Change-Id: I05da4e4a9acb2683633eda42cf18d740913c2e37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move setDimension/getDimension inside chart2::DiagramNoel Grandin2023-03-201-1/+3
| | | | | | | Change-Id: If52f92e152011ead81a1b25f30ba15124e6a8e75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getAttachedAxis inside chart2::DiagramNoel Grandin2023-03-201-1/+1
| | | | | | | Change-Id: I520633863103a966f1836b4473bc6be32a134ac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getChartTypeOfSeries inside chart2::DiagramNoel Grandin2023-03-202-2/+2
| | | | | | | Change-Id: I496b180c1e7d6641760251186357d2b11f4434ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149089 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getDataSeries inside chart2::DiagramNoel Grandin2023-03-192-3/+3
| | | | | | | Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move isCategory inside chart2::DiagramNoel Grandin2023-03-182-2/+2
| | | | | | | Change-Id: I568a573004c20d7bbf60a947b34a6a8223217b19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getCategories/setCategories inside chart2::DiagramNoel Grandin2023-03-181-2/+2
| | | | | | | Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getChartTypeByIndex inside chart2::DiagramNoel Grandin2023-03-173-3/+3
| | | | | | | Change-Id: Idff60dbd7c1cdb8c60e7ac07ad3abe3c6b07e321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149050 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move getChartTypes inside chart2::DiagramNoel Grandin2023-03-171-2/+2
| | | | | | | Change-Id: I43fd96feb1e3d34a5f3327b2e6398ca4b5e9f928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more concrete types in Diagram::moveSeriesNoel Grandin2023-03-172-2/+2
| | | | | | | Change-Id: Ic5bb7f36137afe112d1a542bd642355d996cf68c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149048 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* move isSeriesMoveable inside chart2::DiagramNoel Grandin2023-03-171-1/+1
| | | | | | | Change-Id: I119552a4f1300eafc8b060f567777a74dc11772f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149038 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#114441: Convert use of sal_uLong to better integer typesNirnayK2023-03-151-1/+1
| | | | | | | | | | | In tp_AxisPosition.cxx the sal_uLong has been changed to sal_uInt32 as the GetValue returns a 32 bit integer In outliner.cxx the sal_uLong is converted to sal_uInt64 as the the sum of 2 sal_uInt32 might exceed 32 bits Change-Id: I560faf952520078f6a0747dfdec8a3039927e5c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148335 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>