summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* update old 'interface-requires' comments to <requires> tagCaolán McNamara2018-10-28105-140/+141
| | | | | | | | Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#11125 pass param len aroundCaolán McNamara2018-10-282-11/+38
| | | | | | | | Change-Id: I4b382271df21c58de0e102af6e0b07a88a1d9610 Reviewed-on: https://gerrit.libreoffice.org/62443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#120703 PVS: V547 Fix activation of launched process' windowMike Kaganski2018-10-281-14/+35
| | | | | | | | | | | | | | | | | | | V547 Expression 'procHandle != nullptr' is always false. The code was nonsensical overall. First, the launched process handle was never returned by ShellExecuteExW, because SEE_MASK_NOCLOSEPROCESS wasn't used, so GetProcessId couldn't succeed. Then, nullptr window handle was passed to GetWindowThreadProcessId, thus never returning a meaningful result. This reimplements this to find the launched process' main window by first waiting for process idle (up to 1-second delay is possible), then enumerating all the top-level windows and checking their process. Change-Id: I5fb4c04147b3f9414e27650a023f7844523c18bd Reviewed-on: https://gerrit.libreoffice.org/62478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Fix Sidebar docking key regressionJim Raykowski2018-10-281-13/+17
| | | | | | | | | | Add back Ctrl+Shift+F10 undocking/docking handling. This regression was introduced by me in tdf#115434 Fix key press misbehaviors in sidebar. Change-Id: I29a563b2eb96be8a6b346454fddc1605dbc4aba6 Reviewed-on: https://gerrit.libreoffice.org/62268 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
* Update git submodulesAdolfo Jayme Barrientos2018-10-281-0/+0
| | | | | | | | | | | * Update helpcontent2 from branch 'master' - The Bibliography Database window no longer has an Insert menu Change-Id: I07f85db5cd175c9941408c91ec68c70efcdba3da - Grammar Change-Id: I3d3bc317afd35bce5c941144417b7222e9063ae8
* check-elf-dynamic-objects: allow extending the whitelist via env-varChristian Lohmaier2018-10-281-1/+3
| | | | | | | | | to allow working on packaging with epm without a baseline setup... Change-Id: I9ab737cd52adf51c9eb23a4bc67f09c0ac06647e Reviewed-on: https://gerrit.libreoffice.org/62454 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* sw toolbars sync context toolbars between different appsandreas kainz2018-10-2818-223/+390
| | | | | | | Change-Id: Ib70cbcb392391c732f9d15a26722cf0dbdb8a56f Reviewed-on: https://gerrit.libreoffice.org/62477 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* Fix typoAndrea Gelmini2018-10-281-1/+1
| | | | | | | Change-Id: I05f36d03acaabb92b212b8fc3ef30850e1179935 Reviewed-on: https://gerrit.libreoffice.org/62467 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-289-293/+249
| | | | | | | Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#119410 Menubar sw: combine mirror and rotateandreas kainz2018-10-286-42/+30
| | | | | | | Change-Id: Id71b22d81f6aee26239f7311031fc63523c7dec5 Reviewed-on: https://gerrit.libreoffice.org/62473 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* elementary: Refix for tdf#119731, update presentation/slide related icons, ↵Rizal Muttaqin2018-10-28296-882/+1195
| | | | | | | | | add envelope, etc Change-Id: Iae01c3e889ea38034332fc29e4cc397941930ac1 Reviewed-on: https://gerrit.libreoffice.org/62466 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* Fix typoAndrea Gelmini2018-10-281-1/+1
| | | | | | | Change-Id: I66a262953665cdb201bb06ddb3dc4bcd751119ed Reviewed-on: https://gerrit.libreoffice.org/62468 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-285-83/+65
| | | | | | | Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb Reviewed-on: https://gerrit.libreoffice.org/62465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* svx: remove newly unused XFillExchangeDataMichael Stahl2018-10-2810-201/+0
| | | | | | | Change-Id: I0260504ba108421e82ad50f9680dda9a05710678 Reviewed-on: https://gerrit.libreoffice.org/62456 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl2018-10-285-39/+52
| | | | | | | | | | | | | | | | | | | This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
* tdf#115296 extend vertical FrameBorders for joined FramesArmin Le Grand2018-10-281-2/+18
| | | | | | | | | | | This feature was lost on my changes for FrameBorder primitive creation. It was calculated/applied formally in lcl_PaintLeftRightLine Change-Id: Ie44619a4c4e44ff4584533685cb21882c323742e Reviewed-on: https://gerrit.libreoffice.org/62451 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-286-160/+112
| | | | | | | Change-Id: I1e5098e11f1e5e2f7c5518ea05c57512f58b585b Reviewed-on: https://gerrit.libreoffice.org/62464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#119773 update sd table context menuandreas kainz2018-10-284-99/+61
| | | | | | | Change-Id: Ib85e6a3be4f2771b9772751d6526e8f278bb0a40 Reviewed-on: https://gerrit.libreoffice.org/62240 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* contect menu sw drawtext remove OpenHyperlinkOnCursorandreas kainz2018-10-285-5/+0
| | | | | | | Change-Id: I4fd53ea430e04f89e14efa20d98faa5dfbc8cda9 Reviewed-on: https://gerrit.libreoffice.org/62447 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-282-36/+24
| | | | | | | Change-Id: Ieb48a5fd29f78d2e39e1d91448f3ce973aff93d9 Reviewed-on: https://gerrit.libreoffice.org/62463 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-281-54/+49
| | | | | | | | | | Fixed the logic broken since commit 5d64757c7a5df2d3cb9b36d18f44932df15e5b3f with what seems to be the original idea. Change-Id: I1a25cfb27d7d9a1af4e024c2989ea4959014455f Reviewed-on: https://gerrit.libreoffice.org/62462 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-10-2821-134/+58
| | | | | | | Change-Id: Ic92cc594979cac2edac04a085957398672a5dfcc Reviewed-on: https://gerrit.libreoffice.org/62450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Fix typosAndrea Gelmini2018-10-282-2/+2
| | | | | | | Change-Id: I4a718b73adcfa0871b94dde92c047593640350a4 Reviewed-on: https://gerrit.libreoffice.org/62458 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#120703 PVS: V547 Expression '!pTmp' is always trueMike Kaganski2018-10-281-10/+5
| | | | | | | Change-Id: Ia31961d65592ebd2718446eaa931aab785b8ba65 Reviewed-on: https://gerrit.libreoffice.org/62457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#119209: Windows share has inappropriate server suggestionXisco Fauli2018-10-282-1/+8
| | | | | | | | | Follow the same logic as HostDetailsContainer Change-Id: I3de8b2fc07b9caef6b4d20ab89242137d738c522 Reviewed-on: https://gerrit.libreoffice.org/60732 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#42982: added description on RuntimeExceptionIzabela Bakollari2018-10-271-7/+11
| | | | | | | Change-Id: I4d76117d4cbef19a8c68fecb882fcaef4c97efba Reviewed-on: https://gerrit.libreoffice.org/62434 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
* tdf#120376 sd: fix duplicated styles on copy/pasteMichael Stahl2018-10-271-2/+3
| | | | | | | | | | | | Unfortunately the comparison was inverted, so a style is copied iff it already exists, which is clearly the reviewer's fault... (regression from 57db6e24b5ad43d447c30e44a112c74c7e75b46b) Change-Id: I3425982feb08e980eca9243cc16120897b65a70f Reviewed-on: https://gerrit.libreoffice.org/62436 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* tdf#108751 Show currently selected color name in color button tooltipJim Raykowski2018-10-2710-25/+61
| | | | | | | | | | | Based on Heiko Tietze's work in I26f0500527d2b86049948ca64e636e1ff566f262 Change-Id: I20541dd6ad155a39c0f87361088b44923406064f Reviewed-on: https://gerrit.libreoffice.org/61815 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
* elementary: fix for tdf#120831 & tdf#120300, related to tdf#119731, etcRizal Muttaqin2018-10-27132-314/+157
| | | | | | | Change-Id: Ib6f9c3467578ebc68b3a15f8dbea4054af45707e Reviewed-on: https://gerrit.libreoffice.org/62416 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* merge SchTitleResources/TitleResources back togetherCaolán McNamara2018-10-274-102/+2
| | | | | | | | Change-Id: I4c7ff790b2b6d76a96a5d54f1537fa051beac7d1 Reviewed-on: https://gerrit.libreoffice.org/62439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* merge SchLegendPositionResources/LegendPositionResources back togetherCaolán McNamara2018-10-275-176/+34
| | | | | | | | Change-Id: I53b5bc65313a6f5e661c3f6804db256d18037c74 Reviewed-on: https://gerrit.libreoffice.org/62437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* missing OPageNumberDialog runCaolán McNamara2018-10-272-1/+52
| | | | | | | | Change-Id: I0e21f90e9cfd4e1ee6ced6108ab6619533ab8dda Reviewed-on: https://gerrit.libreoffice.org/62438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#119773 update sw table context barandreas kainz2018-10-277-118/+373
| | | | | | | Change-Id: I7648db3fd775eab2067c89932c6f111c45fac554 Reviewed-on: https://gerrit.libreoffice.org/62239 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* sw text context menu sync between different sw appsandreas kainz2018-10-276-80/+268
| | | | | | | | | tiny change in text context menu for writer Change-Id: I1c18f505b13a210c6e8544d9e0f20556fac97bdb Reviewed-on: https://gerrit.libreoffice.org/62242 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
* possible fix for issue 120928 - quickstart --killtray throws exceptionbrinzing2018-10-271-1/+1
| | | | | | | Change-Id: Id4081439075f4beecc2b0e4aed035d5ee28a2cfd Reviewed-on: https://gerrit.libreoffice.org/62429 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
* loplugin:unusedmethodsNoel Grandin2018-10-2715-497/+212
| | | | | | | | Change-Id: I66ef078794ed1eb44dbfa854c589545e5f9ba78e Reviewed-on: https://gerrit.libreoffice.org/62407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* uitest Calc signature lineZdeněk Crhonek2018-10-273-0/+104
| | | | | | | Change-Id: I249c843f89ed5fe1d413f17fa57671d4ef9c69b2 Reviewed-on: https://gerrit.libreoffice.org/62404 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#120703 PVS: V724Mike Kaganski2018-10-271-2/+1
| | | | | | | | | | V724 Converting type 'int' to type 'sal_Bool' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Change-Id: I26540aa9fa9390e1990e95d81665567cd0a248b5 Reviewed-on: https://gerrit.libreoffice.org/62426 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* simplify personas generation by using a single templateChristian Lohmaier2018-10-278-114/+16
| | | | | | | Change-Id: I127181fff198dd865d0d958675db7446c73d09d0 Reviewed-on: https://gerrit.libreoffice.org/62427 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
* tdf#120703 PVS: V668Mike Kaganski2018-10-271-6/+2
| | | | | | | | | | | V668 There is no sense in testing the 'pProc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. Change-Id: Iec65fd44fa947a2402da33510c29730a46c2e1a4 Reviewed-on: https://gerrit.libreoffice.org/62424 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorIzabela Bakollari2018-10-271-5/+4
| | | | | | | | Change-Id: Ifc9fcc718b318c439484a6cc98a4e71c8d445fd8 Reviewed-on: https://gerrit.libreoffice.org/62417 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins
* tdf#80646 insert LTR mark after labelAndras Timar2018-10-271-0/+2
| | | | | | | Change-Id: Idb60b43bd04ab9e7c75c144ebf2b1626e13d34b6 Reviewed-on: https://gerrit.libreoffice.org/62418 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* tdf#99469 remove obsolete BlockList.xml entriesAndras Timar2018-10-2741-178/+0
| | | | | | | Change-Id: I88bd4777e973b43edfc7e6d1123cef5c6bb2d7ea Reviewed-on: https://gerrit.libreoffice.org/62423 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* tdf#120703 PVS: variable is assigned values twice successivelyMike Kaganski2018-10-271-1/+0
| | | | | | | | | | V519 The 'aToken.aText' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1147, 1163. Change-Id: I9bcb9a302a182932d7b15f25ee64005158d50a46 Reviewed-on: https://gerrit.libreoffice.org/62422 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: variable is assigned values twice successivelyMike Kaganski2018-10-271-1/+5
| | | | | | | | | | V519 The 'mbDesignMode' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 731, 737. Change-Id: I20cb70e050f194e7ab02de92dff4db35cade7386 Reviewed-on: https://gerrit.libreoffice.org/62421 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* pocheck: don't choke on plural formsChristian Lohmaier2018-10-271-2/+25
| | | | | | | Change-Id: I51a82ce5fc09d44ebc6f7c06c67b475ee2adf68b Reviewed-on: https://gerrit.libreoffice.org/62419 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
* tdf#120703 PVS: V519 variable is assigned values twice successivelyMike Kaganski2018-10-271-5/+0
| | | | | | | | | | | | V519 The 'm_nFetchDirectionPropertyHandle' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 489, 493. It was this way since 2000 (commit d3329bacd8a925ec070ad06ea3d9a6a026a3696b) Change-Id: Ia6ade4355bbfac799f8b32069f27a0c439300030 Reviewed-on: https://gerrit.libreoffice.org/62414 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* tdf#120703 PVS: V530 The return value of function is required to be utilizedMike Kaganski2018-10-279-13/+17
| | | | | | | Change-Id: Ifc170a45e25b3fd5b7f561cc50afb6452bb359bd Reviewed-on: https://gerrit.libreoffice.org/62420 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update git submodulesChristian Lohmaier2018-10-271-0/+0
| | | | | | | | | * Update translations from branch 'master' - update translations for master and force-fix errors using pocheck Change-Id: Ib2c4218faaa153151595024d052cc93d32037d4b
* uitest: integrate the calc input bar into the ui testingMarkus Mohrhard2018-10-271-0/+2
| | | | | | | Change-Id: Ib73d09b648c0663de57e4b205e7154d6af1366f8 Reviewed-on: https://gerrit.libreoffice.org/62412 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>