summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* convert RefDevMode to scoped enumNoel Grandin2016-09-018-35/+36
| | | | | | and fix the bForceZeroExtleadBug TODO Change-Id: Iac9295c6ce31112d69a870e3a229823eb1e9a4f2
* CppunitTest_sw_filters_test: fix ASan buildMiklos Vajna2016-09-011-1/+2
| | | | | | | | | | MaybeNotifyModification() should be called only in the POS_INSIDE case, not when POS_EQUAL gets there via the fallthrough. Change-Id: I8a05ee508a14f62b12e93799b2e98a33041d6f33 Reviewed-on: https://gerrit.libreoffice.org/28582 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Hide/Disable the Page property Panel for WriterSusobhan Ghosh2016-09-012-39/+1
| | | | | | | Change-Id: I3d8769f59811863ab38abeaefb289213d2c37570 Reviewed-on: https://gerrit.libreoffice.org/28379 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
* sw: remove the old calculator implementationMiklos Vajna2016-09-011-223/+0
| | | | | | | | | | It was disabled build-time + also one had to turn it on from a debugger, doesn't seem to be useful anymore. Change-Id: Id04a763e8dc9f09ce28374210da4ec39fbb2b3e1 Reviewed-on: https://gerrit.libreoffice.org/28579 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* fix non-debug enable-assert-always-abort buildCaolán McNamara2016-09-012-4/+3
| | | | Change-Id: Ie120e56339d263ef7e2e7f1bdd04da62726d046c
* sfx2: SfxCommonTemplateDialog_Impl can't even decide if...Michael Stahl2016-09-011-1/+1
| | | | | | ...no family selection should be represented as "0" or "0xffff". Change-Id: I08ef69bf35d130898cb995463dc29e72a372562c
* use SfxItemPool::IsWhich instead of custom implementationJochen Nitschke2016-09-018-18/+18
| | | | | | | Change-Id: I56cbdc1ede491486643f73a98117c5cd4ce77c1d Reviewed-on: https://gerrit.libreoffice.org/28564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some unnecessary global.hxx includesJochen Nitschke2016-09-015-5/+3
| | | | | | | Change-Id: I50afe36056d32352a1c3118bc445fd55bcf10b6e Reviewed-on: https://gerrit.libreoffice.org/28568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use IsStaticDefaultItem from poolitem.hxx instead of custom checksJochen Nitschke2016-09-012-3/+3
| | | | | | | Change-Id: Ic49a940d83e5b8944bd724203bb2045bb1eb22b9 Reviewed-on: https://gerrit.libreoffice.org/28567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use SfxItemPool::IsSlot instead of custom implementationJochen Nitschke2016-09-013-4/+4
| | | | | | | Change-Id: I435fb78f10f361120ee1865465dab93aa4661806 Reviewed-on: https://gerrit.libreoffice.org/28565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* avoid warning in PoolItemTestJochen Nitschke2016-09-012-28/+27
| | | | | | | | | | | | | > warn:legacy.tools:19758:1:svl/source/inc/poolio.hxx:139: > Start-Which-Id must be greater 0 adapt ID range in the test and leave usage comment in SfxItemPool ctor params Change-Id: I93150be8d3d1e330c6574b9f8d05b3b1ef2ffa43 Reviewed-on: https://gerrit.libreoffice.org/28570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* hide SFX_WHICH_MAX defineJochen Nitschke2016-09-011-2/+2
| | | | | | | Change-Id: I90ef9d3712847ce63b2bae206edcf859dbeeecbb Reviewed-on: https://gerrit.libreoffice.org/28566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparamsNoel Grandin2016-09-017-9/+8
| | | | | | | Change-Id: Icfc2fdde493619fefaf6119d366f8f7166b3ff36 Reviewed-on: https://gerrit.libreoffice.org/28547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Gallery submenu was missing from native menusMaxim Monastirsky2016-09-012-5/+3
| | | | | | | | | ... for both OS X and gtk3. The reason is that it was filled in item highlight handler, which isn't implemented for native menus. For now use the menu activation handler, like for the similar button in SvxLineTabPage. Change-Id: I437fd6536dbd9e6ba51282eaacc8b43c3a2d6cbf
* let's make Impress crash less - SfxStyleFamily editionMichael Stahl2016-08-319-54/+55
| | | | | | | | | | | | | | | | | | Commit bcb41235deaf4b7ca90522bda3ba21a686819e6e - in addition to introducing the enum SfxStyleFamily - inconsistently converted one call of DrawDocShell::SetStyleFamily to use enum SfxStyleFamily instead of a mysterious "5", but did not adapt all of the code that extracts the SfxUInt16Item that subsequently extracts this value and expects a number 0-5. Since it's clearly inexcusably stupid to have 2 different public sets of integers identifying styles, make the usage of the second "array index" integers private to templdlg.cxx; the SfxUInt16 item now always contains enum SfxStyleFamily. (regression from bcb41235deaf4b7ca90522bda3ba21a686819e6e) Change-Id: I333575c504277c2046f8f5a6b36ae3f86b3b3201
* add COVAR test caseZdeněk Crhonek2016-08-311-0/+3823
| | | | | | | Change-Id: I734d3a2b958a7d353e3b87db46793c836dbb0e27 Reviewed-on: https://gerrit.libreoffice.org/28563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COVARIANCE.S test caseZdeněk Crhonek2016-08-311-0/+3836
| | | | | | | Change-Id: Ib7f716c76ea9f56c70045b9b6cc2fcbd0cab8d77 Reviewed-on: https://gerrit.libreoffice.org/28560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add CONFIDENCE.T test caseZdeněk Crhonek2016-08-311-0/+3898
| | | | | | | Change-Id: Ibd7b84360a27642dc9f9210876f514e9dc109c2d Reviewed-on: https://gerrit.libreoffice.org/28562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COUNTIF test caseZdeněk Crhonek2016-08-311-0/+4472
| | | | | | | Change-Id: I5b4f961ff051ecbaf615d5584bb9964f05dc65fd Reviewed-on: https://gerrit.libreoffice.org/28559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Resolves tdf#100709 Optimize SheetDataBuffer::addColXfStyleMaarten Bosmans2016-08-311-35/+24
| | | | | | | | | | | | | The insertion of RowRanges into the sorted set was done by iterating through the set until the correct insertion point was found. By using set.lower_bound(), the complexity goes from O(N) to (log N) for a single insert. Regarding tdf#100709: the import time for the attached example document reduces by 12x. Change-Id: Ifb03d58a0e46a936ab61a5f0b512e956c87e5e2b Reviewed-on: https://gerrit.libreoffice.org/28510 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* tdf#101779 Allow multiline tooltips in template managerMaxim Monastirsky2016-08-312-0/+15
| | | | Change-Id: Ia3dc45fc35aeeabfabc119bb84847c479ed32fda
* Revert "tdf#101440 Better rendering of tooltip in gtk2 and windows"Maxim Monastirsky2016-08-311-1/+1
| | | | | | | | See tdf#101779 for a proper fix. This reverts commit c505ec78ddf97fbcb6e39b7865df5a455d41bf38. Change-Id: Ie825c1d2d8b4ab5696078da95c1b7f3fc699b2cb
* sfx2 lok: introduce SfxViewShell::NotifyCursor()Miklos Vajna2016-08-3110-20/+56
| | | | | | | | | | | | | | | | | | | | | | | | It allows removing the hide/show cursor hack in SfxViewShell::registerLibreOfficeKitViewCallback() introduced in commit 4d211384f048b689f20e46d4d586f342b110cb5c (sfx2 lok: fix missing view cursors in a new view, 2016-06-20), and instead let the application code in sw/sc/sd implement the best way to show existing cursors in a new view. This way the per-app cleanup of view cursors introduced in commit bc9b4fd4c83af3532204237157821d4884c42d8e (lok::Document::destroyView: clean up view cursors/selections, 2016-07-15) has matching per-app init code. This commit just adds the API + adapts existing sw code to use it, sc/sd still has to be implemented. Based on a patch by Marco Cecchetti, thanks! Change-Id: I38510fa4962f405b1b96a79024206c9e7f33cad2 Reviewed-on: https://gerrit.libreoffice.org/28557 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* use initializer list ctors for res typesJochen Nitschke2016-08-3119-62/+43
| | | | | | | | | | make nSize and nOffInstData const, let Size() return fixed sizes Change-Id: I7e2792e1cd990e65582020353054087f94856151 Reviewed-on: https://gerrit.libreoffice.org/28545 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* cppcheck:noConstructor for RscEnumerateObjJochen Nitschke2016-08-311-9/+14
| | | | | | | | | use initializer lists for ctors Change-Id: I1ac13d4178d070e02223cb70d8dc80d229a5fa7b Reviewed-on: https://gerrit.libreoffice.org/28543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* desktop: fix Android buildMiklos Vajna2016-08-311-0/+13
| | | | | | | to_string() is missing in the std namespace on the broken Android toolchain, work it around. Change-Id: I77fd06f869291e04c265b6b6d38b2e60b0d48caf
* Related: tdf#100709 Fix two bugs in SheetDataBuffer::addColXfStyleMaarten Bosmans2016-08-311-0/+6
| | | | | | | | | | | | | | | | | | | | The addColXfStyle method is supposed to add a formatId to all the cells in a specified CellRange where there is no previously set formatId in the maStylesPerColumn member variable. There where two bugs in this function: - If there is overlap between the row ranges already in maStylesPerColumnBB and the given RowRange, it should be updated to only cover non-overlapping cells. - In the case when the given CellRange spans multiple columns, the RowRange should be applied to all these columns. When the row range given to this method is changed because of earlier set RowRanges in maStylesPerColumn[nCol], the RowRange was not reset to the given method argument for a new column. Change-Id: I4244c4303ca983801c5116cbd26971dd641411ab Reviewed-on: https://gerrit.libreoffice.org/28509 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* tdf#96749: deal with missing custom headers/footers in docxJulien Nabet2016-08-313-11/+38
| | | | | | | | | | | | | | | | | | | | Some custom headers and footers are referenced in docx but aren't present. See https://bugs.documentfoundation.org/show_bug.cgi?id=96749#c1 eg: warn:writerfilter:20417:1:writerfilter/source/filter/WriterFilter.cxx:214: WriterFilter::filter(): failed with exception Element does not exist and cannot be created: "header1.xml" See comment in bug: "The attached DOCX was generated by 1C:Enterprise -- extremely popular monopoly business CRM in Russia, with huge userbase (millions of installations)." This is apparently not a fatal condition in MS Word, so all we need to do is to return when we hit such a problem (resolveEmbeddingsStream is a recursive function). Change-Id: I0e085a5f07dc6cc044bbd713e8f81d67dbe5d8b2 Reviewed-on: https://gerrit.libreoffice.org/20993 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use range based loopsJochen Nitschke2016-08-311-34/+26
| | | | | | | | | clear of standard containers is superfluous in dtors Change-Id: I3dd482573100a67a931122670abdcc60b8521790 Reviewed-on: https://gerrit.libreoffice.org/28544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* slideshow: stop whining about PresenterCanvas' lack of XUpdatableMichael Stahl2016-08-311-3/+6
| | | | Change-Id: I1e447f5eccb41325d96e9c4cb1598a05e702badc
* sd: fix un-sorted SidArray in FuChar::DoExecute()Michael Stahl2016-08-311-1/+1
| | | | | | | | Triggers an assert in SfxBindings::Invalidate(). (regression from ecc7308efa973fd1f1985ff9a0a0f01414b73f2b) Change-Id: Ida5b6c006ef6b8a839962c4f09c8341eee980270
* add CORREL test caseZdeněk Crhonek2016-08-311-0/+5406
| | | | | | | Change-Id: Ifffb6e2ba2c9d7370d49799f4b741e8687ea69bb Reviewed-on: https://gerrit.libreoffice.org/28533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Resolves: tdf#100094 hyperlink tabpage put hyperlink name in wrong fieldCaolán McNamara2016-08-311-1/+1
| | | | | | | | | | | mismerge of commit 74593273655e475017bb2bd45aba3c6b132e372d Date: Thu Jan 9 12:59:28 2014 +0000 Resolves: #i123988# assure that hyperlink attribute... Change-Id: I45391b112666a07a0edfa49b2a8682c446a92cf4
* add COVARIANCE.P test caseZdeněk Crhonek2016-08-311-0/+3833
| | | | | | | Change-Id: I5e5fe6d302b46580048de69eeda3968981f322b5 Reviewed-on: https://gerrit.libreoffice.org/28527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add ERFC.PRECISE test caseZdeněk Crhonek2016-08-311-0/+3766
| | | | | | | Change-Id: I072ed4639feba9f6f32ee57e6425e6b2c0dde479 Reviewed-on: https://gerrit.libreoffice.org/28532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COUNTA test caseZdeněk Crhonek2016-08-311-0/+3486
| | | | | | | Change-Id: Ie86278cbcf11f5d4002a7345534ad9bc85ef7980 Reviewed-on: https://gerrit.libreoffice.org/28528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COUNT test caseZdeněk Crhonek2016-08-311-0/+3464
| | | | | | | Change-Id: I0709224de2735c9a1a0ea3c92d091145910ced3e Reviewed-on: https://gerrit.libreoffice.org/28531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COUNTIFS testcaseZdeněk Crhonek2016-08-311-0/+4567
| | | | | | | Change-Id: I367b1cd13175233a51e05844c0f6e3d1e7115afd Reviewed-on: https://gerrit.libreoffice.org/28530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* add COUNTBLANK test caseZdeněk Crhonek2016-08-311-0/+3386
| | | | | | | Change-Id: I2e220dd0e2b00a06e4fc3f06a5510961828929f5 Reviewed-on: https://gerrit.libreoffice.org/28529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#101810 - Crash when selecting Bibliography from ToolsNoel Grandin2016-08-311-0/+1
| | | | | | fallout from commit aa0d0536 "tdf#97527 - vcl: reference-count Menu" Change-Id: I996a5b739f35d034b15fd5d0b4c94fd57688bf12
* tdf#93333 in AutoCorrectDialog list also CJK languages if enabledSophie Su2016-08-311-0/+2
| | | | | | | Change-Id: If203511e6645848544895d2f0813f3f362a8e336 Reviewed-on: https://gerrit.libreoffice.org/28437 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* add spaces in warningCaolán McNamara2016-08-311-2/+2
| | | | | | | Change-Id: Id040cfdae4adf07492e5262e93336caf4396aa39 Reviewed-on: https://gerrit.libreoffice.org/28546 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cppcheck:assertWithSideEffectJochen Nitschke2016-08-311-2/+2
| | | | | | | Change-Id: Ib3d2bb85c925a4208a9e2f0032857a11258c3bb2 Reviewed-on: https://gerrit.libreoffice.org/28540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* convert LB_ constants to typed_flagsNoel Grandin2016-08-311-126/+133
| | | | Change-Id: I2293b0120bff73f51ed7ea4d12d5ef3eb1bcba81
* convert MOVE_ITEM constants to typed_flagsNoel Grandin2016-08-312-25/+34
| | | | Change-Id: I9be9226cbe9bf6b76df3132d1ed3f08ea65bf273
* convert SW_SERVICE constants to scoped enumNoel Grandin2016-08-318-677/+684
| | | | Change-Id: I731d93f9ab77e60880365c8e2f5e62221d8da5ad
* LOK: queue-up events while processing client callsAshod Nakashian2016-08-312-23/+65
| | | | | | | | | | | | | | | To prevent feedback effects and improve performance, we now queue up events fired during the processing of a client call on the LOK API. This has the advantage of giving us a chance to compress redundant events and to combine others (where possible) into fewer ones. Change-Id: I2f6ea12c5d85205e6495cb130f6a6262534b6bb2 Reviewed-on: https://gerrit.libreoffice.org/28311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:countusersofdefaultparamsNoel Grandin2016-08-3140-99/+98
| | | | | | | Change-Id: I697b9081424acdc61107709392baa8af8ce29028 Reviewed-on: https://gerrit.libreoffice.org/28497 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* lokdocview: handle empty LOK_CALLBACK_DOCUMENT_SIZE_CHANGED payloadMiklos Vajna2016-08-311-1/+5
| | | | | | | | | Calc omits the document size in the payload in several cases, and online.git handles that, so handle it in lokdocview as well for now, instead of fixing up all the sc code to always emit the doc size in the payload. Change-Id: Ib2cca1770d2a160e32540e3a3158eb00bf13207b
* opengl: remove unsused "bitmap ops" in GL backendTomaž Vajngerl2016-08-313-69/+2
| | | | | | | Change-Id: I188570d11349a5344753f3948daedf0e17806c6c Reviewed-on: https://gerrit.libreoffice.org/28536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>