diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-10-19 16:19:58 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-10-20 19:54:08 +0200 |
| commit | 5e8911efab74eb2519eb8ba8301b282b232c2d00 (patch) | |
| tree | 4e8f915e5405937fd26fb210c4c5f6d179eeb1c2 /xmlsecurity | |
| parent | pvs-studio: Expression '!bWasSetTypeAttribute' is always true. (diff) | |
| download | core-5e8911efab74eb2519eb8ba8301b282b232c2d00.tar.gz core-5e8911efab74eb2519eb8ba8301b282b232c2d00.zip | |
pvs-studio: A part of conditional expression is always true: bCertValid.
Change-Id: Ia70f28fece45c84b4a460e379c5447818818e114
Reviewed-on: https://gerrit.libreoffice.org/62054
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'xmlsecurity')
| -rw-r--r-- | xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx index 98f9bd1da127..689303e9355a 100644 --- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx +++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx @@ -645,20 +645,19 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox() // If there is no storage, then it's pointless to check storage // stream references. else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content - && bCertValid && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature( + && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature( maSignatureManager.maCurrentSignatureInformations[n]))) { aImage = m_pSigsNotvalidatedImg->GetImage(); bAllNewSignatures = false; } else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content - && bCertValid && DocumentSignatureHelper::isOOo3_2_Signature( + && DocumentSignatureHelper::isOOo3_2_Signature( maSignatureManager.maCurrentSignatureInformations[n])) { aImage = m_pSigsValidImg->GetImage(); } - else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros - && bCertValid) + else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros) { aImage = m_pSigsValidImg->GetImage(); } |