From 5e8911efab74eb2519eb8ba8301b282b232c2d00 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Fri, 19 Oct 2018 16:19:58 +0100 Subject: pvs-studio: A part of conditional expression is always true: bCertValid. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ia70f28fece45c84b4a460e379c5447818818e114 Reviewed-on: https://gerrit.libreoffice.org/62054 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'xmlsecurity') diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx index 98f9bd1da127..689303e9355a 100644 --- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx +++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx @@ -645,20 +645,19 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox() // If there is no storage, then it's pointless to check storage // stream references. else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content - && bCertValid && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature( + && (maSignatureManager.mxStore.is() && !DocumentSignatureHelper::isOOo3_2_Signature( maSignatureManager.maCurrentSignatureInformations[n]))) { aImage = m_pSigsNotvalidatedImg->GetImage(); bAllNewSignatures = false; } else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Content - && bCertValid && DocumentSignatureHelper::isOOo3_2_Signature( + && DocumentSignatureHelper::isOOo3_2_Signature( maSignatureManager.maCurrentSignatureInformations[n])) { aImage = m_pSigsValidImg->GetImage(); } - else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros - && bCertValid) + else if (maSignatureManager.meSignatureMode == DocumentSignatureMode::Macros) { aImage = m_pSigsValidImg->GetImage(); } -- cgit