diff options
author | Mike Kaganski <mike.kaganski@collabora.com> | 2024-07-28 01:16:00 +0500 |
---|---|---|
committer | Mike Kaganski <mike.kaganski@collabora.com> | 2024-07-28 01:14:42 +0200 |
commit | 233af54afb6e493c3538efe7c93d0f53f1b4c3ab (patch) | |
tree | f31908c2b29995e6ea7f0d51edb4877a2773ae54 /writerfilter/prj/build.lst | |
parent | sc: fix issues found by Ruff linter (diff) | |
download | core-master.tar.gz core-master.zip |
tdf#162219: pass correct DecimalDigits value to SQLBindParameter
HEADmaster
... when setting DECIMAL / NUMERIC.
Passing 'scale' from setObjectWithInfo to SQLBindParameter was wrong
anyway: in setObjectWithInfo, the scale is needed if it converts the
object 'x' to the requested format before sending to the database.
In this case, it mismatched with the actual count of decimals in the
string sent to ODBC: it could be "1" or "1.2"; but 'scale' is always
equal to the scale of the parameter in the database (4 in the bugdoc),
which resulted in the error returned by driver.
Note that there is code that truncates excessive decimals - it is in
OKeySet::impl_convertValue_throw, implemented for i#106772; it would
be best to remove that code, and let the database do its magic: e.g.,
passing a string like "1.99999" to a DECIMAL(19,4) field in MS SQL
Server would round it to 2, while our code truncates it to 1.9999.
The ODBC driver can handle more digits itself. But that isn't in the
scope here, and may need to tweak other database connectors.
Change-Id: Ib50c6d78bfd0cbf5ecd59f46f300107076ec0037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171127
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'writerfilter/prj/build.lst')
0 files changed, 0 insertions, 0 deletions