diff options
| author | Miklos Vajna <vmiklos@collabora.com> | 2021-05-18 14:33:53 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-05-20 09:15:15 +0200 |
| commit | 3a86bbd5e06d0fb7c057c761e924111e6499d20e (patch) | |
| tree | 8dbb9e61a8ec40c25a8e29a330da0c1824edfa0f /sw/qa/core/txtnode/data/title-field-invalidate.fodt | |
| parent | We do want scripting on iOS, too (diff) | |
| download | core-co-6.4-39.tar.gz core-co-6.4-39.zip | |
sw: fix not needed invalidation of title field on each keypress
co-6.4-39
Type a character, SwDocShell::DoFlushDocInfo() is called because the
number of characters changed, and that rapaints all title fields.
This happens as SwFormatField::UpdateTextNode() calls
SwTextField::ExpandTextField() with bForceNotify=true, because that was
needed for conditional text in commit
cd94a84b89c476760ad74bf088a5d6f8ba4ce209 (125044: - use field's content
cache on <SwTxtFld> construction only, 2014-06-13).
Fix the problem by not forcing notifications for title fields in
SwFormatField::UpdateTextNode(): SwTextField::ExpandTextField() will
send a notification if the expend result differs without forcing as
well.
(cherry picked from commit 0a32630d11ebdb8b8218faa066c72582ef2f300d)
Conflicts:
sw/qa/core/txtnode/txtnode.cxx
sw/source/core/txtnode/atrfld.cxx
Change-Id: I5e46ab6aef33ff5e348d40b8644bcc9cf353c326
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115783
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sw/qa/core/txtnode/data/title-field-invalidate.fodt')
| -rw-r--r-- | sw/qa/core/txtnode/data/title-field-invalidate.fodt | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/sw/qa/core/txtnode/data/title-field-invalidate.fodt b/sw/qa/core/txtnode/data/title-field-invalidate.fodt new file mode 100644 index 000000000000..e47129538fa9 --- /dev/null +++ b/sw/qa/core/txtnode/data/title-field-invalidate.fodt @@ -0,0 +1,23 @@ +<?xml version="1.0" encoding="UTF-8"?> +<office:document xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" office:mimetype="application/vnd.oasis.opendocument.text"> + <office:meta> + <dc:title>mytitle</dc:title> + </office:meta> + <office:automatic-styles> + <style:page-layout style:name="pm1"> + <style:page-layout-properties fo:page-width="14.8cm" fo:page-height="21.0cm" fo:margin-top="2cm" fo:margin-bottom="2cm" fo:margin-left="2cm" fo:margin-right="2cm"/> + </style:page-layout> + </office:automatic-styles> + <office:master-styles> + <style:master-page style:name="Standard" style:display-name="Standard" style:page-layout-name="pm1" style:next-style-name="Standard"> + <style:footer> + <text:p><text:title>mytitle</text:title></text:p> + </style:footer> + </style:master-page> + </office:master-styles> + <office:body> + <office:text> + <text:p>body text</text:p> + </office:text> + </office:body> +</office:document> |