diff options
| author | Noel Grandin <noel@peralex.com> | 2015-07-03 11:31:14 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-07-06 07:04:50 +0000 |
| commit | e9c3583c2cc27fc88ee81047c236ec99dd51e8de (patch) | |
| tree | b3e8394ca1ec402a31b227339366fc790124c1f8 /sc/source/ui/dbgui/PivotLayoutTreeList.cxx | |
| parent | remove some unnecessary typedefs around uno::Reference (diff) | |
| download | core-e9c3583c2cc27fc88ee81047c236ec99dd51e8de.tar.gz core-e9c3583c2cc27fc88ee81047c236ec99dd51e8de.zip | |
improve the returnbyref loplugin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sc/source/ui/dbgui/PivotLayoutTreeList.cxx')
| -rw-r--r-- | sc/source/ui/dbgui/PivotLayoutTreeList.cxx | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx index b217aece02c3..30c42c5c65b8 100644 --- a/sc/source/ui/dbgui/PivotLayoutTreeList.cxx +++ b/sc/source/ui/dbgui/PivotLayoutTreeList.cxx @@ -49,9 +49,7 @@ bool ScPivotLayoutTreeList::DoubleClickHdl() return false; SCCOL nCurrentColumn = rCurrentFunctionData.mnCol; - ScDPLabelData* pCurrentLabelData = mpParent->GetLabelData(nCurrentColumn); - if (!pCurrentLabelData) - return false; + ScDPLabelData& rCurrentLabelData = mpParent->GetLabelData(nCurrentColumn); ScAbstractDialogFactory* pFactory = ScAbstractDialogFactory::Create(); @@ -59,11 +57,11 @@ bool ScPivotLayoutTreeList::DoubleClickHdl() mpParent->PushDataFieldNames(aDataFieldNames); boost::scoped_ptr<AbstractScDPSubtotalDlg> pDialog( - pFactory->CreateScDPSubtotalDlg(this, mpParent->maPivotTableObject, *pCurrentLabelData, rCurrentFunctionData, aDataFieldNames, true)); + pFactory->CreateScDPSubtotalDlg(this, mpParent->maPivotTableObject, rCurrentLabelData, rCurrentFunctionData, aDataFieldNames, true)); if (pDialog->Execute() == RET_OK) { - pDialog->FillLabelData(*pCurrentLabelData); + pDialog->FillLabelData(rCurrentLabelData); rCurrentFunctionData.mnFuncMask = pDialog->GetFuncMask(); } |