diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2022-01-15 13:50:26 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2022-01-15 15:58:07 +0100 |
| commit | 29bc12777ceffd00ed0ae103b8f2affa26897b4e (patch) | |
| tree | 137886309baa148e3e84646f89600c00dd37d0fe /lotuswordpro/source | |
| parent | use more concrete types in chart2, ChartView (diff) | |
| download | core-29bc12777ceffd00ed0ae103b8f2affa26897b4e.tar.gz core-29bc12777ceffd00ed0ae103b8f2affa26897b4e.zip | |
Let loplugin:nullptr look into template instantiations
It missed some occurrences of 0 when only looking into uninstantiated template
code, as Clang doesn't model them with an ImplicitCastExpr, even if the target
is known to be a (dependent) pointer type.
Looking into all template instantiations of course carries the risk that a given
use of 0 is meant to be interpreted as a pointer in some and as an integer in
other instantiations. But the only case where that happened in the current code
base is RegistryValueList::getElement (include/registry/registry.hxx), where {}
is arguably a better choice anyway. (And which would presumably also hold for
any future such cases.)
Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'lotuswordpro/source')
| -rw-r--r-- | lotuswordpro/source/filter/clone.hxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lotuswordpro/source/filter/clone.hxx b/lotuswordpro/source/filter/clone.hxx index a6747c005a86..fe4c6451989d 100644 --- a/lotuswordpro/source/filter/clone.hxx +++ b/lotuswordpro/source/filter/clone.hxx @@ -29,7 +29,7 @@ struct has_clone enum { - value = sizeof(check_sig<T>(0)) == sizeof(yes) + value = sizeof(check_sig<T>(nullptr)) == sizeof(yes) }; }; @@ -63,7 +63,7 @@ struct cloner<T, true> template<typename T> T* clone(T* const other) { - return other ? ::detail::cloner<T, ::detail::has_clone<T>::value>::clone(other) : 0; + return other ? ::detail::cloner<T, ::detail::has_clone<T>::value>::clone(other) : nullptr; } #endif // INCLUDED_LOTUSWORDPRO_SOURCE_FILTER_CLONE_HXX |