diff options
| author | Noel Grandin <noel@peralex.com> | 2014-06-18 12:14:29 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-06-24 11:34:21 +0200 |
| commit | e2080e70fe8b085f18e868e46340454720fa94ca (patch) | |
| tree | 4038d1d57b41b68a47d5ebbbe6ad390648ec6303 /lotuswordpro/source/filter/utlist.cxx | |
| parent | Translated German comments - correction (diff) | |
| download | core-e2080e70fe8b085f18e868e46340454720fa94ca.tar.gz core-e2080e70fe8b085f18e868e46340454720fa94ca.zip | |
new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
Diffstat (limited to 'lotuswordpro/source/filter/utlist.cxx')
| -rw-r--r-- | lotuswordpro/source/filter/utlist.cxx | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/lotuswordpro/source/filter/utlist.cxx b/lotuswordpro/source/filter/utlist.cxx index 11d5bf04f107..9825cbf0baa9 100644 --- a/lotuswordpro/source/filter/utlist.cxx +++ b/lotuswordpro/source/filter/utlist.cxx @@ -77,15 +77,15 @@ CUtListElmt::~CUtListElmt() CUtList::~CUtList() { - pCUtListElmt pTerminating = GetTerminating(); - for (pCUtListElmt pCurr = GetFirst(); pCurr != pTerminating; ) + CUtListElmt& rTerminating = GetTerminating(); + for (pCUtListElmt pCurr = GetFirst(); pCurr != &rTerminating; ) { pCUtListElmt pNext = pCurr->GetNext(); pCurr->MakeNotOnList(); pCurr = pNext; } - pTerminating->SetPrev(pTerminating); - pTerminating->SetNext(pTerminating); + rTerminating.SetPrev(&rTerminating); + rTerminating.SetNext(&rTerminating); } // If pCurr is NULL, returns first item in list. Otherwise, returns item @@ -99,7 +99,7 @@ CUtList::GetNextOrNULL(pCUtListElmt pCurr) if (pCurr == NULL) pNext = GetFirst(); else pNext = pCurr->GetNext(); - if (pNext == GetTerminating()) + if (pNext == &GetTerminating()) pNext = NULL; return pNext; } @@ -107,8 +107,8 @@ CUtList::GetNextOrNULL(pCUtListElmt pCurr) void CUtList::Destroy() { - pCUtListElmt pTerminating = GetTerminating(); - for (pCUtListElmt pCurr = GetFirst(); pCurr != pTerminating; ) + CUtListElmt& rTerminating = GetTerminating(); + for (pCUtListElmt pCurr = GetFirst(); pCurr != &rTerminating; ) { pCUtListElmt pNext = pCurr->GetNext(); delete pCurr; |