diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-12-11 17:44:34 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-12-11 21:25:10 +0100 |
| commit | 35e471bb4d1388cf5afcdcee214cf5111edf44e3 (patch) | |
| tree | bb78f4f13f131f0cb206a9707cc3cfc495a3876a /include/test | |
| parent | align anchor south-west to dropdown north-east (diff) | |
| download | core-35e471bb4d1388cf5afcdcee214cf5111edf44e3.tar.gz core-35e471bb4d1388cf5afcdcee214cf5111edf44e3.zip | |
Adapt the remaining OUString functions to std string_view
...for LIBO_INTERNAL_ONLY. These had been missed by
1b43cceaea2084a0489db68cd0113508f34b6643 "Make many OUString functions take
std::u16string_view parameters" because they did not match the multi-overload
pattern that was addressed there, but they nevertheless benefit from being
changed just as well (witness e.g. the various resulting changes from copy() to
subView()).
This showed a conversion from OStringChar to std::string_view to be missing
(while the corresponding conversion form OUStringChar to std::u16string_view was
already present).
The improvement to loplugin:stringadd became necessary to fix
> [CPT] compilerplugins/clang/test/stringadd.cxx
> error: 'error' diagnostics expected but not seen:
> File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 43 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:42): simplify by merging with the preceding assignment [loplugin:stringadd]
> File ~/lo/core/compilerplugins/clang/test/stringadd.cxx Line 61 (directive at ~/lo/core/compilerplugins/clang/test/stringadd.cxx:60): simplify by merging with the preceding assignment [loplugin:stringadd]
> 2 errors generated.
Change-Id: Ie40de0616a66e60e289c1af0ca60aed6f9ecc279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107602
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'include/test')
| -rw-r--r-- | include/test/screenshot_test.hxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/test/screenshot_test.hxx b/include/test/screenshot_test.hxx index 9acee7a5d656..2c0bbe25eb23 100644 --- a/include/test/screenshot_test.hxx +++ b/include/test/screenshot_test.hxx @@ -18,6 +18,7 @@ #include <vcl/vclptr.hxx> #include <vcl/weld.hxx> #include <map> +#include <string_view> class VclAbstractDialog; typedef std::map<OString, sal_uInt32> mapType; @@ -70,7 +71,7 @@ public: /// This should be used with care - no active layouting will be done, only the /// VclBuilder will be activated for layouting. Result can thus vary drastically /// compared to the active dialog (can be compared with dialog previewer) - void dumpDialogToPath(const OString& rUIXMLDescription); + void dumpDialogToPath(std::string_view rUIXMLDescription); /// helper to process all known dialogs void processAllKnownDialogs(); |