diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-07-03 09:10:17 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-07-03 13:11:58 +0200 |
| commit | 2617def8d1430e093f6a482a72727b2965a8a8a6 (patch) | |
| tree | f05a609146b860990646647430814425254001b1 /hwpfilter/source/hwpfile.h | |
| parent | Use gb_CppunitTest_use_executable (diff) | |
| download | core-2617def8d1430e093f6a482a72727b2965a8a8a6.tar.gz core-2617def8d1430e093f6a482a72727b2965a8a8a6.zip | |
Fix (harmless) stack-use-after-return
...as reported by -fsanitize=address CppunitTest_hwpfilter_test_hwpfilter, where
stack-local HStream stream from HwpReader::filter is still referenced from
HStreamIODev in
HStreamIODev::close
HStreamIODev::~HStreamIODev
HWPFile::~HWPFile
HwpReader::~HwpReader
which is only harmless because HStream::closeInput is a nop.
Change-Id: Idbc5539ab5f463ec6d5d72f428ce60327ebdb063
Diffstat (limited to 'hwpfilter/source/hwpfile.h')
| -rw-r--r-- | hwpfilter/source/hwpfile.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h index f812f81c455f..82ba103a991e 100644 --- a/hwpfilter/source/hwpfile.h +++ b/hwpfilter/source/hwpfile.h @@ -110,7 +110,7 @@ class DLLEXPORT HWPFile * @returns 0 if success, otherwise error code * @see State() */ - int Open( HStream & ); + int Open( HStream * ); /** * Say current state @@ -170,7 +170,7 @@ class DLLEXPORT HWPFile /** * Reads all information of hwp file from stream */ - int ReadHwpFile( HStream &); + int ReadHwpFile( HStream *); /** * Reads document information of hwp file from HIODev */ |