clang:optin.performance.Padding

Excessive padding in 'struct ValueSetItem' (8 padding bytes, where 0 is
optimal).
Excessive padding in 'struct framework::CommandInfo' (12 padding bytes,
where 4 is optimal). Optimal fields order: aIds, nId, nImageInfo,
consider reordering the fields or adding explicit padding members
[optin.performance.Padding]
Excessive padding in 'class
drawinglayer::attribute::ImpFillGradientAttribute' (10 padding bytes,
where 2 is optimal).
Excessive padding in 'class
drawinglayer::attribute::ImpSdrLineAttribute' (8 padding bytes, where 0
is optimal).

Change-Id: I606f2bfc2c0c51b386182b900401dd15b5404451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121938
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 16 insertions, 16 deletions

diff --git a/drawinglayer/source/attribute/fillgradientattribute.cxx b/drawinglayer/source/attribute/fillgradientattribute.cxx
index 1d3a67b02a7a..0e42954e35e6 100644
--- a/drawinglayer/source/attribute/fillgradientattribute.cxx
+++ b/drawinglayer/source/attribute/fillgradientattribute.cxx
@@ -28,13 +28,13 @@ namespace drawinglayer::attribute
         {
         public:
             // data definitions
-            GradientStyle                           meStyle;
             double                                  mfBorder;
             double                                  mfOffsetX;
             double                                  mfOffsetY;
             double                                  mfAngle;
             basegfx::BColor                         maStartColor;
             basegfx::BColor                         maEndColor;
+            GradientStyle                           meStyle;
             sal_uInt16                              mnSteps;
 
             ImpFillGradientAttribute(
@@ -46,23 +46,23 @@ namespace drawinglayer::attribute
                 const basegfx::BColor& rStartColor,
                 const basegfx::BColor& rEndColor,
                 sal_uInt16 nSteps)
-            :   meStyle(eStyle),
-                mfBorder(fBorder),
+            :   mfBorder(fBorder),
                 mfOffsetX(fOffsetX),
                 mfOffsetY(fOffsetY),
                 mfAngle(fAngle),
                 maStartColor(rStartColor),
                 maEndColor(rEndColor),
+                meStyle(eStyle),
                 mnSteps(nSteps)
             {
             }
 
             ImpFillGradientAttribute()
-            :   meStyle(GradientStyle::Linear),
-                mfBorder(0.0),
+            :   mfBorder(0.0),
                 mfOffsetX(0.0),
                 mfOffsetY(0.0),
                 mfAngle(0.0),
+                meStyle(GradientStyle::Linear),
                 mnSteps(0)
             {
             }
diff --git a/drawinglayer/source/attribute/sdrlineattribute.cxx b/drawinglayer/source/attribute/sdrlineattribute.cxx
index 3dd7e16d6ab6..217ed813cdcd 100644
--- a/drawinglayer/source/attribute/sdrlineattribute.cxx
+++ b/drawinglayer/source/attribute/sdrlineattribute.cxx
@@ -28,13 +28,13 @@ namespace drawinglayer::attribute
         {
         public:
             // line definitions
-            basegfx::B2DLineJoin                    meJoin;             // B2DLINEJOIN_* defines
             double                                  mfWidth;            // 1/100th mm, 0.0==hair
             double                                  mfTransparence;     // [0.0 .. 1.0], 0.0==no transp.
+            double                                  mfFullDotDashLen;   // sum of maDotDashArray (for convenience)
             basegfx::BColor                         maColor;            // color of line
+            std::vector< double >                   maDotDashArray;     // array of double which defines the dot-dash pattern
+            basegfx::B2DLineJoin                    meJoin;             // B2DLINEJOIN_* defines
             css::drawing::LineCap                   meCap;              // BUTT, ROUND, or SQUARE
-            std::vector< double >                 maDotDashArray;     // array of double which defines the dot-dash pattern
-            double                                  mfFullDotDashLen;   // sum of maDotDashArray (for convenience)
 
             ImpSdrLineAttribute(
                 basegfx::B2DLineJoin eJoin,
@@ -44,22 +44,22 @@ namespace drawinglayer::attribute
                 css::drawing::LineCap eCap,
                 const std::vector< double >& rDotDashArray,
                 double fFullDotDashLen)
-            :   meJoin(eJoin),
-                mfWidth(fWidth),
+            :   mfWidth(fWidth),
                 mfTransparence(fTransparence),
+                mfFullDotDashLen(fFullDotDashLen),
                 maColor(rColor),
-                meCap(eCap),
                 maDotDashArray(rDotDashArray),
-                mfFullDotDashLen(fFullDotDashLen)
+                meJoin(eJoin),
+                meCap(eCap)
             {
             }
 
             ImpSdrLineAttribute()
-            :   meJoin(basegfx::B2DLineJoin::Round),
-                mfWidth(0.0),
+            :   mfWidth(0.0),
                 mfTransparence(0.0),
-                meCap(css::drawing::LineCap_BUTT),
-                mfFullDotDashLen(0.0)
+                mfFullDotDashLen(0.0),
+                meJoin(basegfx::B2DLineJoin::Round),
+                meCap(css::drawing::LineCap_BUTT)
             {
             }