clang-tidy:readability-redundant-member-init

Change-Id: I5e8baec88d5f17ddda452bd945c87769623cb4e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121357
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 5 insertions, 18 deletions

diff --git a/chart2/source/controller/dialogs/ChartResourceGroups.cxx b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
index bc1ccc81e7c9..19534aa1e0b0 100644
--- a/chart2/source/controller/dialogs/ChartResourceGroups.cxx
+++ b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
@@ -29,8 +29,7 @@ using namespace ::com::sun::star;
 using namespace ::com::sun::star::chart2;
 
 Dim3DLookResourceGroup::Dim3DLookResourceGroup(weld::Builder* pBuilder)
-    : ChangingResource()
-    , m_xCB_3DLook(pBuilder->weld_check_button("3dlook"))
+    : m_xCB_3DLook(pBuilder->weld_check_button("3dlook"))
     , m_xLB_Scheme(pBuilder->weld_combo_box("3dscheme"))
 {
     m_xCB_3DLook->connect_toggled(LINK(this, Dim3DLookResourceGroup, Dim3DLookCheckHdl));
@@ -88,8 +87,7 @@ IMPL_LINK_NOARG(Dim3DLookResourceGroup, SelectSchemeHdl, weld::ComboBox&, void)
 }
 
 SortByXValuesResourceGroup::SortByXValuesResourceGroup(weld::Builder* pBuilder)
-    : ChangingResource()
-    , m_xCB_XValueSorting(pBuilder->weld_check_button("sort"))
+    : m_xCB_XValueSorting(pBuilder->weld_check_button("sort"))
 {
     m_xCB_XValueSorting->connect_toggled(
         LINK(this, SortByXValuesResourceGroup, SortByXValuesCheckHdl));
@@ -117,8 +115,7 @@ IMPL_LINK_NOARG(SortByXValuesResourceGroup, SortByXValuesCheckHdl, weld::Togglea
 }
 
 StackingResourceGroup::StackingResourceGroup(weld::Builder* pBuilder)
-    : ChangingResource()
-    , m_xCB_Stacked(pBuilder->weld_check_button("stack"))
+    : m_xCB_Stacked(pBuilder->weld_check_button("stack"))
     , m_xRB_Stack_Y(pBuilder->weld_radio_button("ontop"))
     , m_xRB_Stack_Y_Percent(pBuilder->weld_radio_button("percent"))
     , m_xRB_Stack_Z(pBuilder->weld_radio_button("deep"))
@@ -200,8 +197,7 @@ IMPL_LINK_NOARG(StackingResourceGroup, StackingEnableHdl, weld::Toggleable&, voi
 }
 
 SplineResourceGroup::SplineResourceGroup(weld::Builder* pBuilder, weld::Window* pParent)
-    : ChangingResource()
-    , m_pParent(pParent)
+    : m_pParent(pParent)
     , m_xFT_LineType(pBuilder->weld_label("linetypeft"))
     , m_xLB_LineType(pBuilder->weld_combo_box("linetype"))
     , m_xPB_DetailsDialog(pBuilder->weld_button("properties"))
@@ -332,8 +328,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SteppedDetailsDialogHdl, weld::Button&, voi
 }
 
 GeometryResourceGroup::GeometryResourceGroup(weld::Builder* pBuilder)
-    : ChangingResource()
-    , m_aGeometryResources(pBuilder)
+    : m_aGeometryResources(pBuilder)
 {
     m_aGeometryResources.connect_changed(LINK(this, GeometryResourceGroup, GeometryChangeHdl));
 }
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index b0fda08c72f6..7286bccdc32f 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -367,7 +367,6 @@ void ChartTypeDialogController::setTemplateProperties( const uno::Reference< bea
 }
 
 ColumnOrBarChartDialogController_Base::ColumnOrBarChartDialogController_Base()
-                                        : ChartTypeDialogController()
 {
 }
 ColumnOrBarChartDialogController_Base::~ColumnOrBarChartDialogController_Base()
diff --git a/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx b/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
index 1215e7b40cdf..f64fc6fa11ff 100644
--- a/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
+++ b/chart2/source/controller/dialogs/TimerTriggeredControllerLock.cxx
@@ -28,8 +28,6 @@ using namespace ::com::sun::star;
 TimerTriggeredControllerLock::TimerTriggeredControllerLock(
     const uno::Reference<frame::XModel>& xModel)
     : m_xModel(xModel)
-    , m_apControllerLockGuard()
-    , m_aTimer()
 {
     m_aTimer.SetTimeout(4 * EDIT_UPDATEDATA_TIMEOUT);
     m_aTimer.SetInvokeHandler(LINK(this, TimerTriggeredControllerLock, TimerTimeout));
diff --git a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
index a6e2c38c6aa1..56e9c4611f24 100644
--- a/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
+++ b/chart2/source/controller/dialogs/dlg_ObjectProperties.cxx
@@ -82,7 +82,6 @@ ObjectPropertiesDialogParameter::ObjectPropertiesDialogParameter( const OUString
         : m_aObjectCID( rObjectCID )
         , m_eObjectType( ObjectIdentifier::getObjectType( m_aObjectCID ) )
         , m_bAffectsMultipleObjects(false)
-        , m_aLocalizedName()
         , m_bHasGeometryProperties(false)
         , m_bHasStatisticProperties(false)
         , m_bProvidesSecondaryYAxis(false)
@@ -100,7 +99,6 @@ ObjectPropertiesDialogParameter::ObjectPropertiesDialogParameter( const OUString
         , m_bShowAxisOrigin(false)
         , m_bIsCrossingAxisIsCategoryAxis(false)
         , m_bSupportingCategoryPositioning(false)
-        , m_aCategories()
         , m_bComplexCategoriesAxis( false )
         , m_nNbPoints( 0 )
 {
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
index c4b28162d08c..878f3fa0b204 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
@@ -67,7 +67,6 @@ struct LightSourceInfo
 
 LightSourceInfo::LightSourceInfo()
     : pButton(nullptr)
-    , aLightSource()
 {
     aLightSource.nDiffuseColor = Color(0xffffff); // white
     aLightSource.aDirection = drawing::Direction3D(1,1,1);
diff --git a/chart2/source/controller/dialogs/tp_AxisPositions.cxx b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
index d4e7fa218023..6812e9f94818 100644
--- a/chart2/source/controller/dialogs/tp_AxisPositions.cxx
+++ b/chart2/source/controller/dialogs/tp_AxisPositions.cxx
@@ -36,7 +36,6 @@ AxisPositionsTabPage::AxisPositionsTabPage(weld::Container* pPage, weld::DialogC
     : SfxTabPage(pPage, pController, "modules/schart/ui/tp_AxisPositions.ui", "tp_AxisPositions", &rInAttrs)
     , m_pNumFormatter(nullptr)
     , m_bCrossingAxisIsCategoryAxis(false)
-    , m_aCategories()
     , m_bSupportAxisPositioning(false)
     , m_bSupportCategoryPositioning(false)
     , m_xFL_AxisLine(m_xBuilder->weld_frame("FL_AXIS_LINE"))
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index e0ceccec2fe0..6ef5d45ddd40 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -64,7 +64,6 @@ RangeChooserTabPage::RangeChooserTabPage(weld::Container* pPage, weld::DialogCon
     : OWizardPage(pPage, pController, "modules/schart/ui/tp_RangeChooser.ui", "tp_RangeChooser")
     , m_nChangingControlCalls(0)
     , m_bIsDirty(false)
-    , m_aLastValidRangeString()
     , m_pTemplateProvider(pTemplateProvider)
     , m_rDialogModel( rDialogModel )
     , m_pTabPageNotifiable(dynamic_cast<TabPageNotifiable*>(pController))