diff --git a/core/fpdfdoc/cpdf_metadata.cpp b/core/fpdfdoc/cpdf_metadata.cpp index 323de4ffc..f11a0b0ad 100644 --- a/core/fpdfdoc/cpdf_metadata.cpp +++ b/core/fpdfdoc/cpdf_metadata.cpp @@ -74,7 +74,7 @@ std::vector CPDF_Metadata::CheckForSharedForm() const { CFX_XMLParser parser(stream); std::unique_ptr doc = parser.Parse(); if (!doc) - return {}; + return std::vector(); std::vector unsupported; CheckForSharedFormInternal(doc->GetRoot(), &unsupported); diff --git a/third_party/base/span.h b/third_party/base/span.h index 0fb627ba8..f71c362e2 100644 --- a/third_party/base/span.h +++ b/third_party/base/span.h @@ -214,7 +214,7 @@ class span { // Conversions from spans of compatible types: this allows a span to be // seamlessly used as a span, but not the other way around. template > - constexpr span(const span& other) : span(other.data(), other.size()) {} + span(const span& other) : span(other.data(), other.size()) {} span& operator=(const span& other) noexcept = default; ~span() noexcept { if (!size_) { diff --git a/third_party/base/span.h b/third_party/base/span.h index 0fb627ba8..dda1fc8bc 100644 --- a/third_party/base/span.h +++ b/third_party/base/span.h @@ -204,7 +204,7 @@ class span { // size()|. template > - constexpr span(Container& container) + span(Container& container) : span(container.data(), container.size()) {} template < typename Container, --- a/core/fxge/dib/cfx_cmyk_to_srgb.cpp 2020-09-10 17:32:37.165872018 +0200 +++ b/core/fxge/dib/cfx_cmyk_to_srgb.cpp 2020-09-10 17:33:15.870395738 +0200 @@ -1740,10 +1740,12 @@ uint8_t y1 = static_cast(y * 255.f + rounding_offset); uint8_t k1 = static_cast(k * 255.f + rounding_offset); +#ifndef _WIN32 DCHECK_EQ(c1, FXSYS_roundf(c * 255)); DCHECK_EQ(m1, FXSYS_roundf(m * 255)); DCHECK_EQ(y1, FXSYS_roundf(y * 255)); DCHECK_EQ(k1, FXSYS_roundf(k * 255)); +#endif uint8_t r; uint8_t g; diff --git a/core/fxcodec/jpx/cjpx_decoder.cpp b/core/fxcodec/jpx/cjpx_decoder.cpp index c66985a7f..817f81dfa 100644 --- a/core/fxcodec/jpx/cjpx_decoder.cpp +++ b/core/fxcodec/jpx/cjpx_decoder.cpp @@ -71,7 +71,7 @@ Optional alloc_rgb(size_t size) { if (!data.b) return pdfium::nullopt; - return data; + return std::move(data); } void sycc_to_rgb(int offset, diff --git a/core/fdrm/fx_crypt_aes.cpp b/core/fdrm/fx_crypt_aes.cpp index f2170220b..ede18f581 100644 --- a/core/fdrm/fx_crypt_aes.cpp +++ b/core/fdrm/fx_crypt_aes.cpp @@ -437,7 +437,7 @@ const unsigned int D3[256] = { (block[0] ^= *keysched++, block[1] ^= *keysched++, block[2] ^= *keysched++, \ block[3] ^= *keysched++) #define MOVEWORD(i) (block[i] = newstate[i]) -#define MAKEWORD(i) \ +#define FMAKEWORD(i) \ (newstate[i] = (E0[(block[i] >> 24) & 0xFF] ^ \ E1[(block[(i + C1) % Nb] >> 16) & 0xFF] ^ \ E2[(block[(i + C2) % Nb] >> 8) & 0xFF] ^ \ @@ -458,10 +458,10 @@ void aes_encrypt_nb_4(CRYPT_aes_context* ctx, unsigned int* block) { unsigned int newstate[4]; for (i = 0; i < ctx->Nr - 1; i++) { ADD_ROUND_KEY_4(); - MAKEWORD(0); - MAKEWORD(1); - MAKEWORD(2); - MAKEWORD(3); + FMAKEWORD(0); + FMAKEWORD(1); + FMAKEWORD(2); + FMAKEWORD(3); MOVEWORD(0); MOVEWORD(1); MOVEWORD(2); @@ -478,10 +478,10 @@ void aes_encrypt_nb_4(CRYPT_aes_context* ctx, unsigned int* block) { MOVEWORD(3); ADD_ROUND_KEY_4(); } -#undef MAKEWORD +#undef FMAKEWORD #undef LASTWORD -#define MAKEWORD(i) \ +#define FMAKEWORD(i) \ (newstate[i] = (D0[(block[i] >> 24) & 0xFF] ^ \ D1[(block[(i + C1) % Nb] >> 16) & 0xFF] ^ \ D2[(block[(i + C2) % Nb] >> 8) & 0xFF] ^ \ @@ -502,10 +502,10 @@ void aes_decrypt_nb_4(CRYPT_aes_context* ctx, unsigned int* block) { unsigned int newstate[4]; for (i = 0; i < ctx->Nr - 1; i++) { ADD_ROUND_KEY_4(); - MAKEWORD(0); - MAKEWORD(1); - MAKEWORD(2); - MAKEWORD(3); + FMAKEWORD(0); + FMAKEWORD(1); + FMAKEWORD(2); + FMAKEWORD(3); MOVEWORD(0); MOVEWORD(1); MOVEWORD(2); @@ -522,7 +522,7 @@ void aes_decrypt_nb_4(CRYPT_aes_context* ctx, unsigned int* block) { MOVEWORD(3); ADD_ROUND_KEY_4(); } -#undef MAKEWORD +#undef FMAKEWORD #undef LASTWORD void aes_setup(CRYPT_aes_context* ctx, const unsigned char* key, int keylen) {