From 6d25220ad6c869bb7cd79cf678d092b81558a8d2 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 8 Jan 2014 14:29:55 +0200 Subject: remove unnecessary use of OUString* in FileList. There no benefit in storing a ref-counted value class like OUString by pointer in a std::vector. Change-Id: I302bc460de67c7fe324d745f3225df4e17195486 --- sot/source/base/filelist.cxx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'sot') diff --git a/sot/source/base/filelist.cxx b/sot/source/base/filelist.cxx index da4cd9f446a1..4493fcf129ed 100644 --- a/sot/source/base/filelist.cxx +++ b/sot/source/base/filelist.cxx @@ -39,8 +39,6 @@ FileList::~FileList() void FileList::ClearAll( void ) { - for ( size_t i = 0, n = aStrList.size(); i < n; ++i ) - delete aStrList[ i ]; aStrList.clear(); } @@ -53,7 +51,7 @@ void FileList::ClearAll( void ) FileList& FileList::operator=( const FileList& rFileList ) { for ( size_t i = 0, n = rFileList.aStrList.size(); i < n; ++i ) - aStrList.push_back( new OUString( *rFileList.aStrList[ i ] ) ); + aStrList.push_back( rFileList.aStrList[ i ] ); return *this; } @@ -137,14 +135,14 @@ SvStream& operator>>( SvStream& rIStm, FileList& rFileList ) void FileList::AppendFile( const OUString& rStr ) { - aStrList.push_back( new OUString( rStr ) ); + aStrList.push_back( rStr ); } OUString FileList::GetFile( size_t i ) const { OUString aStr; if( i < aStrList.size() ) - aStr = *aStrList[ i ]; + aStr = aStrList[ i ]; return aStr; } -- cgit