From 911e2aff3cc37cb7410292728ffea05fffbfb0b3 Mon Sep 17 00:00:00 2001 From: Eike Rathke Date: Fri, 3 Nov 2017 14:43:21 +0100 Subject: Resolves: tdf#111428 swap (only) ScColumn::mnBlkCountFormula commit 423df1fa929784c14e3a133c06468589fe9269cd Date: Thu Nov 2 12:53:14 2017 +0100 Resolves: tdf#111428 implement CellStoreEvent::swap() in ScColumn::SwapCol() erroneously swapped also the CellStoreEvent's ScColumn* but of course the CellStoreEvent stays at its ScColumn and is not swapped with the CellStoreType. So swap only the mnBlkCountFormula that CellStoreEvent::mpCol accesses. ASAN rightly complained about heap-use-after-free. Change-Id: Ic44fed96c49bea7365bf1200e06788860966795c --- sc/inc/mtvelements.hxx | 2 -- 1 file changed, 2 deletions(-) (limited to 'sc/inc') diff --git a/sc/inc/mtvelements.hxx b/sc/inc/mtvelements.hxx index 2809b7a621c5..f13562d47fbd 100644 --- a/sc/inc/mtvelements.hxx +++ b/sc/inc/mtvelements.hxx @@ -97,8 +97,6 @@ public: void element_block_acquired(const mdds::mtv::base_element_block* block); void element_block_released(const mdds::mtv::base_element_block* block); - - void swap(CellStoreEvent& r); }; /// Cell note container -- cgit