From 727d4dbebaf947593ce5caae6915238c8c4f3da2 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 18 May 2016 15:22:39 +0200 Subject: loplugin:unusedmethods in package to rsc Change-Id: I61c6f56a69891d656a41d3617d0ce2b34d848c84 Reviewed-on: https://gerrit.libreoffice.org/25108 Tested-by: Jenkins Reviewed-by: Noel Grandin --- reportdesign/source/core/inc/core_resource.hxx | 4 +--- reportdesign/source/filter/xml/xmlExport.hxx | 3 +-- reportdesign/source/ui/inc/ColorChanger.hxx | 14 ------------- reportdesign/source/ui/inc/ViewsWindow.hxx | 29 -------------------------- reportdesign/source/ui/inc/metadata.hxx | 3 +-- 5 files changed, 3 insertions(+), 50 deletions(-) (limited to 'reportdesign') diff --git a/reportdesign/source/core/inc/core_resource.hxx b/reportdesign/source/core/inc/core_resource.hxx index 2652e61f8a0f..9285508dd044 100644 --- a/reportdesign/source/core/inc/core_resource.hxx +++ b/reportdesign/source/core/inc/core_resource.hxx @@ -38,10 +38,8 @@ namespace reportdesign { static SimpleResMgr* m_pImpl; - private: // no instantiation allowed - ResourceManager() { } - ~ResourceManager() { } + ResourceManager() = delete; // we'll instantiate one static member of the following class, which, in its dtor, // ensures that m_pImpl will be deleted diff --git a/reportdesign/source/filter/xml/xmlExport.hxx b/reportdesign/source/filter/xml/xmlExport.hxx index d8854166e4b8..d597b620f6fb 100644 --- a/reportdesign/source/filter/xml/xmlExport.hxx +++ b/reportdesign/source/filter/xml/xmlExport.hxx @@ -140,9 +140,8 @@ private: static OUString implConvertNumber(sal_Int32 _nValue); -private: - ORptExport(); virtual void SetBodyAttributes() override; + protected: virtual void ExportStyles_( bool bUsed ) override; diff --git a/reportdesign/source/ui/inc/ColorChanger.hxx b/reportdesign/source/ui/inc/ColorChanger.hxx index 247863a03211..06ecf7cd7bae 100644 --- a/reportdesign/source/ui/inc/ColorChanger.hxx +++ b/reportdesign/source/ui/inc/ColorChanger.hxx @@ -30,12 +30,6 @@ namespace rptui VclPtr m_pDev; public: - ColorChanger( OutputDevice* _pDev, const Color& _rNewLineColor) - :m_pDev( _pDev ) - { - m_pDev->Push( PushFlags::LINECOLOR ); - m_pDev->SetLineColor( _rNewLineColor ); - } ColorChanger( OutputDevice* _pDev, const Color& _rNewLineColor, const Color& _rNewFillColor ) :m_pDev( _pDev ) { @@ -43,14 +37,6 @@ namespace rptui m_pDev->SetLineColor( _rNewLineColor ); m_pDev->SetFillColor( _rNewFillColor ); } - ColorChanger( OutputDevice* _pDev, const Color& _rNewLineColor, const Color& _rNewFillColor, const Color& _rNewTextColor ) - :m_pDev( _pDev ) - { - m_pDev->Push( PushFlags::LINECOLOR | PushFlags::FILLCOLOR | PushFlags::TEXTCOLOR); - m_pDev->SetLineColor( _rNewLineColor ); - m_pDev->SetFillColor( _rNewFillColor ); - m_pDev->SetTextColor( _rNewTextColor ); - } ~ColorChanger() { diff --git a/reportdesign/source/ui/inc/ViewsWindow.hxx b/reportdesign/source/ui/inc/ViewsWindow.hxx index d97a5be109d3..8ac2f0313430 100644 --- a/reportdesign/source/ui/inc/ViewsWindow.hxx +++ b/reportdesign/source/ui/inc/ViewsWindow.hxx @@ -71,35 +71,6 @@ namespace rptui } }; - class OWindowPositionCorrector - { - ::std::vector< ::std::pair,Point> > m_aChildren; - long m_nDeltaX; - long m_nDeltaY; - public: - OWindowPositionCorrector(vcl::Window* _pWindow,long _nDeltaX, long _nDeltaY) :m_nDeltaX(_nDeltaX), m_nDeltaY(_nDeltaY) - { - sal_uInt16 nCount = _pWindow->GetChildCount(); - m_aChildren.reserve(nCount); - while( nCount ) - { - vcl::Window* pChild = _pWindow->GetChild(--nCount); - m_aChildren.push_back(::std::pair(pChild,pChild->GetPosPixel())); - } - } - ~OWindowPositionCorrector() - { - auto aIter = m_aChildren.begin(); - auto aEnd = m_aChildren.end(); - for (; aIter != aEnd; ++aIter) - { - const Point aPos = aIter->first->GetPosPixel(); - if ( aPos == aIter->second ) - aIter->first->SetPosPixel(Point(m_nDeltaX,m_nDeltaY) + aPos); - } - } - }; - class OViewsWindow : public vcl::Window , public utl::ConfigurationListener , public IMarkedSection diff --git a/reportdesign/source/ui/inc/metadata.hxx b/reportdesign/source/ui/inc/metadata.hxx index 3f980ab74e85..ab1c7dc9e4ae 100644 --- a/reportdesign/source/ui/inc/metadata.hxx +++ b/reportdesign/source/ui/inc/metadata.hxx @@ -39,14 +39,13 @@ namespace rptui { OPropertyInfoService(const OPropertyInfoService&) = delete; void operator =(const OPropertyInfoService&) = delete; + OPropertyInfoService() = delete; protected: static sal_uInt16 s_nCount; static OPropertyInfoImpl* s_pPropertyInfos; // TODO: a real structure which allows quick access by name as well as by id public: - OPropertyInfoService(){} - virtual ~OPropertyInfoService(){} // IPropertyInfoService static sal_Int32 getPropertyId(const OUString& _rName); static OUString getPropertyTranslation(sal_Int32 _nId); -- cgit