From 5708534b942c1d0ce384f6a8473da6bb569410e7 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu, 7 Jun 2018 13:03:58 +0200
Subject: look for unnecessary calls to Reference::is() after an
 UNO_QUERY_THROW

Since the previous call would throw if there was nothing to be assigned
to the value.

Idea from tml.

Used the following script to find places:

    git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()'

Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969
Reviewed-on: https://gerrit.libreoffice.org/55417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
---
 pyuno/source/module/pyuno_module.cxx | 1 -
 1 file changed, 1 deletion(-)

(limited to 'pyuno')

diff --git a/pyuno/source/module/pyuno_module.cxx b/pyuno/source/module/pyuno_module.cxx
index bd04097f01af..a50ca379cf9a 100644
--- a/pyuno/source/module/pyuno_module.cxx
+++ b/pyuno/source/module/pyuno_module.cxx
@@ -336,7 +336,6 @@ static PyObject* initTestEnvironment(
         Reference<XMultiServiceFactory> const xMSF(
             xContext->getServiceManager(),
             css::uno::UNO_QUERY_THROW);
-        if (!xMSF.is()) { abort(); }
         char *const testlib = getenv("TEST_LIB");
         if (!testlib) { abort(); }
         OString const libname = OString(testlib, strlen(testlib))
-- 
cgit