From fda7f14cb5e4d5f93b2ee706b7ec6ad35a988ae5 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 25 Apr 2019 11:48:39 +0200 Subject: Cut down on -pthread/-lpthread proliferation Building against libstdc++ effectively always requires -pthread anyway (as various standard C++ headers require it, see the comment added to solenv/gbuild/platform/unxgcc.mk), so many explicit uses of -pthread/-lpthread can be removed. Doing a (partial) test build on Linux with Clang -stdlib=libc++ suggests that libc++ indeed doesn't need -pthread as libstdc++ does. The remaining uses of -pthread/-lpthread are mostly in configure.ac for the various BSDs (which somebody else might want to clean up now), and related to external projects. I tried to be careful to remove -pthread/-lpthread from makefiles only when C++ object files are involved (so -pthread will now be included on the link command line by default). Reviewed-on: https://gerrit.libreoffice.org/71291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann (cherry picked from commit b1141fa61073b3f24e1a3574afa55a954e5a153d) Change-Id: I936e082839cb9a434bd273ce5a1f187a4245dfa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95130 Tested-by: Thorsten Behrens Reviewed-by: Thorsten Behrens --- onlineupdate/Executable_test_updater_dialog.mk | 1 - onlineupdate/Executable_updater.mk | 1 - 2 files changed, 2 deletions(-) (limited to 'onlineupdate') diff --git a/onlineupdate/Executable_test_updater_dialog.mk b/onlineupdate/Executable_test_updater_dialog.mk index 92e70dfae337..cae8e02df141 100644 --- a/onlineupdate/Executable_test_updater_dialog.mk +++ b/onlineupdate/Executable_test_updater_dialog.mk @@ -61,7 +61,6 @@ $(eval $(call gb_Executable_add_libs,test_updater_dialog,\ -lXrender \ -lSM \ -lICE \ - -lpthread \ )) endif diff --git a/onlineupdate/Executable_updater.mk b/onlineupdate/Executable_updater.mk index a4ceacee6bc1..5f83c13eb9ec 100644 --- a/onlineupdate/Executable_updater.mk +++ b/onlineupdate/Executable_updater.mk @@ -71,7 +71,6 @@ $(eval $(call gb_Executable_add_libs,updater,\ -lXrender \ -lSM \ -lICE \ - -lpthread \ )) endif -- cgit