From 928b1b04adc1cd49cc5d00069084e03675a320f3 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Mon, 24 Sep 2018 15:41:53 +0200 Subject: loplugin:external (clang-cl) Including: * expanding STDAPI to its definition (as per "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- odk/source/unoapploader/win/unoapploader.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'odk') diff --git a/odk/source/unoapploader/win/unoapploader.c b/odk/source/unoapploader/win/unoapploader.c index d7a20e8f13ec..dd5cfaf78439 100644 --- a/odk/source/unoapploader/win/unoapploader.c +++ b/odk/source/unoapploader/win/unoapploader.c @@ -33,11 +33,11 @@ #define MY_SIZE(s) (sizeof (s) / sizeof *(s)) #define MY_LENGTH(s) (MY_SIZE(s) - 1) -wchar_t* getPath(void); -wchar_t* createCommandLine( wchar_t const * lpCmdLine ); -FILE* getErrorFile( int create ); -void writeError( const char* errstr ); -void closeErrorFile(void); +static wchar_t* getPath(void); +static wchar_t* createCommandLine( wchar_t const * lpCmdLine ); +static FILE* getErrorFile( int create ); +static void writeError( const char* errstr ); +static void closeErrorFile(void); /* * The main function implements a loader for applications which use UNO. -- cgit