From 2fab1a73b11a500c38e9df67d1b2061e9a6c9232 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 5 Jul 2012 13:22:47 +0200 Subject: logerrit: for review, we need to grep for revision, not ref Change-Id: I0fb8b1e4f14e153adae7a2ec1b3adbb0dab5c847 --- logerrit | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'logerrit') diff --git a/logerrit b/logerrit index cc24c767e76a..e5b2ba5bc088 100755 --- a/logerrit +++ b/logerrit @@ -8,6 +8,10 @@ get_SHA_for_change() { SHA=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep ref|tail -1|cut -d: -f2` } +get_REVISION_for_change() { + REVISION=`ssh ${GERRITHOST?} gerrit query --all-approvals change:$1|grep revision|tail -1|cut -d: -f2` +} + ask_tristate() { case $1 in [yY] | [yY][Ee][Ss] | [+] ) @@ -159,8 +163,8 @@ case "$1" in ;; esac read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE - get_SHA_for_change $CHANGEID - ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SHA + get_REVISION_for_change $CHANGEID + ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $REVISION ;; checkout) get_SHA_for_change $2 -- cgit