From 03516c505eced337149782a67b2ad98c246929b3 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 30 Sep 2019 15:10:42 +0200 Subject: loplugin:stringadd in helpcompiler..oox Change-Id: I858870d883de10a673d7ce2798bda8c8f511cee5 Reviewed-on: https://gerrit.libreoffice.org/79889 Tested-by: Jenkins Reviewed-by: Noel Grandin --- l10ntools/source/helper.cxx | 5 +---- l10ntools/source/merge.cxx | 7 +------ 2 files changed, 2 insertions(+), 10 deletions(-) (limited to 'l10ntools') diff --git a/l10ntools/source/helper.cxx b/l10ntools/source/helper.cxx index e84b029869a7..84b454bde587 100644 --- a/l10ntools/source/helper.cxx +++ b/l10ntools/source/helper.cxx @@ -121,12 +121,9 @@ OString UnQuotHTML( const OString& rString ) bool isWellFormedXML( OString const & text ) { xmlDocPtr doc; - OString content; bool result = true; - content = ""; - content += text; - content += ""; + OString content = "" + text + ""; doc = xmlParseMemory(content.getStr(),static_cast(content.getLength())); if (doc == nullptr) { result = false; diff --git a/l10ntools/source/merge.cxx b/l10ntools/source/merge.cxx index aff23bafdd07..aad0388bd23d 100644 --- a/l10ntools/source/merge.cxx +++ b/l10ntools/source/merge.cxx @@ -322,12 +322,7 @@ OString MergeDataFile::CreateKey(const OString& rTYP, const OString& rGID, const OString& rLID, const OString& rFilename, bool bCaseSensitive) { static const char sStroke[] = "-"; - OString sKey( rTYP ); - sKey += sStroke; - sKey += rGID; - sKey += sStroke; - sKey += rLID; - sKey += sStroke; + OString sKey = rTYP + sStroke + rGID + sStroke + rLID + sStroke; sKey += lcl_NormalizeFilename(rFilename); if(bCaseSensitive) return sKey; // officecfg case sensitive identifier -- cgit