From f2cd9c0c789b5825b4d5bb84b352d089e231e527 Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Sat, 24 Nov 2018 21:55:10 +0300 Subject: tdf#120703 PVS: V560 A part of conditional expression is always true/false Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- formula/source/core/api/FormulaCompiler.cxx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'formula') diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx index ccf4562fec9d..e98d34a549e1 100644 --- a/formula/source/core/api/FormulaCompiler.cxx +++ b/formula/source/core/api/FormulaCompiler.cxx @@ -1360,11 +1360,10 @@ void FormulaCompiler::Factor() CurrentFactor pFacToken( this ); OpCode eOp = mpToken->GetOpCode(); - if( eOp == ocPush || eOp == ocColRowNameAuto || eOp == ocMatRef || - eOp == ocDBArea || eOp == ocTableRef - || (!mbJumpCommandReorder && ((eOp == ocName) || (eOp == ocDBArea) - || (eOp == ocTableRef) || (eOp == ocColRowName) || (eOp == ocBad))) - ) + if (eOp == ocPush || eOp == ocColRowNameAuto || eOp == ocMatRef || eOp == ocDBArea + || eOp == ocTableRef + || (!mbJumpCommandReorder && ((eOp == ocName) || (eOp == ocColRowName) || (eOp == ocBad))) + ) { PutCode( mpToken ); eOp = NextToken(); -- cgit