From 86a32589e90ee983159fb5b2c6a594428ab7d422 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 6 Mar 2014 15:29:08 +0200 Subject: Find places where OUString and OString are passed by value. It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361 --- forms/source/misc/services.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'forms/source/misc') diff --git a/forms/source/misc/services.cxx b/forms/source/misc/services.cxx index 4b7416c5e32a..2228bc06d164 100644 --- a/forms/source/misc/services.cxx +++ b/forms/source/misc/services.cxx @@ -99,7 +99,7 @@ static Sequence s_aFactories; void registerClassInfo( - OUString _rClassImplName, // the ImplName of the class + const OUString& _rClassImplName, // the ImplName of the class const Sequence< OUString >& _rServiceNames, // the services supported by this class ::cppu::ComponentInstantiation _pCreateFunction // the method for instantiating such a class ) -- cgit