From 7da92fdcb040d1f82fc2a6c61fd05f76f7344035 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Sun, 4 Jan 2015 19:09:27 +0100 Subject: cppcheck: Possible inefficient checking for emptiness Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c --- filter/source/config/cache/filtercache.cxx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'filter/source') diff --git a/filter/source/config/cache/filtercache.cxx b/filter/source/config/cache/filtercache.cxx index a1c37c5bc996..69d60277c231 100644 --- a/filter/source/config/cache/filtercache.cxx +++ b/filter/source/config/cache/filtercache.cxx @@ -172,13 +172,13 @@ void FilterCache::takeOver(const FilterCache& rClone) // c4) clone_2 take over unchanged filters(!) and changed types(!) // c5) c4 overwrites c3! - if (rClone.m_lChangedTypes.size()>0) + if (!rClone.m_lChangedTypes.empty()) m_lTypes = rClone.m_lTypes; - if (rClone.m_lChangedFilters.size()>0) + if (!rClone.m_lChangedFilters.empty()) m_lFilters = rClone.m_lFilters; - if (rClone.m_lChangedFrameLoaders.size()>0) + if (!rClone.m_lChangedFrameLoaders.empty()) m_lFrameLoaders = rClone.m_lFrameLoaders; - if (rClone.m_lChangedContentHandlers.size()>0) + if (!rClone.m_lChangedContentHandlers.empty()) m_lContentHandlers = rClone.m_lContentHandlers; m_lChangedTypes.clear(); @@ -1009,11 +1009,11 @@ void FilterCache::impl_validateAndOptimize() if ( ( (bSomeTypesShouldExist) && - (m_lTypes.size() < 1 ) + (m_lTypes.empty()) ) || ( (bAllFiltersShouldExist) && - (m_lFilters.size() < 1 ) + (m_lFilters.empty()) ) ) { -- cgit