From 58aea3f36c14414f95668e229a7350598f6c53a8 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 30 Sep 2015 10:29:19 +0200 Subject: loplugin:unusedmethods - improvements to the plugin to find more method calls - improvements to python script to remove more false+ - fix the FORCE_COMPILE_ALL build flag to include code in the $WORKDIR Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836 Reviewed-on: https://gerrit.libreoffice.org/19064 Tested-by: Jenkins Reviewed-by: Noel Grandin --- extensions/source/bibliography/datman.cxx | 13 ------------- extensions/source/bibliography/datman.hxx | 1 - extensions/source/propctrlr/commoncontrol.cxx | 18 ------------------ extensions/source/propctrlr/commoncontrol.hxx | 3 --- extensions/source/propctrlr/pcrcommon.hxx | 8 -------- 5 files changed, 43 deletions(-) (limited to 'extensions') diff --git a/extensions/source/bibliography/datman.cxx b/extensions/source/bibliography/datman.cxx index c61520d93b23..fbf65eccfabb 100644 --- a/extensions/source/bibliography/datman.cxx +++ b/extensions/source/bibliography/datman.cxx @@ -1624,19 +1624,6 @@ void BibDataManager::RegisterInterceptor( ::bib::BibBeamer* pBibBeamer) } -bool BibDataManager::HasActiveConnection()const -{ - bool bRet = false; - Reference< XPropertySet > xPrSet( m_xForm, UNO_QUERY ); - if( xPrSet.is() ) - { - Reference< XComponent > xConnection; - xPrSet->getPropertyValue("ActiveConnection") >>= xConnection; - bRet = xConnection.is(); - } - return bRet; -} - bool BibDataManager::HasActiveConnection() { return getConnection( m_xForm ).is(); diff --git a/extensions/source/bibliography/datman.hxx b/extensions/source/bibliography/datman.hxx index b5816a6c80dd..c17b047a78a8 100644 --- a/extensions/source/bibliography/datman.hxx +++ b/extensions/source/bibliography/datman.hxx @@ -166,7 +166,6 @@ public: OUString CreateDBChangeDialog(vcl::Window* pParent); void DispatchDBChangeDialog(); - bool HasActiveConnection() const; void SetView( ::bib::BibView* pView ) { pBibView = pView; } diff --git a/extensions/source/propctrlr/commoncontrol.cxx b/extensions/source/propctrlr/commoncontrol.cxx index 5ac12303a6ae..d7f24693d8a7 100644 --- a/extensions/source/propctrlr/commoncontrol.cxx +++ b/extensions/source/propctrlr/commoncontrol.cxx @@ -117,24 +117,6 @@ namespace pcr } - bool ControlHelper::handlePreNotify(NotifyEvent& rNEvt) - { - if (MouseNotifyEvent::KEYINPUT == rNEvt.GetType()) - { - const vcl::KeyCode& aKeyCode = rNEvt.GetKeyEvent()->GetKeyCode(); - sal_uInt16 nKey = aKeyCode.GetCode(); - - if (nKey == KEY_RETURN && !aKeyCode.IsShift()) - { - notifyModifiedValue(); - impl_activateNextControl_nothrow(); - return true; - } - } - return false; - } - - IMPL_LINK( ControlHelper, ModifiedHdl, vcl::Window*, /*_pWin*/ ) { if ( m_pModifyListener ) diff --git a/extensions/source/propctrlr/commoncontrol.hxx b/extensions/source/propctrlr/commoncontrol.hxx index b649431adee9..ebb8582fff0a 100644 --- a/extensions/source/propctrlr/commoncontrol.hxx +++ b/extensions/source/propctrlr/commoncontrol.hxx @@ -141,9 +141,6 @@ namespace pcr inline void activateNextControl() const { impl_activateNextControl_nothrow(); } public: - /// may be used to implement the default handling in PreNotify; returns sal_True if handled - bool handlePreNotify(NotifyEvent& _rNEvt); - /// automatically size the window given in the ctor void autoSizeWindow(); diff --git a/extensions/source/propctrlr/pcrcommon.hxx b/extensions/source/propctrlr/pcrcommon.hxx index 69588604820b..6a026c7c8278 100644 --- a/extensions/source/propctrlr/pcrcommon.hxx +++ b/extensions/source/propctrlr/pcrcommon.hxx @@ -102,14 +102,6 @@ namespace pcr inline bool empty() const { return UnoBase::getLength() == 0; } inline void resize( size_t _newSize ) { UnoBase::realloc( _newSize ); } - - inline iterator erase( iterator _pos ) - { - iterator loop = end(); - while ( --loop != _pos ) - *( loop - 1 ) = *loop; - resize( size() - 1 ); - } }; -- cgit