From 9fc8b685f9dec107ec6df721ebf3844b992fd8b1 Mon Sep 17 00:00:00 2001 From: Gabor Kelemen Date: Wed, 2 Oct 2019 20:26:00 +0200 Subject: tdf#42949 Fix IWYU warnings in embeddedobj/ Except for test/ which seems to be unused anyway Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9d0b75dbb260f05390b513be75a4bdd24647c91b Reviewed-on: https://gerrit.libreoffice.org/80077 Tested-by: Jenkins Reviewed-by: Miklos Vajna --- embeddedobj/IwyuFilter_embeddedobj.yaml | 27 ++++++++++++++++++++++ embeddedobj/source/commonembedding/embedobj.cxx | 3 --- embeddedobj/source/commonembedding/embedobj.hxx | 2 ++ embeddedobj/source/commonembedding/miscobj.cxx | 3 --- embeddedobj/source/commonembedding/persistence.cxx | 2 -- embeddedobj/source/commonembedding/persistence.hxx | 2 ++ embeddedobj/source/commonembedding/register.cxx | 2 -- .../source/commonembedding/specialobject.cxx | 10 -------- embeddedobj/source/commonembedding/xfactory.cxx | 2 -- embeddedobj/source/general/docholder.cxx | 9 -------- embeddedobj/source/general/dummyobject.cxx | 6 +---- embeddedobj/source/general/intercept.cxx | 1 - embeddedobj/source/general/xcreator.cxx | 2 -- embeddedobj/source/inc/commonembobj.hxx | 5 ---- embeddedobj/source/inc/oleembobj.hxx | 4 ---- embeddedobj/source/msole/mtnotification.hxx | 1 - embeddedobj/source/msole/olecomponent.cxx | 1 + embeddedobj/source/msole/olecomponent.hxx | 5 ---- embeddedobj/source/msole/oleembed.cxx | 2 -- embeddedobj/source/msole/olepersist.cxx | 1 + embeddedobj/source/msole/olepersist.hxx | 2 -- embeddedobj/source/msole/oleregister.cxx | 2 -- embeddedobj/source/msole/ownview.cxx | 1 - embeddedobj/source/msole/ownview.hxx | 1 - embeddedobj/source/msole/xdialogcreator.hxx | 2 ++ embeddedobj/source/msole/xolefactory.cxx | 3 +-- 26 files changed, 37 insertions(+), 64 deletions(-) (limited to 'embeddedobj') diff --git a/embeddedobj/IwyuFilter_embeddedobj.yaml b/embeddedobj/IwyuFilter_embeddedobj.yaml index c9f9c5a02ae2..2fc081ff676c 100644 --- a/embeddedobj/IwyuFilter_embeddedobj.yaml +++ b/embeddedobj/IwyuFilter_embeddedobj.yaml @@ -3,3 +3,30 @@ assumeFilename: embeddedobj/source/commonembedding/embedobj.cxx blacklist: embeddedobj/qa/cppunit/general.cxx: - comphelper/scopeguard.hxx + embeddedobj/source/inc/dummyobject.hxx: + # Don't propose hxx -> h change in URE libs + - cppuhelper/interfacecontainer.hxx + embeddedobj/source/inc/oleembobj.hxx: + # Needed on WIN + - osl/thread.h + embeddedobj/source/msole/olevisual.cxx: + # Needed on WIN + - com/sun/star/embed/EmbedMisc.hpp + - comphelper/seqstream.hxx + - filter/msfilter/classids.hxx + embeddedobj/source/msole/oleembed.cxx: + # Needed on WIN + - com/sun/star/embed/NeedsRunningStateException.hpp + - com/sun/star/embed/StateChangeInProgressException.hpp + - targetstatecontrol.hxx + embeddedobj/source/msole/olemisc.cxx: + # Needed on WIN + - com/sun/star/embed/EmbedStates.hpp + embeddedobj/source/msole/olepersist.cxx: + # Needed on WIN + - com/sun/star/embed/EmbedVerbs.hpp + - osl/thread.hxx + - closepreventer.hxx + embeddedobj/source/commonembedding/embedobj.cxx: + # Don't propose hxx -> h change in URE libs + - cppuhelper/interfacecontainer.hxx diff --git a/embeddedobj/source/commonembedding/embedobj.cxx b/embeddedobj/source/commonembedding/embedobj.cxx index 16762c9dce85..641253008580 100644 --- a/embeddedobj/source/commonembedding/embedobj.cxx +++ b/embeddedobj/source/commonembedding/embedobj.cxx @@ -18,7 +18,6 @@ */ #include -#include #include #include #include @@ -31,7 +30,6 @@ #include #include -#include #include #include #include @@ -48,7 +46,6 @@ #include #include -#include #include "embedobj.hxx" #include diff --git a/embeddedobj/source/commonembedding/embedobj.hxx b/embeddedobj/source/commonembedding/embedobj.hxx index 1c0de3723c90..6778238d2f59 100644 --- a/embeddedobj/source/commonembedding/embedobj.hxx +++ b/embeddedobj/source/commonembedding/embedobj.hxx @@ -20,6 +20,8 @@ #ifndef INCLUDED_EMBEDDEDOBJ_SOURCE_COMMONEMBEDDING_EMBEDOBJ_HXX #define INCLUDED_EMBEDDEDOBJ_SOURCE_COMMONEMBEDDING_EMBEDOBJ_HXX +#include + css::awt::Rectangle GetRectangleInterception( const css::awt::Rectangle& aRect1, const css::awt::Rectangle& aRect2 ); #endif // INCLUDED_EMBEDDEDOBJ_SOURCE_COMMONEMBEDDING_EMBEDOBJ_HXX diff --git a/embeddedobj/source/commonembedding/miscobj.cxx b/embeddedobj/source/commonembedding/miscobj.cxx index 557e21e2646a..5947fef7aca0 100644 --- a/embeddedobj/source/commonembedding/miscobj.cxx +++ b/embeddedobj/source/commonembedding/miscobj.cxx @@ -27,15 +27,12 @@ #include #include -#include #include #include #include #include -#include -#include #include "persistence.hxx" using namespace ::com::sun::star; diff --git a/embeddedobj/source/commonembedding/persistence.cxx b/embeddedobj/source/commonembedding/persistence.cxx index 25c619b5b157..f162dfef5f31 100644 --- a/embeddedobj/source/commonembedding/persistence.cxx +++ b/embeddedobj/source/commonembedding/persistence.cxx @@ -21,7 +21,6 @@ #include #include #include -#include #include #include #include @@ -37,7 +36,6 @@ #include #include #include -#include #include #include #include diff --git a/embeddedobj/source/commonembedding/persistence.hxx b/embeddedobj/source/commonembedding/persistence.hxx index 655748613eeb..a6ef252629fd 100644 --- a/embeddedobj/source/commonembedding/persistence.hxx +++ b/embeddedobj/source/commonembedding/persistence.hxx @@ -20,6 +20,8 @@ #ifndef INCLUDED_EMBEDDEDOBJ_SOURCE_COMMONEMBEDDING_PERSISTENCE_HXX #define INCLUDED_EMBEDDEDOBJ_SOURCE_COMMONEMBEDDING_PERSISTENCE_HXX +#include + css::uno::Sequence< css::beans::PropertyValue > GetValuableArgs_Impl( const css::uno::Sequence< css::beans::PropertyValue >& aMedDescr, bool bCanUseDocumentBaseURL ); diff --git a/embeddedobj/source/commonembedding/register.cxx b/embeddedobj/source/commonembedding/register.cxx index 0ca1676b2de1..adb377544625 100644 --- a/embeddedobj/source/commonembedding/register.cxx +++ b/embeddedobj/source/commonembedding/register.cxx @@ -17,8 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include -#include #include #include diff --git a/embeddedobj/source/commonembedding/specialobject.cxx b/embeddedobj/source/commonembedding/specialobject.cxx index a1e55d87debe..683fe0aab3f2 100644 --- a/embeddedobj/source/commonembedding/specialobject.cxx +++ b/embeddedobj/source/commonembedding/specialobject.cxx @@ -19,27 +19,17 @@ #include #include -#include -#include #include #include -#include -#include -#include #include -#include -#include #include -#include #include #include #include -#include #include #include -#include using namespace ::com::sun::star; diff --git a/embeddedobj/source/commonembedding/xfactory.cxx b/embeddedobj/source/commonembedding/xfactory.cxx index e5b855fa80b9..47ea271c7ca9 100644 --- a/embeddedobj/source/commonembedding/xfactory.cxx +++ b/embeddedobj/source/commonembedding/xfactory.cxx @@ -19,7 +19,6 @@ #include #include -#include #include #include #include @@ -32,7 +31,6 @@ #include "xfactory.hxx" #include #include -#include using namespace ::com::sun::star; diff --git a/embeddedobj/source/general/docholder.cxx b/embeddedobj/source/general/docholder.cxx index b48ffdfe5c64..6b9bb85ea5e0 100644 --- a/embeddedobj/source/general/docholder.cxx +++ b/embeddedobj/source/general/docholder.cxx @@ -23,13 +23,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include #include @@ -42,14 +40,10 @@ #include #include #include -#include #include #include -#include -#include #include #include -#include #include #include #include @@ -63,11 +57,8 @@ #include #include #include -#include #include -#include #include -#include #include #include diff --git a/embeddedobj/source/general/dummyobject.cxx b/embeddedobj/source/general/dummyobject.cxx index 935ad015fb0b..b83b9ec29183 100644 --- a/embeddedobj/source/general/dummyobject.cxx +++ b/embeddedobj/source/general/dummyobject.cxx @@ -18,13 +18,9 @@ */ #include -#include -#include #include +#include #include -#include -#include -#include #include #include #include diff --git a/embeddedobj/source/general/intercept.cxx b/embeddedobj/source/general/intercept.cxx index 59df88e7873f..238f39704a33 100644 --- a/embeddedobj/source/general/intercept.cxx +++ b/embeddedobj/source/general/intercept.cxx @@ -18,7 +18,6 @@ */ #include -#include #include #include diff --git a/embeddedobj/source/general/xcreator.cxx b/embeddedobj/source/general/xcreator.cxx index fe6c79d73da5..f3df8d50de9f 100644 --- a/embeddedobj/source/general/xcreator.cxx +++ b/embeddedobj/source/general/xcreator.cxx @@ -22,8 +22,6 @@ #include #include #include -#include -#include #include #include #include diff --git a/embeddedobj/source/inc/commonembobj.hxx b/embeddedobj/source/inc/commonembobj.hxx index 9ea5c5629424..b2c9acd9ec1e 100644 --- a/embeddedobj/source/inc/commonembobj.hxx +++ b/embeddedobj/source/inc/commonembobj.hxx @@ -26,16 +26,11 @@ #include #include #include -#include #include #include -#include -#include #include -#include #include #include -#include #include #include #include diff --git a/embeddedobj/source/inc/oleembobj.hxx b/embeddedobj/source/inc/oleembobj.hxx index 25194c87d0f8..051d63294af4 100644 --- a/embeddedobj/source/inc/oleembobj.hxx +++ b/embeddedobj/source/inc/oleembobj.hxx @@ -26,13 +26,9 @@ #include #include #include -#include #include #include -#include -#include #include -#include #include #include #include diff --git a/embeddedobj/source/msole/mtnotification.hxx b/embeddedobj/source/msole/mtnotification.hxx index 710481460485..ac2243210ab0 100644 --- a/embeddedobj/source/msole/mtnotification.hxx +++ b/embeddedobj/source/msole/mtnotification.hxx @@ -20,7 +20,6 @@ #ifndef INCLUDED_EMBEDDEDOBJ_SOURCE_MSOLE_MTNOTIFICATION_HXX #define INCLUDED_EMBEDDEDOBJ_SOURCE_MSOLE_MTNOTIFICATION_HXX -#include #include #include #include diff --git a/embeddedobj/source/msole/olecomponent.cxx b/embeddedobj/source/msole/olecomponent.cxx index 33b9586173d8..80180e8dfdc1 100644 --- a/embeddedobj/source/msole/olecomponent.cxx +++ b/embeddedobj/source/msole/olecomponent.cxx @@ -28,6 +28,7 @@ #include #include #include +#include #include #include "platform.h" diff --git a/embeddedobj/source/msole/olecomponent.hxx b/embeddedobj/source/msole/olecomponent.hxx index f9d3c58cbf39..ffcf3e920162 100644 --- a/embeddedobj/source/msole/olecomponent.hxx +++ b/embeddedobj/source/msole/olecomponent.hxx @@ -26,9 +26,6 @@ #include #include #include -#include -#include -#include #include #include #include @@ -37,8 +34,6 @@ #include #include -#include - namespace cppu { class OMultiTypeInterfaceContainerHelper; diff --git a/embeddedobj/source/msole/oleembed.cxx b/embeddedobj/source/msole/oleembed.cxx index 5cf159dfdf17..c84b0e72d073 100644 --- a/embeddedobj/source/msole/oleembed.cxx +++ b/embeddedobj/source/msole/oleembed.cxx @@ -20,12 +20,10 @@ #include #include #include -#include #include #include #include #include -#include #include #include #include diff --git a/embeddedobj/source/msole/olepersist.cxx b/embeddedobj/source/msole/olepersist.cxx index 9f7f41235f60..8dee4adc8704 100644 --- a/embeddedobj/source/msole/olepersist.cxx +++ b/embeddedobj/source/msole/olepersist.cxx @@ -39,6 +39,7 @@ #include #include #include +#include #include #include diff --git a/embeddedobj/source/msole/olepersist.hxx b/embeddedobj/source/msole/olepersist.hxx index d0edd1d8b23b..d9607a1c3836 100644 --- a/embeddedobj/source/msole/olepersist.hxx +++ b/embeddedobj/source/msole/olepersist.hxx @@ -22,9 +22,7 @@ #include -#include #include -#include #include namespace com { namespace sun { namespace star { diff --git a/embeddedobj/source/msole/oleregister.cxx b/embeddedobj/source/msole/oleregister.cxx index ca1e4437b309..7af86e8db9ae 100644 --- a/embeddedobj/source/msole/oleregister.cxx +++ b/embeddedobj/source/msole/oleregister.cxx @@ -17,8 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include -#include #include #include diff --git a/embeddedobj/source/msole/ownview.cxx b/embeddedobj/source/msole/ownview.cxx index e89ec59f60d8..306f51dfe973 100644 --- a/embeddedobj/source/msole/ownview.cxx +++ b/embeddedobj/source/msole/ownview.cxx @@ -40,7 +40,6 @@ #include #include #include -#include #include #include "olepersist.hxx" diff --git a/embeddedobj/source/msole/ownview.hxx b/embeddedobj/source/msole/ownview.hxx index 4b437fea8d51..4afcb9e80b17 100644 --- a/embeddedobj/source/msole/ownview.hxx +++ b/embeddedobj/source/msole/ownview.hxx @@ -24,7 +24,6 @@ #include #include #include -#include #include #include diff --git a/embeddedobj/source/msole/xdialogcreator.hxx b/embeddedobj/source/msole/xdialogcreator.hxx index b858930b3646..128c099d23aa 100644 --- a/embeddedobj/source/msole/xdialogcreator.hxx +++ b/embeddedobj/source/msole/xdialogcreator.hxx @@ -23,8 +23,10 @@ #include #include #include +#include #include +#include class MSOLEDialogObjectCreator : public ::cppu::WeakImplHelper< diff --git a/embeddedobj/source/msole/xolefactory.cxx b/embeddedobj/source/msole/xolefactory.cxx index 553f5846807a..341afdd3e003 100644 --- a/embeddedobj/source/msole/xolefactory.cxx +++ b/embeddedobj/source/msole/xolefactory.cxx @@ -17,13 +17,12 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include #include #include -#include #include #include #include +#include #include "xolefactory.hxx" #include -- cgit