From 8bb04558b97a84ec45e0e93b91fa8b4c226f9032 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 25 Mar 2019 14:59:02 +0200 Subject: loplugin:unnnecessaryvirtual Change-Id: I2aa9a8f14b6db2098931a14c6eed522a9d2653ed Reviewed-on: https://gerrit.libreoffice.org/69682 Tested-by: Jenkins Reviewed-by: Noel Grandin --- .../clang/unnecessaryvirtual-dead.results | 2 +- compilerplugins/clang/unnecessaryvirtual.results | 22 ++++++++++++---------- 2 files changed, 13 insertions(+), 11 deletions(-) (limited to 'compilerplugins') diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results index 32567613fd25..29f7436169ff 100644 --- a/compilerplugins/clang/unnecessaryvirtual-dead.results +++ b/compilerplugins/clang/unnecessaryvirtual-dead.results @@ -12,7 +12,7 @@ sc/source/core/opencl/formulagroupcl.cxx:1061 void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream &,) slideshow/source/engine/animationfactory.cxx:443 void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr &,const class std::shared_ptr &,) -vcl/inc/salframe.hxx:135 +vcl/inc/salframe.hxx:144 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) vcl/inc/salmenu.hxx:71 void SalMenu::SetItemBits(unsigned int,enum MenuItemBits,) diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results index 9a7ac15bfe80..a092dc88030c 100644 --- a/compilerplugins/clang/unnecessaryvirtual.results +++ b/compilerplugins/clang/unnecessaryvirtual.results @@ -72,6 +72,12 @@ include/comphelper/unique_disposing_ptr.hxx:169 void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,) include/comphelper/weakeventlistener.hxx:120 void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,) +include/oox/helper/graphichelper.hxx:77 + int oox::GraphicHelper::getDefaultChartAreaLineStyle()const +include/oox/helper/graphichelper.hxx:80 + short oox::GraphicHelper::getDefaultChartAreaLineWidth()const +include/sfx2/tabdlg.hxx:103 + class SfxItemSet * SfxTabDialog::CreateInputItemSet(unsigned short,) include/svl/svdde.hxx:237 class DdeData * DdeTopic::Get(enum SotClipboardFormatId,) include/svl/svdde.hxx:238 @@ -108,10 +114,8 @@ include/vbahelper/vbareturntypes.hxx:40 void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,) include/vbahelper/vbareturntypes.hxx:41 type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue() -include/vcl/filter/PngImageReader.hxx:29 - void vcl::PngImageReader::~PngImageReader() -include/xmloff/xmlstyle.hxx:217 - unsigned short SvXMLStylesContext::GetFamily(const class rtl::OUString &,)const +include/vcl/weld.hxx:95 + void weld::Widget::set_visible(_Bool,) sc/source/core/opencl/formulagroupcl.cxx:1053 _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const sc/source/core/opencl/formulagroupcl.cxx:1061 @@ -188,8 +192,8 @@ sc/source/ui/vba/vbapagebreak.hxx:48 void ScVbaPageBreak::Delete() sc/source/ui/vba/vbapagebreak.hxx:49 class com::sun::star::uno::Reference ScVbaPageBreak::Location() -sd/source/ui/inc/ViewClipboard.hxx:77 - unsigned short sd::ViewClipboard::InsertSlides(const class SdTransferable &,unsigned short,) +shell/inc/i_xml_parser_event_handler.hxx:41 + void i_xml_parser_event_handler::~i_xml_parser_event_handler() slideshow/source/engine/activities/activitiesfactory.cxx:173 void slideshow::internal::(anonymous namespace)::FromToByActivity::startAnimation() slideshow/source/engine/activities/activitiesfactory.cxx:242 @@ -210,11 +214,9 @@ slideshow/source/engine/animationfactory.cxx:447 void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr &,const class std::shared_ptr &,) sw/inc/flypos.hxx:37 void SwPosFlyFrame::~SwPosFlyFrame() -sw/source/uibase/inc/drawbase.hxx:53 - _Bool SwDrawBase::MouseMove(const class MouseEvent &,) -vcl/inc/salframe.hxx:135 +vcl/inc/salframe.hxx:144 void SalFrame::SetRepresentedURL(const class rtl::OUString &,) -vcl/inc/salframe.hxx:180 +vcl/inc/salframe.hxx:189 void SalFrame::Flush(const class tools::Rectangle &,) vcl/inc/salinst.hxx:92 _Bool SalInstance::SVMainHook(int *,) -- cgit