From 67d333c608a662621c1069aacdec75e45e33a183 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 18 Apr 2016 11:21:44 +0200 Subject: tdf#99352 - Some VclPtrs leak past DeInitVCL Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins Reviewed-by: Noel Grandin --- compilerplugins/clang/badstatics.cxx | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'compilerplugins') diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx index ecc930093a3a..d3fc83127fde 100644 --- a/compilerplugins/clang/badstatics.cxx +++ b/compilerplugins/clang/badstatics.cxx @@ -146,13 +146,9 @@ public: { return true; } - // TODO: check these VclPtr<> static fields - if ( name == "xPreviousWindow" // vcl/source/window/winproc.cxx - || name == "vDev" // sdext/source/pdfimport/wrapper/wrapper.cxx - || name == "s_xEmptyController" // svx/source/fmcomp/gridcell.cxx + // these two are fairly harmless because they're both empty objects + if ( name == "s_xEmptyController" // svx/source/fmcomp/gridcell.cxx || name == "xCell" // svx/source/table/svdotable.cxx - || name == "pPixOut" // sw/source/core/txtnode/fntcache.cxx - || name == "mpCareWindow" // sw/source/core/view/viewsh.cxx ) { return true; -- cgit