From 24eae7bd702f3f6dd790be7ac38ac16e9fe6a375 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 6 Sep 2018 08:50:58 +0200 Subject: clang-tidy performance-unnecessary-value-param Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8 Reviewed-on: https://gerrit.libreoffice.org/60068 Tested-by: Jenkins Reviewed-by: Noel Grandin --- comphelper/source/misc/graphicmimetype.cxx | 5 +++-- comphelper/source/misc/storagehelper.cxx | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'comphelper') diff --git a/comphelper/source/misc/graphicmimetype.cxx b/comphelper/source/misc/graphicmimetype.cxx index 0c0ca8057549..4c335f348173 100644 --- a/comphelper/source/misc/graphicmimetype.cxx +++ b/comphelper/source/misc/graphicmimetype.cxx @@ -64,7 +64,7 @@ OUString GraphicMimeTypeHelper::GetMimeTypeForExtension(const OString& rExt) return aMimeType; } -OUString GraphicMimeTypeHelper::GetMimeTypeForXGraphic(Reference xGraphic) +OUString GraphicMimeTypeHelper::GetMimeTypeForXGraphic(const Reference& xGraphic) { OUString aSourceMimeType; Reference const xGraphicPropertySet(xGraphic, UNO_QUERY); @@ -76,7 +76,8 @@ OUString GraphicMimeTypeHelper::GetMimeTypeForXGraphic(Reference xGrap return OUString(""); } -OUString GraphicMimeTypeHelper::GetMimeTypeForImageStream(Reference xInputStream) +OUString +GraphicMimeTypeHelper::GetMimeTypeForImageStream(const Reference& xInputStream) { // Create the graphic to retrieve the mimetype from it Reference xProvider diff --git a/comphelper/source/misc/storagehelper.cxx b/comphelper/source/misc/storagehelper.cxx index 4ce5d66e4f38..c62b6d14f7cc 100644 --- a/comphelper/source/misc/storagehelper.cxx +++ b/comphelper/source/misc/storagehelper.cxx @@ -705,7 +705,7 @@ uno::Reference< io::XStream > OStorageHelper::GetStreamAtPackageURL( return nullptr; } -OUString OStorageHelper::GetODFVersionFromStorage(uno::Reference xStorage) +OUString OStorageHelper::GetODFVersionFromStorage(const uno::Reference& xStorage) { OUString aODFVersion; try -- cgit