From 4f7f39a262c5db74285bc44798f438a431fa7210 Mon Sep 17 00:00:00 2001 From: Kelemen Gábor Date: Fri, 6 Dec 2019 11:03:29 +0100 Subject: tdf#34517 Bring forward/backward in chart series switched MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Turns out bringing a data series forward means its index is increased while bringing backwards means decreasing it. Since the bool MOVE_SERIES_FORWARD is defined as true in ControllerCommandDispatch.cxx the condition here meant that bringing forward decreased the index and MOVE_SERIES_BACKWARD as false meant that bringing backward increased the index. Now the commands do the expected series order change. Change-Id: Ib49b301eacc227439b8fb3b0dc3513e59cbdc484 Reviewed-on: https://gerrit.libreoffice.org/84608 Tested-by: Jenkins Reviewed-by: László Németh (cherry picked from commit 6cdab5c92cecf90090ba72dfa6c22edf0d41028f) Reviewed-on: https://gerrit.libreoffice.org/85025 --- chart2/source/tools/DiagramHelper.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'chart2') diff --git a/chart2/source/tools/DiagramHelper.cxx b/chart2/source/tools/DiagramHelper.cxx index 22ddfb27acd5..14d8126625ae 100644 --- a/chart2/source/tools/DiagramHelper.cxx +++ b/chart2/source/tools/DiagramHelper.cxx @@ -1328,7 +1328,8 @@ bool lcl_moveSeriesOrCheckIfMoveIsAllowed( { sal_Int32 nNewSeriesIndex = nS; - if( bForward ) + // tdf#34517 Bringing forward means increasing, backwards means decreasing series position + if( !bForward ) nNewSeriesIndex--; else nNewSeriesIndex++; -- cgit