From c0cc59adca23580864a2e5cdadf66212246cbfcc Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri, 26 Oct 2018 08:37:40 +0200
Subject: loplugin:singlevalfields improvement

look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 canvas/source/opengl/ogl_spritedevicehelper.cxx | 2 --
 canvas/source/opengl/ogl_spritedevicehelper.hxx | 8 --------
 2 files changed, 10 deletions(-)

(limited to 'canvas')

diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx b/canvas/source/opengl/ogl_spritedevicehelper.cxx
index 1764f3078765..82345bd7045a 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.cxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx
@@ -77,7 +77,6 @@ namespace oglcanvas
 {
 
     SpriteDeviceHelper::SpriteDeviceHelper() :
-        mpDevice(nullptr),
         mpSpriteCanvas(nullptr),
         maActiveSprites(),
         maLastUpdate(),
@@ -138,7 +137,6 @@ namespace oglcanvas
     {
         // release all references
         mpSpriteCanvas = nullptr;
-        mpDevice = nullptr;
         mpTextureCache.reset();
 
         if( mxContext->isInitialized() )
diff --git a/canvas/source/opengl/ogl_spritedevicehelper.hxx b/canvas/source/opengl/ogl_spritedevicehelper.hxx
index 38053f22100f..ddc6e27a3e04 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.hxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.hxx
@@ -115,14 +115,6 @@ namespace oglcanvas
         bool activateWindowContext();
 
     private:
-        /** Phyical output device
-
-            Deliberately not a refcounted reference, because of
-            potential circular references for canvas. Needed to
-            create bitmaps
-         */
-        css::rendering::XGraphicDevice*                    mpDevice;
-
         /// Pointer to sprite canvas (owner of this helper), needed to create bitmaps
         SpriteCanvas*                                      mpSpriteCanvas;
 
-- 
cgit