From 7764ae70b04058a64a3999529e98d1115ba59d1c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 7 Sep 2018 15:47:40 +0200 Subject: clang bugprone-unused-return-value most of these changes just make the change of ownership when using std::unique_ptr clearer, but there is one definite leak fix in PlainTextFilterDetect::detect Change-Id: I8282a68007222a4fee84004f394bde0cca8569e9 Reviewed-on: https://gerrit.libreoffice.org/60159 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- binaryurp/source/reader.cxx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'binaryurp') diff --git a/binaryurp/source/reader.cxx b/binaryurp/source/reader.cxx index fa5e91be704e..c40aeadea7df 100644 --- a/binaryurp/source/reader.cxx +++ b/binaryurp/source/reader.cxx @@ -335,9 +335,8 @@ void Reader::readMessage(Unmarshal & unmarshal) { bridge_->incrementActiveCalls(); } uno_threadpool_putJob( - bridge_->getThreadPool(), tid.getHandle(), req.get(), &request, + bridge_->getThreadPool(), tid.getHandle(), req.release(), &request, !synchronous); - req.release(); } } @@ -443,9 +442,8 @@ void Reader::readReplyMessage(Unmarshal & unmarshal, sal_uInt8 flags1) { std::unique_ptr< IncomingReply > resp( new IncomingReply(exc, ret, outArgs)); uno_threadpool_putJob( - bridge_->getThreadPool(), tid.getHandle(), resp.get(), nullptr, + bridge_->getThreadPool(), tid.getHandle(), resp.release(), nullptr, false); - resp.release(); break; } case OutgoingRequest::KIND_REQUEST_CHANGE: -- cgit