From 12e460d99988a66179381fe40185978450ea0ea0 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 16 Nov 2018 14:04:02 +0200 Subject: loplugin:buriedassign in avmedia..cui Change-Id: Id44f1e98a3aac2c417f8030de603175bf68f0dfe Reviewed-on: https://gerrit.libreoffice.org/63467 Tested-by: Jenkins Reviewed-by: Noel Grandin --- avmedia/source/viewer/mediawindow.cxx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'avmedia') diff --git a/avmedia/source/viewer/mediawindow.cxx b/avmedia/source/viewer/mediawindow.cxx index 861c7d377c93..d778c72e7c31 100644 --- a/avmedia/source/viewer/mediawindow.cxx +++ b/avmedia/source/viewer/mediawindow.cxx @@ -219,7 +219,7 @@ bool MediaWindow::executeMediaURLDialog(weld::Window* pParent, OUString& rURL, b static const char aWildcard[] = "*."; FilterNameVector aFilters; static const char aSeparator[] = ";"; - OUString aAllTypes; + OUStringBuffer aAllTypes; aDlg.SetTitle( AvmResId( o_pbLink != nullptr ? AVMEDIA_STR_INSERTMEDIA_DLG : AVMEDIA_STR_OPENMEDIA_DLG ) ); @@ -231,29 +231,29 @@ bool MediaWindow::executeMediaURLDialog(weld::Window* pParent, OUString& rURL, b for( sal_Int32 nIndex = 0; nIndex >= 0; ) { if( !aAllTypes.isEmpty() ) - aAllTypes += aSeparator; + aAllTypes.append(aSeparator); - ( aAllTypes += aWildcard ) += aFilters[ i ].second.getToken( 0, ';', nIndex ); + aAllTypes.append(aWildcard).append(aFilters[ i ].second.getToken( 0, ';', nIndex )); } } // add filter for all media types - aDlg.AddFilter( AvmResId( AVMEDIA_STR_ALL_MEDIAFILES ), aAllTypes ); + aDlg.AddFilter( AvmResId( AVMEDIA_STR_ALL_MEDIAFILES ), aAllTypes.makeStringAndClear() ); for( FilterNameVector::size_type i = 0; i < aFilters.size(); ++i ) { - OUString aTypes; + OUStringBuffer aTypes; for( sal_Int32 nIndex = 0; nIndex >= 0; ) { if( !aTypes.isEmpty() ) - aTypes += aSeparator; + aTypes.append(aSeparator); - ( aTypes += aWildcard ) += aFilters[ i ].second.getToken( 0, ';', nIndex ); + aTypes.append(aWildcard).append(aFilters[ i ].second.getToken( 0, ';', nIndex )); } // add single filters - aDlg.AddFilter( aFilters[ i ].first, aTypes ); + aDlg.AddFilter( aFilters[ i ].first, aTypes.makeStringAndClear() ); } // add filter for all types -- cgit