From f5ef2945d1af500c80d831ee09c1c34c766b0a54 Mon Sep 17 00:00:00 2001 From: Julien Nabet Date: Fri, 13 Jan 2023 22:05:35 +0100 Subject: Related tdf#153003: Copying a query and pasting as table in same DB impossible It might be a regression from ca82061c2cad00aeddb17b766063776fee0ee41a "make ValueTransfer easier to understand storing references to local variables makes it harder to figure out what the control flow is doing. " in peculiar: - sal_Int32 nDestColumn( 0 ); - sal_Int32 nSourceColumn( 1 ); - ValueTransfer aTransfer( nSourceColumn, nDestColumn, std::vector(aSourceColTypes), xRow, xStatementParams ); + sal_Int32 nSourceColumn( 0 ); + ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams ); Change-Id: Iaa27c4f46fcc51ec12fff08f8e99f862c8b4ac2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145499 Tested-by: Jenkins Reviewed-by: Julien Nabet (cherry picked from commit c9b0eacae71f111209cb77f14f2693d73e5e8d90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145440 Reviewed-by: Xisco Fauli (cherry picked from commit aaa072e736a45be6ca942abd20be19935334124f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145574 Reviewed-by: Michael Stahl Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- dbaccess/source/ui/uno/copytablewizard.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx index fab5e3966cbd..c886995398a7 100644 --- a/dbaccess/source/ui/uno/copytablewizard.cxx +++ b/dbaccess/source/ui/uno/copytablewizard.cxx @@ -1141,7 +1141,7 @@ void CopyTableWizard::impl_copyRows_throw( const Reference< XResultSet >& _rxSou // notify listeners m_aCopyTableListeners.notifyEach( &XCopyTableListener::copyingRow, aCopyEvent ); - sal_Int32 nSourceColumn( 0 ); + sal_Int32 nSourceColumn( 1 ); ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams ); for ( auto const& rColumnPos : aColumnPositions ) -- cgit