From eb3587b1c54f7b264e6439d1cf39768c863284e4 Mon Sep 17 00:00:00 2001
From: Caolán McNamara <caolanm@redhat.com>
Date: Fri, 23 Aug 2019 20:01:33 +0100
Subject: Related: tdf#126693 cannot put focus into combobox entry
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

set can-focus=True in internal GtkComboBoxText GtkEntry where the
GtkEntry is editable=True

Change-Id: I32cc7686c3a3cb9827f05f192227c0ad39669aa5
Reviewed-on: https://gerrit.libreoffice.org/78035
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
---
 cui/uiconfig/ui/galleryfilespage.ui               |  2 +-
 cui/uiconfig/ui/optfontspage.ui                   |  4 ++--
 dbaccess/uiconfig/ui/backuppage.ui                |  2 +-
 extensions/uiconfig/sabpilot/ui/datasourcepage.ui |  2 +-
 extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui  |  4 ++--
 extensions/uiconfig/scanner/ui/sanedialog.ui      |  2 +-
 filter/uiconfig/ui/pdfgeneralpage.ui              |  2 +-
 filter/uiconfig/ui/xmlfiltertabpagegeneral.ui     |  2 +-
 sc/uiconfig/scalc/ui/definedatabaserangedialog.ui |  2 +-
 sc/uiconfig/scalc/ui/textimportcsv.ui             |  2 +-
 sd/uiconfig/simpress/ui/optimpressgeneralpage.ui  |  2 +-
 sd/uiconfig/simpress/ui/publishingdialog.ui       |  2 +-
 sfx2/uiconfig/ui/helpsearchpage.ui                |  2 +-
 sw/uiconfig/swriter/ui/addressblockdialog.ui      |  2 +-
 sw/uiconfig/swriter/ui/charurlpage.ui             |  2 +-
 sw/uiconfig/swriter/ui/frmurlpage.ui              |  2 +-
 sw/uiconfig/swriter/ui/mmmailbody.ui              |  4 ++--
 sw/uiconfig/swriter/ui/mmsalutationpage.ui        |  2 +-
 sw/uiconfig/swriter/ui/optcaptionpage.ui          |  2 +-
 sw/uiconfig/swriter/ui/optfonttabpage.ui          | 20 ++++++++++----------
 sw/uiconfig/swriter/ui/tocentriespage.ui          |  2 +-
 vcl/uiconfig/ui/printdialog.ui                    |  2 +-
 22 files changed, 34 insertions(+), 34 deletions(-)

diff --git a/cui/uiconfig/ui/galleryfilespage.ui b/cui/uiconfig/ui/galleryfilespage.ui
index 456627d16cd1..99b5888b3d8e 100644
--- a/cui/uiconfig/ui/galleryfilespage.ui
+++ b/cui/uiconfig/ui/galleryfilespage.ui
@@ -53,7 +53,7 @@
                 <property name="width_request">0</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                     <property name="activates_default">True</property>
                   </object>
                 </child>
diff --git a/cui/uiconfig/ui/optfontspage.ui b/cui/uiconfig/ui/optfontspage.ui
index 02d9fe4db20d..8de16075a2d3 100644
--- a/cui/uiconfig/ui/optfontspage.ui
+++ b/cui/uiconfig/ui/optfontspage.ui
@@ -241,7 +241,7 @@
                         <property name="has_entry">True</property>
                         <child internal-child="entry">
                           <object class="GtkEntry">
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
                             <property name="activates_default">True</property>
                           </object>
                         </child>
@@ -259,7 +259,7 @@
                         <property name="has_entry">True</property>
                         <child internal-child="entry">
                           <object class="GtkEntry">
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
                             <property name="activates_default">True</property>
                           </object>
                         </child>
diff --git a/dbaccess/uiconfig/ui/backuppage.ui b/dbaccess/uiconfig/ui/backuppage.ui
index 6236a0b2b9d9..0ea91eed52f6 100644
--- a/dbaccess/uiconfig/ui/backuppage.ui
+++ b/dbaccess/uiconfig/ui/backuppage.ui
@@ -90,7 +90,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="URLBox-entry1">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/extensions/uiconfig/sabpilot/ui/datasourcepage.ui b/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
index 3aa64cca58ca..ac4a90acb281 100644
--- a/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
+++ b/extensions/uiconfig/sabpilot/ui/datasourcepage.ui
@@ -96,7 +96,7 @@ Now, just enter the name under which you want to register the data source in %PR
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui b/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
index 060893dacf12..3abf54171d2f 100644
--- a/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
+++ b/extensions/uiconfig/sabpilot/ui/fieldlinkpage.ui
@@ -67,7 +67,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry2">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
@@ -115,7 +115,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry4">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/extensions/uiconfig/scanner/ui/sanedialog.ui b/extensions/uiconfig/scanner/ui/sanedialog.ui
index 9050cf8ac14a..b2a902c1b810 100644
--- a/extensions/uiconfig/scanner/ui/sanedialog.ui
+++ b/extensions/uiconfig/scanner/ui/sanedialog.ui
@@ -406,7 +406,7 @@
                         <property name="has_entry">True</property>
                         <child internal-child="entry">
                           <object class="GtkEntry">
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
                           </object>
                         </child>
                       </object>
diff --git a/filter/uiconfig/ui/pdfgeneralpage.ui b/filter/uiconfig/ui/pdfgeneralpage.ui
index 9c03989d3656..1fa47b4a23e1 100644
--- a/filter/uiconfig/ui/pdfgeneralpage.ui
+++ b/filter/uiconfig/ui/pdfgeneralpage.ui
@@ -256,7 +256,7 @@
                                 </items>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                     <property name="activates_default">True</property>
                                     <property name="text" translatable="yes" context="pdfgeneralpage|comboboxtext-entry">75 DPI</property>
                                   </object>
diff --git a/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui b/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
index b44d0f9fc0d9..24f6f366e85d 100644
--- a/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
+++ b/filter/uiconfig/ui/xmlfiltertabpagegeneral.ui
@@ -133,7 +133,7 @@
             <property name="has_entry">True</property>
             <child internal-child="entry">
               <object class="GtkEntry" id="comboboxtext-entry">
-                <property name="can_focus">False</property>
+                <property name="can_focus">True</property>
                 <property name="activates_default">True</property>
               </object>
             </child>
diff --git a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
index 4cedef27471d..5f9f02d063e0 100644
--- a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
+++ b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui
@@ -208,7 +208,7 @@
                         <child>
                           <object class="GtkEntry" id="assign">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can_focus">True</property>
                             <property name="hexpand">True</property>
                             <property name="activates_default">True</property>
                           </object>
diff --git a/sc/uiconfig/scalc/ui/textimportcsv.ui b/sc/uiconfig/scalc/ui/textimportcsv.ui
index 13cc41491347..0e1c74cecf0d 100644
--- a/sc/uiconfig/scalc/ui/textimportcsv.ui
+++ b/sc/uiconfig/scalc/ui/textimportcsv.ui
@@ -459,7 +459,7 @@
                                         <property name="has_entry">True</property>
                                         <child internal-child="entry">
                                           <object class="GtkEntry" id="comboboxtext-entry">
-                                            <property name="can_focus">False</property>
+                                            <property name="can_focus">True</property>
                                           </object>
                                         </child>
                                       </object>
diff --git a/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui b/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
index 8f55a36d6051..d5d7d80bad82 100644
--- a/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
+++ b/sd/uiconfig/simpress/ui/optimpressgeneralpage.ui
@@ -564,7 +564,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="combobox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sd/uiconfig/simpress/ui/publishingdialog.ui b/sd/uiconfig/simpress/ui/publishingdialog.ui
index d476afb1d6df..eb24700a60c9 100644
--- a/sd/uiconfig/simpress/ui/publishingdialog.ui
+++ b/sd/uiconfig/simpress/ui/publishingdialog.ui
@@ -1001,7 +1001,7 @@
                                     <property name="has_entry">True</property>
                                     <child internal-child="entry">
                                       <object class="GtkEntry" id="combobox-entry">
-                                        <property name="can_focus">False</property>
+                                        <property name="can_focus">True</property>
                                         <property name="activates_default">True</property>
                                       </object>
                                     </child>
diff --git a/sfx2/uiconfig/ui/helpsearchpage.ui b/sfx2/uiconfig/ui/helpsearchpage.ui
index e610bcb916f2..a8eeec27324e 100644
--- a/sfx2/uiconfig/ui/helpsearchpage.ui
+++ b/sfx2/uiconfig/ui/helpsearchpage.ui
@@ -77,7 +77,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="combobox-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/sw/uiconfig/swriter/ui/addressblockdialog.ui b/sw/uiconfig/swriter/ui/addressblockdialog.ui
index 8eb073035615..7e0994440c29 100644
--- a/sw/uiconfig/swriter/ui/addressblockdialog.ui
+++ b/sw/uiconfig/swriter/ui/addressblockdialog.ui
@@ -309,7 +309,7 @@
                 <property name="has_entry">True</property>
                 <child internal-child="entry">
                   <object class="GtkEntry" id="comboboxtext-entry">
-                    <property name="can_focus">False</property>
+                    <property name="can_focus">True</property>
                   </object>
                 </child>
               </object>
diff --git a/sw/uiconfig/swriter/ui/charurlpage.ui b/sw/uiconfig/swriter/ui/charurlpage.ui
index b2436bad3cb2..7496f0aa2c15 100644
--- a/sw/uiconfig/swriter/ui/charurlpage.ui
+++ b/sw/uiconfig/swriter/ui/charurlpage.ui
@@ -156,7 +156,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="comboboxtext-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sw/uiconfig/swriter/ui/frmurlpage.ui b/sw/uiconfig/swriter/ui/frmurlpage.ui
index 4e7115a13685..4aca7d26e197 100644
--- a/sw/uiconfig/swriter/ui/frmurlpage.ui
+++ b/sw/uiconfig/swriter/ui/frmurlpage.ui
@@ -132,7 +132,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="comboboxtext-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sw/uiconfig/swriter/ui/mmmailbody.ui b/sw/uiconfig/swriter/ui/mmmailbody.ui
index c6358f9c245a..cc6ee6cdf26f 100644
--- a/sw/uiconfig/swriter/ui/mmmailbody.ui
+++ b/sw/uiconfig/swriter/ui/mmmailbody.ui
@@ -182,7 +182,7 @@
                             <property name="has_entry">True</property>
                             <child internal-child="entry">
                               <object class="GtkEntry" id="comboboxtext-entry1">
-                                <property name="can_focus">False</property>
+                                <property name="can_focus">True</property>
                               </object>
                             </child>
                           </object>
@@ -351,7 +351,7 @@
                                         <property name="has_entry">True</property>
                                         <child internal-child="entry">
                                           <object class="GtkEntry" id="comboboxtext-entry2">
-                                            <property name="can_focus">False</property>
+                                            <property name="can_focus">True</property>
                                           </object>
                                         </child>
                                       </object>
diff --git a/sw/uiconfig/swriter/ui/mmsalutationpage.ui b/sw/uiconfig/swriter/ui/mmsalutationpage.ui
index 46c6ebd53d8a..5f88c8e97c66 100644
--- a/sw/uiconfig/swriter/ui/mmsalutationpage.ui
+++ b/sw/uiconfig/swriter/ui/mmsalutationpage.ui
@@ -234,7 +234,7 @@
                                 <property name="has_entry">True</property>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                   </object>
                                 </child>
                               </object>
diff --git a/sw/uiconfig/swriter/ui/optcaptionpage.ui b/sw/uiconfig/swriter/ui/optcaptionpage.ui
index a133a127c32e..400429913969 100644
--- a/sw/uiconfig/swriter/ui/optcaptionpage.ui
+++ b/sw/uiconfig/swriter/ui/optcaptionpage.ui
@@ -185,7 +185,7 @@
                             <property name="has_entry">True</property>
                             <child internal-child="entry">
                               <object class="GtkEntry" id="comboboxtext-entry">
-                                <property name="can_focus">False</property>
+                                <property name="can_focus">True</property>
                                 <property name="activates_default">True</property>
                               </object>
                             </child>
diff --git a/sw/uiconfig/swriter/ui/optfonttabpage.ui b/sw/uiconfig/swriter/ui/optfonttabpage.ui
index 16eeb39956a7..dd0e9fcccf28 100644
--- a/sw/uiconfig/swriter/ui/optfonttabpage.ui
+++ b/sw/uiconfig/swriter/ui/optfonttabpage.ui
@@ -138,7 +138,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="standardbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -156,7 +156,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="titlebox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -174,7 +174,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="listbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -192,7 +192,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="labelbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -210,7 +210,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry" id="idxbox-entry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -227,7 +227,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -244,7 +244,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -261,7 +261,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -278,7 +278,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
@@ -295,7 +295,7 @@
                     <property name="has_entry">True</property>
                     <child internal-child="entry">
                       <object class="GtkEntry">
-                        <property name="can_focus">False</property>
+                        <property name="can_focus">True</property>
                         <property name="activates_default">True</property>
                       </object>
                     </child>
diff --git a/sw/uiconfig/swriter/ui/tocentriespage.ui b/sw/uiconfig/swriter/ui/tocentriespage.ui
index 2891dd174b03..15cdc7422c61 100644
--- a/sw/uiconfig/swriter/ui/tocentriespage.ui
+++ b/sw/uiconfig/swriter/ui/tocentriespage.ui
@@ -305,7 +305,7 @@
                                 <property name="has_entry">True</property>
                                 <child internal-child="entry">
                                   <object class="GtkEntry" id="comboboxtext-entry">
-                                    <property name="can_focus">False</property>
+                                    <property name="can_focus">True</property>
                                     <property name="activates_default">True</property>
                                   </object>
                                 </child>
diff --git a/vcl/uiconfig/ui/printdialog.ui b/vcl/uiconfig/ui/printdialog.ui
index 043a27771a38..bdcf861f83bd 100644
--- a/vcl/uiconfig/ui/printdialog.ui
+++ b/vcl/uiconfig/ui/printdialog.ui
@@ -572,7 +572,7 @@
                                             <child>
                                               <object class="GtkEntry" id="pagerange">
                                                 <property name="visible">True</property>
-                                                <property name="can_focus">False</property>
+                                                <property name="can_focus">True</property>
                                                 <property name="hexpand">True</property>
                                                 <property name="placeholder_text" translatable="yes" context="printdialog|pagerange">e.g.: 1, 3-5, 7, 9</property>
                                               </object>
-- 
cgit