From a6db6af4822d6aea4b0629c9fe660a758b7fcba1 Mon Sep 17 00:00:00 2001
From: Venetia <venetiarosita@gmail.com>
Date: Mon, 8 Jan 2024 15:48:37 -0700
Subject: tdf#119931 Fix accessibility warnings in sw/uiconfig

In files linenumbering.ui and optfonttabpage.ui the labels 'intervallines',
'lines' and 'font_label' respectively are there for visual coherence but do
not provide any meaning. Therefore, moved them from suppression to false file

Change-Id: Ied1001a8b445574e4ceca92c4fdf45a4e5a8ca97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161807
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
---
 solenv/sanitizers/ui/modules/swriter.false | 3 +++
 solenv/sanitizers/ui/modules/swriter.suppr | 4 ----
 sw/uiconfig/swriter/ui/linenumbering.ui    | 1 +
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/solenv/sanitizers/ui/modules/swriter.false b/solenv/sanitizers/ui/modules/swriter.false
index 8777e8a326d6..d5c33a2cdc94 100644
--- a/solenv/sanitizers/ui/modules/swriter.false
+++ b/solenv/sanitizers/ui/modules/swriter.false
@@ -12,3 +12,6 @@ sw/uiconfig/swriter/ui/assignfieldsdialog.ui://GtkLabel[@id='addresselem'] orpha
 sw/uiconfig/swriter/ui/assignfieldsdialog.ui://GtkLabel[@id='previewelem'] orphan-label
 sw/uiconfig/swriter/ui/assignfieldsdialog.ui://GtkLabel[@id='matchelem'] orphan-label
 sw/uiconfig/swriter/ui/assignfragment.ui://GtkLabel[@id='preview'] orphan-label
+sw/uiconfig/swriter/ui/linenumbering.ui://GtkLabel[@id='intervallines'] orphan-label
+sw/uiconfig/swriter/ui/linenumbering.ui://GtkLabel[@id='lines'] orphan-label
+sw/uiconfig/swriter/ui/optfonttabpage.ui://GtkLabel[@id='font_label'] orphan-label
diff --git a/solenv/sanitizers/ui/modules/swriter.suppr b/solenv/sanitizers/ui/modules/swriter.suppr
index b27911bd11e0..4dd174b17a55 100644
--- a/solenv/sanitizers/ui/modules/swriter.suppr
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -69,13 +69,9 @@ sw/uiconfig/swriter/ui/insertscript.ui://GtkLabel[@id='label1'] orphan-label
 sw/uiconfig/swriter/ui/jumpposbox.ui://GtkEntry[@id='jumppos'] no-labelled-by
 sw/uiconfig/swriter/ui/labelformatpage.ui://GtkSpinButton[@id='top'] duplicate-mnemonic
 sw/uiconfig/swriter/ui/labelformatpage.ui://GtkDrawingArea[@id='preview'] no-labelled-by
-sw/uiconfig/swriter/ui/linenumbering.ui://GtkLabel[@id='format'] orphan-label
-sw/uiconfig/swriter/ui/linenumbering.ui://GtkLabel[@id='intervallines'] orphan-label
-sw/uiconfig/swriter/ui/linenumbering.ui://GtkLabel[@id='lines'] orphan-label
 sw/uiconfig/swriter/ui/mergeconnectdialog.ui://GtkLabel[@id='label2'] orphan-label
 sw/uiconfig/swriter/ui/numparapage.ui://GtkCheckButton[@id='checkCB_NUMBER_NEW_START'] missing-labelled-by
 sw/uiconfig/swriter/ui/optcomparison.ui://GtkSpinButton[@id='ignorelen'] no-labelled-by
-sw/uiconfig/swriter/ui/optfonttabpage.ui://GtkLabel[@id='font_label'] orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label10'] orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label11'] orphan-label
 sw/uiconfig/swriter/ui/opttablepage.ui://GtkLabel[@id='label12'] orphan-label
diff --git a/sw/uiconfig/swriter/ui/linenumbering.ui b/sw/uiconfig/swriter/ui/linenumbering.ui
index 16493f8f44bd..8c48970a4720 100644
--- a/sw/uiconfig/swriter/ui/linenumbering.ui
+++ b/sw/uiconfig/swriter/ui/linenumbering.ui
@@ -159,6 +159,7 @@
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
                             <property name="label" translatable="yes" context="linenumbering|format">Format:</property>
+                            <property name="mnemonic_widget">formatdropdown</property>
                             <property name="xalign">0</property>
                           </object>
                           <packing>
-- 
cgit